ADB setup

> I thought I fixed this in 4.0 but I guess I was wrong.
> On some newer *Books we accidentally power down when
the adb driver  
> attaches. As far as I know this happens on machines
which don't have  
> an ADB bus, so the PMU regards ADB commands as error
and powers down.  
> The attached patch will prevent the adb driver from
issuing any ADB  
> commands when the pmu node doesn't have an adb child.
I've tested it  
> on a PowerMac G4 which doesn't have ADB but the PMU is
similar enough  
> to the one used in newer PowerBooks although it doesn't
power down on  
> every error and a PowerBook 3400c which does have ADB.
On the G4 no  
> ADB commands are issued ( usually there would be a
timeout message )  
> and on the PowerBook the normal ADB devices attach.
> 
> Please test this on machines with or without ADB, if it
fixes the  
> power down problem and doesn't have any funny side
effects I'll  
> request pullup into 4.0

Do you have a test kernel with the patch incorporated?

BTW, my PowerBook G4 12" powered down when I hitted f2
key
twice or more with the kernel 3.99.x or earlier, but
4.99.31
works fine.  Not tested 4.0.x.

My machine is:
  PowerBook6,4 (late 2004)
  166.402MHz

Regards,

--
SUNAGAWA Keiki <kei_sunba2.so-net.ne.jp>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Oct 3, 2007, at 09:37, SUNAGAWA Keiki wrote:

>> I thought I fixed this in 4.0 but I guess I was
wrong.
>> On some newer *Books we accidentally power down
when the adb driver
>> attaches. As far as I know this happens on machines
which don't have
>> an ADB bus, so the PMU regards ADB commands as
error and powers down.
>> The attached patch will prevent the adb driver from
issuing any ADB
>> commands when the pmu node doesn't have an adb
child. I've tested it
>> on a PowerMac G4 which doesn't have ADB but the PMU
is similar enough
>> to the one used in newer PowerBooks although it
doesn't power down on
>> every error and a PowerBook 3400c which does have
ADB. On the G4 no
>> ADB commands are issued ( usually there would be a
timeout message )
>> and on the PowerBook the normal ADB devices
attach.
>>
>> Please test this on machines with or without ADB,
if it fixes the
>> power down problem and doesn't have any funny side
effects I'll
>> request pullup into 4.0
>
> Do you have a test kernel with the patch incorporated?

Sure:
ftp://ftp.netbsd.org/pub/NetBSD/misc/macallan/macppc/netbsd_
4_generic

> BTW, my PowerBook G4 12" powered down when I
hitted f2 key
> twice or more with the kernel 3.99.x or earlier, but
4.99.31
> works fine.  Not tested 4.0.x.

Sounds like something trying to control brightness on a PMU
that  
doesn't support it - same thing, PMU thinks it got an
invalid command  
and powers down.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBRwQ+M8pnzkX8Yg2nAQKemwf/Yu4dKWGllI+scMxmeVJqZFmXYAPh
VQ4f
9WG3BlpnJUvI98h5Ok7t8v+iEeE6+vSLA9dIj5Rq69vQ5lYYbu4t7QTJIiea
KsK6
Y8AQptjhQisB/5S0rccmjiC6pQUeaCP9lstI+O9/KZDW3C/hsCrD77RVbY9S
iMm0
SY0hNgyRxtRkh3O1aWdHDlGec7VmauoLeva9j0IPBuDFmzSeaZNN6mwjZNOs
4yHo
U86OQ0+sT1rDCucc+k0+pSyWB1tmIKFTyPmbuVsPznKuoox8M/JxZ+THSViV
c1zE
QvyrW0rJ84bAmYphq4dlxPgdS1AgE3/jZOWbX6Iz7gqUMHjeya2bBw==
=9D4H
-----END PGP SIGNATURE-----

Hello,

> > Do you have a test kernel with the patch
incorporated?
> 
> Sure:
>
ftp://ftp.netbsd.org/pub/NetBSD/misc/macallan/macppc/netbsd_
4_generic

Thanks.  I downloaded and tested this kernel and 4.0RC2
GENERIC, both powered down when I pressed f2 key
repeatedly.

> > BTW, my PowerBook G4 12" powered down when I
hitted f2 key
> > twice or more with the kernel 3.99.x or earlier,
but 4.99.31
> > works fine.  Not tested 4.0.x.
> 
> Sounds like something trying to control brightness on a
PMU that  
> doesn't support it - same thing, PMU thinks it got an
invalid command  
> and powers down.

Both kernel I checked dropped into ddb when I loaded them
with -a option and did the key-pressing test on prompt with
root partition.  I set the OF variable input-device to
keyboard, not adb-keyboard.  Hope this helps.

Regards,

--
SUNAGAWA Keiki <kei_sunba2.so-net.ne.jp>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Oct 4, 2007, at 16:14, SUNAGAWA Keiki wrote:

> Hello,
>
>>> Do you have a test kernel with the patch
incorporated?
>>
>> Sure:
>>
ftp://ftp.netbsd.org/pub/NetBSD/misc/macallan/macppc/netbsd_
4_generic
>
> Thanks.  I downloaded and tested this kernel and
4.0RC2
> GENERIC, both powered down when I pressed f2 key
repeatedly.

Err, that's not what the patch was supposed to fix - those
button  
events are an entirely different problem. But since your
keyboard  
apparently works it apparently did what I intended it to
do.

have fun
Michael


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBRwVld8pnzkX8Yg2nAQJihwf8CL2Pg2fEsFvttxNHNPw2y4Yw40vX
TCRB
mi9ZRayQhGHSWOQScHIBA7dhlhcGWZr+aaY3FwGOLqpjGYk9US2qfBOi/M15
DlDW
J9whgl6DM5fYVJIkhpmegGcHPaif7VKaXQ+ltHe+myd2i4/kwyNq/CESEJz3
/5iq
ViSRufJkL0MQ/1NZb9RDTYtav3ZfDiACGVn/bfDDPmFV9H9mMGY3h/b+qxT/
9XO+
Xje0kg/IF+EZzi6JHLslfoBkq4anZHdlt4KiTdj4mIjqbKdOBGKzdjMV+03r
2yGl
OJRJj4cu1jiqREdrd5d15aQZA0YRb8E0taM9zRdiLlkxJXWFweTAzw==
=NDOZ
-----END PGP SIGNATURE-----

Hello,

> Hello,
> 
> On Oct 4, 2007, at 16:14, SUNAGAWA Keiki wrote:
> 
> > Hello,
> >
> >>> Do you have a test kernel with the patch
incorporated?
> >>
> >> Sure:
> >>
ftp://ftp.netbsd.org/pub/NetBSD/misc/macallan/macppc/netbsd_
4_generic
> >
> > Thanks.  I downloaded and tested this kernel and
4.0RC2
> > GENERIC, both powered down when I pressed f2 key
repeatedly.
> 
> Err, that's not what the patch was supposed to fix -
those button  
> events are an entirely different problem. But since
your keyboard  
> apparently works it apparently did what I intended it
to do.

Sorry for my misunderstanding.  I'm on a business trip
tonight and will get
back home tommorow night.  Please let me know if further
testing is needed.