root= vs. boodev=

The NetBSD documentation is full of
"root=/dev/hda1" examples.  As far
as I can tell nothing in the kernel cares about that.

Does anyone remember what the significance of that parameter
ist?

Maybe it has been replace by the undocumented rootdev=
parameter?
Is that so?

--chris

On Sun, Jun 17, 2007 at 05:45:22PM +0200, Christoph Badura
wrote:
> The NetBSD documentation is full of
"root=/dev/hda1" examples.  As far
> as I can tell nothing in the kernel cares about that.
> 
> Does anyone remember what the significance of that
parameter ist?

This is bad cut'n'paste from linux configs.

> 
> Maybe it has been replace by the undocumented rootdev=
parameter?
> Is that so?

it's 'bootdev='

-- 
Manuel Bouyer <bouyerantioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la
difference
--

On Sun, Jun 17, 2007 at 07:06:00PM +0200, Manuel Bouyer
wrote:
> On Sun, Jun 17, 2007 at 05:45:22PM +0200, Christoph
Badura wrote:
> > The NetBSD documentation is full of
"root=/dev/hda1" examples.  As far
> > as I can tell nothing in the kernel cares about
that.
> > 
> > Does anyone remember what the significance of that
parameter ist?
> 
> This is bad cut'n'paste from linux configs.
> 
> > 
> > Maybe it has been replace by the undocumented
rootdev= parameter?
> > Is that so?
> 
> it's 'bootdev='

our multiboot support also uses root= . Could NetBSD/Xen
support this for
consistency?

Pavel

On Sun, Jun 17, 2007 at 10:42:19PM +0200, Pavel Cahyna
wrote:
> > it's 'bootdev='
> 
> our multiboot support also uses root= . Could
NetBSD/Xen support this for
> consistency?

Yes, it's easy:
--- xen_machdep.c       22 Jan 2006 20:15:51 -0000     
1.16
+++ xen_machdep.c       18 Jun 2007 14:34:10 -0000
 -187,7
+187,8 
 
                switch (what) {
                case XEN_PARSE_BOOTDEV:
-                       if (strncasecmp(opt,
"bootdev=", 8) == 0)
+                       if (strncasecmp(opt,
"bootdev=", 8) == 0 ||
+                           strncasecmp(opt,
"root=", 5) == 0)
                                strncpy(xcp->xcp_bootdev,
opt + 8,
                                   
sizeof(xcp->xcp_bootdev));
                        break;

-- 
Manuel Bouyer, LIP6, Universite Paris VI.          
Manuel.Bouyerlip6.fr
     NetBSD: 26 ans d'experience feront toujours la
difference
--

On Sun, Jun 17, 2007 at 07:06:00PM +0200, Manuel Bouyer
wrote:
> On Sun, Jun 17, 2007 at 05:45:22PM +0200, Christoph
Badura wrote:
> > The NetBSD documentation is full of
"root=/dev/hda1" examples.  As far
> > as I can tell nothing in the kernel cares about
that.
> This is bad cut'n'paste from linux configs.

OK.

> > Maybe it has been replace by the undocumented
rootdev= parameter?
> > Is that so?
> it's 'bootdev='

Err, right 'bootdev='. I was in a bit of a hurry.

--chris

On Mon, Jun 18, 2007 at 04:34:50PM +0200, Manuel Bouyer
wrote:
> On Sun, Jun 17, 2007 at 10:42:19PM +0200, Pavel Cahyna
wrote:
> > > it's 'bootdev='
> > 
> > our multiboot support also uses root= . Could
NetBSD/Xen support this for
> > consistency?
> 
> Yes, it's easy:
> --- xen_machdep.c       22 Jan 2006 20:15:51 -0000     
1.16
> +++ xen_machdep.c       18 Jun 2007 14:34:10 -0000
>  -187,7 +187,8 
>  
>                 switch (what) {
>                 case XEN_PARSE_BOOTDEV:
> -                       if (strncasecmp(opt,
"bootdev=", 8) == 0)
> +                       if (strncasecmp(opt,
"bootdev=", 8) == 0 ||
> +                           strncasecmp(opt,
"root=", 5) == 0)
>                                
strncpy(xcp->xcp_bootdev, opt + 8,

Shouldn't this be 5 for the second case?


>                                    
sizeof(xcp->xcp_bootdev));
>                         break;

On Thu, Jun 28, 2007 at 10:06:18PM +0200, Pavel Cahyna
wrote:
> On Mon, Jun 18, 2007 at 04:34:50PM +0200, Manuel Bouyer
wrote:
> > On Sun, Jun 17, 2007 at 10:42:19PM +0200, Pavel
Cahyna wrote:
> > > > it's 'bootdev='
> > > 
> > > our multiboot support also uses root= . Could
NetBSD/Xen support this for
> > > consistency?
> > 
> > Yes, it's easy:
> > --- xen_machdep.c       22 Jan 2006 20:15:51 -0000
     1.16
> > +++ xen_machdep.c       18 Jun 2007 14:34:10
-0000
> >  -187,7 +187,8 
> >  
> >                 switch (what) {
> >                 case XEN_PARSE_BOOTDEV:
> > -                       if (strncasecmp(opt,
"bootdev=", 8) == 0)
> > +                       if (strncasecmp(opt,
"bootdev=", 8) == 0 ||
> > +                           strncasecmp(opt,
"root=", 5) == 0)
> >                                
strncpy(xcp->xcp_bootdev, opt + 8,
> 
> Shouldn't this be 5 for the second case?

You're right. I fixed it. thanks !

-- 
Manuel Bouyer <bouyerantioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la
difference
--