Re: CVS commit: src/sys/sys

On Thu, May 31, 2007 at 12:46:10PM +0100, Andrew Doran
wrote:
> > > 
> > > Thanks for doing this. You probably need to
bump the major version of
> > > librt and send a note to current-users, since
the ABI has changed.
> > 
> > major bump will not help, as the structure in
question is not a
> > library interface, it's a kernel interface.  The
only think library
> > does - is passing the structure to the syscall. 
Thus, syscall
> > versioning is also required.
> 
> Ah, I forgot about that.

Is it worth adding a field to the interface structure to
contain it's
version ?

	David

-- 
David Laight: davidl8s.co.uk

On Thu, 31 May 2007 13:56:55 +0100
David Laight <davidl8s.co.uk> wrote:

> On Thu, May 31, 2007 at 12:46:10PM +0100, Andrew Doran
wrote:
> > > > 
> > > > Thanks for doing this. You probably need
to bump the major
> > > > version of librt and send a note to
current-users, since the
> > > > ABI has changed.
> > > 
> > > major bump will not help, as the structure in
question is not a
> > > library interface, it's a kernel interface. 
The only think
> > > library does - is passing the structure to
the syscall.  Thus,
> > > syscall versioning is also required.
> > 
> > Ah, I forgot about that.
> 
> Is it worth adding a field to the interface structure
to contain it's
> version ?
> 
How will you get it initialized properly, given that lots of
existing
code simply bzeros such structures before use? 



		--Steve Bellovin, http://www.cs.columbi
a.edu/~smb

On May 31, 2007, at 5:56 AM, David Laight wrote:

> Is it worth adding a field to the interface structure
to contain it's
> version ?

Only if you do it to every syscall.  Otherwise, what's the
point?

>
>
> 	David
>
> -- 
> David Laight: davidl8s.co.uk

-- thorpej