Two comments on the H.323 conntrack/NAT helper

Two comments on the H.323 conntrack/NAT helper:
- the function prototypes in ip_nat_helper_h323.c are
_ugly_,
  please move them to a header file
- is there a reason for not using EXPORT_SYMBOL_GPL?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan
asked suddenly out
        of the darkness. There had been need of rain for
many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck -
Dragon Seed

[The hotmail address of the author doesn't work, CCed
sourceforge-address]

Adrian Bunk wrote:
> Two comments on the H.323 conntrack/NAT helper:
> - the function prototypes in ip_nat_helper_h323.c are
_ugly_,
>   please move them to a header file

Their ugliness is because of the current API, which cleaned
up
quite a lot of the surrounding code, but requires this
ugliness
from each helper. I would like to keep them visible as a
reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.

> - is there a reason for not using EXPORT_SYMBOL_GPL?

I would prefer that too.