List Info

Thread: Re: commit: ldap/servers/slapd/back-perl SampleLDAP.pm




Re: commit: ldap/servers/slapd/back-perl SampleLDAP.pm
country flaguser name
United Kingdom
2007-06-15 07:46:47
<quote who="hallvardOpenLDAP.org">
> Update of
/repo/OpenLDAP/pkg/ldap/servers/slapd/back-perl
>
> Modified Files:
> 	SampleLDAP.pm  1.12 -> 1.13
>

I've run Perl::Critic over this and fixed/updated to latest
"Perl Best
Practices". We might as well have an up to date
sample.

Do you mind if I commit my changes?

cpan Perl::Critic
perlcritic -1 SampleLDAP.pm

Then fixed accordingly.

Thanks,

Gavin.



Re: commit: ldap/servers/slapd/back-perl SampleLDAP.pm
country flaguser name
Norway
2007-06-15 09:18:34
Gavin Henry writes:
> I've run Perl::Critic over this and fixed/updated to
latest "Perl Best
> Practices". We might as well have an up to date
sample.
>
> Do you mind if I commit my changes?

My impression is that back-perl hovers on the verge of code
rot, and any
change is likely for the better.

As for RE23, I don't know what Perl::Critic is, but as close
we are to a
release I suggest a fix to SampleLDAP.pm can wait for
2.3.37.

-- 
Regards,
Hallvard

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )