Re: commit: ldap/servers/slapd/back-perl SampleLDAP.pm

Gavin Henry writes:
> Nope, you are right. My mistake. It does work, but
should be:
> print {*STDERR} "Here in newn";
> (...)
> See:
> http://search.cpan.org/~thaljef/Perl-Critic-1.06/lib/
Perl/Critic/Policy/InputOutput/RequireBracedFileHandleWithPr
int.pm

Heh.  Capital-letter STDERR stands out enough for me, but i
guess code
looks different to different people.

> (...)
>> I suspect there are some pretty old Perl versions
out there, in
>> particular on Windows.
>
> We should change it to:
>
> $SampleLDAP::VERSION = '1.00';
>
> That will work on any 5+ version of Perl.

Great.  I guess it's 1.01 by now though.

-- 
Regards,
Hallvard

<quote who="Hallvard B Furuseth">
> Gavin Henry writes:
>> Nope, you are right. My mistake. It does work, but
should be:
>> print {*STDERR} "Here in newn";
>> (...)
>> See:
>> http://search.cpan.org/~thaljef/Perl-Critic-1.06/lib/
Perl/Critic/Policy/InputOutput/RequireBracedFileHandleWithPr
int.pm
>
> Heh.  Capital-letter STDERR stands out enough for me,
but i guess code
> looks different to different people.

It's means slightly different than that 

>
>> (...)
>>> I suspect there are some pretty old Perl
versions out there, in
>>> particular on Windows.
>>
>> We should change it to:
>>
>> $SampleLDAP::VERSION = '1.00';
>>
>> That will work on any 5+ version of Perl.
>
> Great.  I guess it's 1.01 by now though.

Yup.

>
> --
> Regards,
> Hallvard
>