Approved, but I found one issue with IE6/IE7 that needs
attention.
If you use the example in the jira report and click Load,
Error, Load. The
second (or any subsequent) load does not display the image.
This works fine
in FireFox 1.5/2.0. The events look fine.
>Change 20070306-maxcarlson-m by maxcarlson max-carlsons-
>computer.local on 2007-03-06 16:14:24 PST
> in /Users/maxcarlson/openlaszlo/legals-clean
>
>Summary: Fix onload/timeout/error
>
>New Features: If the same image size is loaded twice,
onerror and
>onload events are still sent. This fixes a number of
issues.
>
>Bugs Fixed: LPP-3387 - Fix ontimeout and onerror for
DHTML image loading
>
>Technical Reviewer: promanik
>QA Reviewer: jcrowley
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: LzSprite.js - setSource now tracks whether a
call came from
>within the sprite or was external, so external calls
always get an
>onload/error/timeout events. Store condition of last
load on the
>image object, so we know what event to sent when pulling
from the
>cache. Add onerror/ontimeout events.
>
>LzPool.js - Callback for cache hits is now passed the
object that
>would be returned.
>
>LaszloView.lzs - Add onerror/timeout events. Only
update width/
>height when it changes, and send onload events
regardless. Add
>callbacks for ontimeout/error events.
>
>
>Tests: http://localhost:8080/legals-clean/test/lztest/lzt
est-view.lzx
>passes swf and dhtml. See updated testcase at http://
>jira.openlaszlo.org/jira/browse/LPP-3387. The timeout
button only
>works if you click it before you load anything.
>
>
>Files:
>M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>M WEB-INF/lps/lfc/kernel/dhtml/LzPool.js
>M WEB-INF/lps/lfc/views/LaszloView.lzs
>
>Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070306-
>maxcarlson-m.tar
|