Re: For Review: Change 20070413-maxcarlson-k Summary: Clean up for "LzUtils" or nulli

I have a couple of questions about this changeset.


On IE/dhtml I'm seeing an error when you leave the page.

LzSprite.js

     LzUtils.callback.remove(img.owner);

If img.owner is null, this condition is not checked.


What does resurrect img do? After clicking it, the image
isn't displayed 
again. In SWF you get an undefined error in the console, and
in dhtml you 
get an error.


>Change 20070413-maxcarlson-k by maxcarlsonplastik
on 2007-04-13
>14:40:54 PDT
>      in /Users/maxcarlson/openlaszlo/legals-clean
>      for 
http://svn.openlaszlo.org/openlaszlo/branches/legals
>
>Summary: Clean up for "LzUtils" or nullify
more attributes after
>destroying a view
>
>New Features:
>
>Bugs Fixed: LPP-3868 - Clean up for "LzUtils"
or nullify more
>attributes after destroying a view
>
>Technical Reviewer: promanik
>QA Reviewer: jcrowley
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: LzSprite.js - call callback.destroy();
>
>LzUtils.lzs - Add destroy method
>
>dev-console.* - Update dev consoles
>
>
>Tests: See testcase in LPP-3868.  Also ran lzpix and
amazon with lots
>of reloads and searches.
>
>Files:
>M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>M      WEB-INF/lps/lfc/kernel/LzUtils.lzs
>M      lps/admin/dev-console.lzx.js
>M      lps/admin/dev-console.lzx.swf
>
>Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070413-

>maxcarlson-k.tar

Philip Romanik wrote:
> I have a couple of questions about this changeset.
> 
> 
> On IE/dhtml I'm seeing an error when you leave the
page.
> 
> LzSprite.js
> 
>     LzUtils.callback.remove(img.owner);
> 
> If img.owner is null, this condition is not checked.

I'll look into this.

> 
> What does resurrect img do? After clicking it, the
image isn't displayed 
> again. In SWF you get an undefined error in the
console, and in dhtml 
> you get an error.

It should give errors with the patch applied.  The test is
only for 
DHTML.  Without the patch, it would bring back a copy of the
destroyed 
image, at least in Firefox.

> 
>> Change 20070413-maxcarlson-k by maxcarlsonplastik
on 2007-04-13
>> 14:40:54 PDT
>>      in /Users/maxcarlson/openlaszlo/legals-clean
>>      for 
http://svn.openlaszlo.org/openlaszlo/branches/legals
>>
>> Summary: Clean up for "LzUtils" or
nullify more attributes after
>> destroying a view
>>
>> New Features:
>>
>> Bugs Fixed: LPP-3868 - Clean up for
"LzUtils" or nullify more
>> attributes after destroying a view
>>
>> Technical Reviewer: promanik
>> QA Reviewer: jcrowley
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: LzSprite.js - call callback.destroy();
>>
>> LzUtils.lzs - Add destroy method
>>
>> dev-console.* - Update dev consoles
>>
>>
>> Tests: See testcase in LPP-3868.  Also ran lzpix
and amazon with lots
>> of reloads and searches.
>>
>> Files:
>> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>> M      WEB-INF/lps/lfc/kernel/LzUtils.lzs
>> M      lps/admin/dev-console.lzx.js
>> M      lps/admin/dev-console.lzx.swf
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070413-

>> maxcarlson-k.tar
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org