Re: Fwd: work on Issue 55064

Frank Schönheit - Sun Microsystems Germany wrote:
> Hello Zhao Sheng,
>
> (I included Herbert and Philipp in this mail, again.
Please let's keep
> it his way to reply to all, since this scales better:
more people than
> just one can potentially answer your questions.
> While we are at scaling: Did Herbert/Philipp ever
suggest to you to
> carry this discussion to a mailing list such as devopenoffice.org?)
>
>   
>> in funciton impl_executeFontDialog_nothrow, a line
like this:
>>  if ( RET_OK == aDlg.Execute() )
>>             {
>>                 const SfxItemSet* pOut =
aDlg.GetOutputItemSet();
>> It is to get the ItemSet from the dialog and then
call 
>> translateItemsToProperties in fontdialog.cxx to
finally get the
>> Item's font into the properties of the form
control, but there are no 
>> CJK or CTL fonts items which are set by the user
>> so the font only takes the Western fonts, and is it
because like you 
>> said DisableItem(SID_ATTR_CHAR_CJK_*)
>> lines takes effect.
>> and further more, we still need to write new code
to handle CTL or CJK 
>> font itmes in translateItemsToProperties, or put
>> them in a new function.
>> but there is a problem, how can we know if the user
wants to set the CTL 
>> font or not, because if the user choose all the
fonts
>> Western's CJK and CTL, which one should appear in
the font property in 
>> form control properties
>>     
>
> The dialog re-uses the same pages as other dialogs of
this type, namely
> the tab pages from svx/source/dialog/chardlg.cxx. Those
pages hide their
> CJK/CTL-related controls unless you enable CJK/CTL
support in
> Tools/Options/Language Settings/Languages. So, if you
enable CJK/CTL,
> the respective controls become visible in the dialog,
the user can make
> changes, and also the item set of the dialog should
contain the items
> which describe those changes.
> (Of course, you need to remove the DisableItem calls
beforehand.)
>
> Ciao
> Frank
>
>   
so the item set now dosen't contain the items which describe
the changes 
of CTL and CJK, that is the problem?

thx

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribegraphics.openoffice.org
For additional commands, e-mail: dev-helpgraphics.openoffice.org

Hello Zhao Sheng,

>> The dialog re-uses the same pages as other dialogs
of this type, namely
>> the tab pages from svx/source/dialog/chardlg.cxx.
Those pages hide their
>> CJK/CTL-related controls unless you enable CJK/CTL
support in
>> Tools/Options/Language Settings/Languages. So, if
you enable CJK/CTL,
>> the respective controls become visible in the
dialog, the user can make
>> changes, and also the item set of the dialog should
contain the items
>> which describe those changes.
>> (Of course, you need to remove the DisableItem
calls beforehand.)
>>   
> so the item set now dosen't contain the items which
describe the changes 
> of CTL and CJK, that is the problem?

I would suppose so, yes.

Ciao
Frank

-- 
- Frank Schönheit, Software Engineer         
frank.schoenheitsun.com -
- Sun Microsystems                       http://www.sun.com/star
office -
- OpenOffice.org Base                        http://dba.openoffice.org -
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
- - - - -  -
- Sitz der Gesellschaft:                                    
          -
- Sun Microsystems GmbH, Sonnenallee 1, D-85551
Kirchheim-Heimstetten  -
- Amtsgericht München: HRB 161028                           
          -
- Geschäftsführer: Wolfgang Engels, Dr. Roland Bömer        
          -
- Vorsitzender des Aufsichtsrates: Martin Häring            
          -
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
- - - - -  -

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribegraphics.openoffice.org
For additional commands, e-mail: dev-helpgraphics.openoffice.org