A question about destructor

Hello all,

I am absorbed in modularization of ODFToolkit project about
2 months.
For the modularization, I need to move the member
"SwRootFrm  *pLayout" from 
class "SwDoc" to class "ViewShell". Then
we should pass a parameter "SwRootFrm&
rLayout"
at where "pLayout" was used originally. So, I
should modify many functions by passing a reference 
paremeter "rLayout".
But now I face a question as follows:

in file swsourcecoredocdocredln.cxx
the destructor :
SwRedline::~SwRedline()
{
......
if( !GetDoc()->IsInDtor() )
   GetDoc()->DeleteSection(
&pCntntSect->GetNode(),rLayout );
......
}

The parameter "rLayout" in function DeleteSection
is added by me and this parameter is passed from the view
class "ViewShell".
That means the destructor don't know this patameter.but the
modularization work require me to add this parameter.
Then I wonder how to deal with it and make the destructor
can dispose this function.

Looking forward to hearing from you!
Best wishes,



lijian
2007-07-24

lijian,

no chance to pass it to the DTOR, of course.
We must figure out how to deal with DeleteSection() when not
having a Layout...

I didn't look into the code right now - maybe someone from
Writer team has a suggestion at hand? ;)

Malte. 



lijian wrote:
> Hello all,
>
> I am absorbed in modularization of ODFToolkit project
about 2 months.
> For the modularization, I need to move the member
"SwRootFrm  *pLayout" from 
> class "SwDoc" to class "ViewShell".
Then we should pass a parameter "SwRootFrm&
rLayout"
> at where "pLayout" was used originally. So, I
should modify many functions by passing a reference 
> paremeter "rLayout".
> But now I face a question as follows:
>
> in file swsourcecoredocdocredln.cxx
> the destructor :
> SwRedline::~SwRedline()
> {
> ......
> if( !GetDoc()->IsInDtor() )
>    GetDoc()->DeleteSection(
&pCntntSect->GetNode(),rLayout );
> ......
> }
>
> The parameter "rLayout" in function
DeleteSection is added by me and this parameter is passed
from the view class "ViewShell".
> That means the destructor don't know this patameter.but
the modularization work require me to add this parameter.
> Then I wonder how to deal with it and make the
destructor can dispose this function.
>
> Looking forward to hearing from you!
> Best wishes,
>
>
>
> lijian
> 2007-07-24
>
>   

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesw.openoffice.org
For additional commands, e-mail: dev-helpsw.openoffice.org

Hi,

Malte Timmermann wrote:
> lijian,
>
> no chance to pass it to the DTOR, of course.
> We must figure out how to deal with DeleteSection()
when not having a Layout...
>
> I didn't look into the code right now - maybe someone
from Writer team has a suggestion at hand? ;)
>   
My suggestion is to discuss this problem in one mailing list
only 
Please read my comments/questions at the devooo list
in the thread 
started from liutao with the same subject?!
Regards
    Andreas
> Malte. 
>
>
>
> lijian wrote:
>   
>> Hello all,
>>
>> I am absorbed in modularization of ODFToolkit
project about 2 months.
>> For the modularization, I need to move the member
"SwRootFrm  *pLayout" from 
>> class "SwDoc" to class
"ViewShell". Then we should pass a parameter
"SwRootFrm& rLayout"
>> at where "pLayout" was used originally.
So, I should modify many functions by passing a reference 
>> paremeter "rLayout".
>> But now I face a question as follows:
>>
>> in file swsourcecoredocdocredln.cxx
>> the destructor :
>> SwRedline::~SwRedline()
>> {
>> ......
>> if( !GetDoc()->IsInDtor() )
>>    GetDoc()->DeleteSection(
&pCntntSect->GetNode(),rLayout );
>> ......
>> }
>>
>> The parameter "rLayout" in function
DeleteSection is added by me and this parameter is passed
from the view class "ViewShell".
>> That means the destructor don't know this
patameter.but the modularization work require me to add this
parameter.
>> Then I wonder how to deal with it and make the
destructor can dispose this function.
>>
>> Looking forward to hearing from you!
>> Best wishes,
>>
>>
>>
>> lijian
>> 2007-07-24
>>
>>   
>>     
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesw.openoffice.org
> For additional commands, e-mail: dev-helpsw.openoffice.org
>
>   


-- 
Sun Microsystems GmbH       Andreas Martens
Nagelsweg 55                StarOffice/OpenOffice.org
20097 Hamburg               Phone: +49 (0)40 23646-500
Germany
http://www.sun.de          
Fax: +49 (0)40 23646-550
mailto:Andreas.Martenssun.com
Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1,

D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesw.openoffice.org
For additional commands, e-mail: dev-helpsw.openoffice.org