Writer freezes/loops when deleting a table containing vertically merged cells

Hello Andreas,
I'm investigating issue 
80050(http://www.openoffice.org/issues/show_bug.cgi?id=80050
), in 
swsourcecorelayouttrvlfrm.cxx,SwLayoutFrm::GetCntntPos()
,in block:
if ( !pActual )
{
...
pActual = pCntnt;
...
}

The pCntnt will be always NULL when deleting a table
containing merged 
cells. And it cannt break out the loop.
At present I havent find a good way to resolve it. Could you
give me 
some hints?

Regards,
Yan Wu

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesw.openoffice.org
For additional commands, e-mail: dev-helpsw.openoffice.org

Hi Yan Wu,

Yan Wu wrote:
> Hello Andreas,
> I'm investigating issue 
> 80050(http://www.openoffice.org/issues/show_bug.cgi?id=80050
), in 
>
swsourcecorelayouttrvlfrm.cxx,SwLayoutFrm::GetCntntPos()
,in block:
> if ( !pActual )
> {
> ...
> pActual = pCntnt;
> ...
> }
>
> The pCntnt will be always NULL when deleting a table
containing merged 
> cells. And it cannt break out the loop.
> At present I havent find a good way to resolve it.
Could you give me 
> some hints?
This could be fixed in the method
"SwLayoutFrm::ContainsCntnt". There is 
already a special handling for section frames, the same
could be done 
for table frames. A simple replacement of
"pLayLeaf->IsSctFrm()" by " 
(pLayLeaf->IsSctFrm() || pLayLeaf->IsTabFrm()) "
would fix this loop.
But this would only cover the root cause of the error. We
have to avoid 
an empty SwTabFrm.
So I fixed this issue in ndtbl.cxx, function SwDoc:eleteRow
Col(..). 
The detection of a table has to be removed completely failed
for tables 
with merged cells (row-span).
Regards
    Andreas
>
> Regards,
> Yan Wu
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesw.openoffice.org
> For additional commands, e-mail: dev-helpsw.openoffice.org
>


-- 
Sun Microsystems GmbH       Andreas Martens
Nagelsweg 55                StarOffice/OpenOffice.org
20097 Hamburg               Phone: +49 (0)40 23646-500
Germany
http://www.sun.de          
Fax: +49 (0)40 23646-550
mailto:Andreas.Martenssun.com
Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1,

D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesw.openoffice.org
For additional commands, e-mail: dev-helpsw.openoffice.org

Hi Andreas,
Thanks!That's great.

Regards,
Yan Wu

Andreas Martens wrote:
> Hi Yan Wu,
> 
> Yan Wu wrote:
>> Hello Andreas,
>> I'm investigating issue 
>> 80050(http://www.openoffice.org/issues/show_bug.cgi?id=80050
), in 
>>
swsourcecorelayouttrvlfrm.cxx,SwLayoutFrm::GetCntntPos()
,in block:
>> if ( !pActual )
>> {
>> ...
>> pActual = pCntnt;
>> ...
>> }
>>
>> The pCntnt will be always NULL when deleting a
table containing merged 
>> cells. And it cannt break out the loop.
>> At present I havent find a good way to resolve it.
Could you give me 
>> some hints?
> This could be fixed in the method
"SwLayoutFrm::ContainsCntnt". There is 
> already a special handling for section frames, the same
could be done 
> for table frames. A simple replacement of
"pLayLeaf->IsSctFrm()" by " 
> (pLayLeaf->IsSctFrm() || pLayLeaf->IsTabFrm())
" would fix this loop.
> But this would only cover the root cause of the error.
We have to avoid 
> an empty SwTabFrm.
> So I fixed this issue in ndtbl.cxx, function SwDoc:eleteRow
Col(..). 
> The detection of a table has to be removed completely
failed for tables 
> with merged cells (row-span).
> Regards
>    Andreas
>>
>> Regards,
>> Yan Wu


------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesw.openoffice.org
For additional commands, e-mail: dev-helpsw.openoffice.org