List Info

Thread: Fix compile on systems without gstreamer




Fix compile on systems without gstreamer
country flaguser name
Germany
2007-02-19 16:00:57
Currently, ooo-build fails to build on Linux systems that
don't have gstreamer 
installed.

The patch I've attached is a replacement for ooo-build's 
gstreamer-config-office.diff, it adds a proper check for
gstreamer, and also 
adds a --disable-gstreamer switch for people who have
gstreamer but don't 
want the dependency in.

I'm not committing it because it's the first time something
in ooo-build wants 
to use PKG_CHECK_EXIST -- aclocal has to be rerun to drag in
the definition 
after applying the patch, and I'm not sure adding an aclocal
run to the build 
scripts is ok with everyone.

Regards,
bero

_______________________________________________
Openoffice mailing list
Openofficelists.ximian.com
h
ttp://lists.ximian.com/mailman/listinfo/openoffice

  
Re: Fix compile on systems without gstreamer
user name
2007-02-20 03:01:22
Hi,

Bernhard Rosenkraenzer wrote:
> I'm not committing it because it's the first time
something in ooo-build wants 
> to use PKG_CHECK_EXIST -- aclocal has to be rerun to
drag in the definition 
> after applying the patch, and I'm not sure adding an
aclocal run to the build 
> scripts is ok with everyone.

simple solution. Patch aclocal.m4, too (better:
acinclude.m4, iirc)
But why do you need PKG_CHECK_EXIST after all?

If someone wants to build with gstreamer and
PKG_CHECK_MODULES fails (and
(s)he doesn't want to install gstreamer or he doesn't want
to enable gstreamer
support) (s)he can use --disable-gstreamer. We should honour
what people want,
otherwise they might run into the situation that they might
want gstreamer,
but somehow don't have it installed and therefore don't get
it.
(OK, that shopuld be seeable by the packages' contents and
library deps,
but...)

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.
org/~rene/
 `. `'  renedebian.org | GnuPG-Key ID: 248AEB73
   `-   Fingerprint: 41FA F208 28D4 7CA5 19BB  7AD9 F859
90B0 248A EB73


_______________________________________________
Openoffice mailing list
Openofficelists.ximian.com
h
ttp://lists.ximian.com/mailman/listinfo/openoffice

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )