Working FullScreen function

Stephan Schaefer wrote:
> Pierre de Filippis wrote:
>> Hi,
>>
>> On Jul 25, 2006, at 12:59 PM, Florian Heckl wrote:
>>
>>> - You seem to have included some of Pavel's
menu trick patch in your 
>>> own patch
>>
>> Corrected.
>>
>>> - You implemented the function without the need
for QuickTime nor 
>>> ApplicationServices, so no need to include the
headers and link 
>>> against them
>>
>> I actually need ApplicationServices for all the
Quartz Display 
>> Services functions and data types but Carbon
includes the framework 
>> automatically.
>>
>>> - Maybe I didn't apply the patch correctly,
but I had to manually 
>>> add the member variables you introduced.
>>
>> Corrected.
>>
>>> - When including header files try to minimize
the inclusion's impact 
>>> (you had included QuickTime and
ApplicationServices framework in 
>>> auqavclevents.hxx (I believe) which is included
by more than just 
>>> salframe.cxx)
>>
>> Good advice.
>>
>> Here is the new patch:
>>     h
ttp://www.aliscafo.com/OOo/Patches/fullscreen.diff
>>
>
>
>
> Hi Pierre,
>
> The patch looks good, except minor changes in the
comments. Please 
> remove your name from it, especially since the
abbreviation of your 
> name clashes with a file format name which might be
misleading here ;) 
> I'm sure we can put the names of all contributors
somewhere else. If 
> you could also move your comments inside of the method
you are 
> describing, that would be great.
Stephan:

This is exactly what comments are for:

(C++/Java formatted)

/*  Code contributed by Pierre de Filippis on 07/26/2006
This code block checks for the existence of an open MenuBar
and attaches 
a new Menu to it
If the MenuBar does not exist, forces creation of one and
attaches a new 
Menu to it
If the MenuBar cannot be changed, throws an exception which
is caught by
Exception portion to force error to screen.
*/

This eases confusion as to purpose of code and who made it.

Could we ALL use this style?

James M.

------------------------------------------------------------
---------
To unsubscribe, e-mail: mac-unsubscribeporting.openoffice.org
For additional commands, e-mail: mac-helpporting.openoffice.org