Re: Aqua: improved native windows

Reply-To: <sebastien.plissonpop.free.fr>
Errors-To: <sebastien.plissonpop.free.fr>
X-Priority: 3 (Normal)

User-Agent: NOCC <http://nocc.sourcefo
rge.net/>

MIME-Version: 1.0

Content-Type: text/plain;

	charset="UTF-8"

Content-Transfer-Encoding: 8bit

Message-Id: <20070308095304.6411B5F0B3master.sivit.org>



Hi,



Very good work Ismael, I ll try it asap.



I was wondering if i should replace the Character Formatting
window

with the Font Dialog provided by MacOSX.



May be it is possible with your code or following your
example.



To be continued, Aqua is growing in soffice for our
happiness !



Sebastien



PS : maybe we could meet for lunch, one day at INSA.





Pavel Janík <PavelJanik.cz> a écrit :



> Hi,

> 

> > As i explained on my blog, i have been working on
native windows: i  

> > added new types of aqua windows like utility
windows or sheets....  

> > I have made window usage more aqua.

> >

> > The patch is at:

> > http://lebasket.free.fr/OOo/07_03_07/patchWindows0
7_03_07.diff

> >

> > This patch concerns the aqua part of vcl but also
the platform  

> > independent part.

> >

> > This patch is still experimental.

> 

> I have read it and tried it.

> 

> In general: I like how it changes window displaying.
Having e.g.  

> Styles and Formatting as utility window is the right
way to go and  

> modal dialogs displayed as sheets is also the right
way. I like it 

> 

> I have minor nits though:

> 

> - first the compilation related ones:

> 

> ../../../aqua/inc/salframe.h: In constructor  

> 'AquaSalFrame::AquaSalFrame(SalFrame*, ULONG,
AquaSalInstance*)':

> ../../../aqua/inc/salframe.h:89: warning:  

> 'AquaSalFrame::mnBackgroundBrush' will be initialized
after

> ../../../aqua/inc/salframe.h:86: warning:  
'AquaSalInstance*  

> AquaSalFrame::mpSalInstance'

>
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqu
a/source/ 

> window/salframe.cxx:120: warning:   when initialized
here

> 

> Please keep initializations in constructor ordered,
otherwise  

> compiler will warn about it:

> 

>      mpSalInstance(pSalInstance),

>      mbDialog(FALSE),

>      mnBackgroundBrush(0),

> 

> I wondered what the number 14 is, so:

> 

> -    fprintf(stderr, "%dn", style);

> +    fprintf(stderr, "Style: %dn", (int)
style);

> 

> - I think we can add some new flags to the generic VCL
part but it  

> has to be very clean - Mac OS X parts ifdefed for
MACOSX/QUARTZ, the  

> behaviour for other platforms unchanged etc. (this is
about last two  

> hunks in your patch).

> -- 

> Pavel Janík

> 

> 

>
------------------------------------------------------------
---------

> To unsubscribe, e-mail: mac-unsubscribeporting.openoffice.org

> For additional commands, e-mail: mac-helpporting.openoffice.org



___________________________________

Découvrez Mail-Reader.net, vos E-mail
 POP3 et IMAP dans le monde entier






------------------------------------------------------------
---------
To unsubscribe, e-mail: mac-unsubscribeporting.openoffice.org
For additional commands, e-mail: mac-helpporting.openoffice.org