Author: roy
Date: 2007-03-03 13:34:28 -0500 (Sat, 03 Mar 2007)
New Revision: 2549
Modified:
openpbx/branches/openpbx-1.2/channels/chan_sip.c
Log:
small comment on loco code
Modified: openpbx/branches/openpbx-1.2/channels/chan_sip.c
============================================================
=======
---
openpbx/branches/openpbx-1.2/channels/chan_sip.c 2007-03-03
00:55:48 UTC (rev 2548)
+++
openpbx/branches/openpbx-1.2/channels/chan_sip.c 2007-03-03
18:34:28 UTC (rev 2549)
 -2440,7
+2440,8
/*! brief find_peer: Locate peer by name or ip address
* This is used on incoming SIP message to find matching
peer on ip
- or outgoing message to find matching peer on name */
+ * or outgoing message to find matching peer on name
+ */
static struct sip_peer *find_peer(const char *peer, struct
sockaddr_in *sin, int realtime)
{
struct sip_peer *p = NULL;
-9419,7
+9420,12
else
/* Look for peer based on the IP address we
received data from */
/* If peer is registered from this IP address
or have this as a default
- IP address, this call is from the peer
+ * IP address, this call is from the peer
+ *
+ * FIXME This is completely loco! This code tries to
lookup a peer from
+ * it's IP address, which may be shared by a hundred
users. This
+ * should be replaced by looking at the SIP message to
see what the
+ * client authenticates like.
*/
peer = find_peer(NULL, &p->recv, 1);
_______________________________________________
Openpbx-svn mailing list
Openpbx-svnopenpbx.org
http://lists.openpbx.org/mailman/listinfo/openpbx-svn
|