removing trailing spaces and tabs

Hello,

I remarked that "some" files have spaces or tabs
just before the end
of line. You generally do not see them in your editor but it
does not
hurt to remove them either.

This will generate a rather large patch (11424 lines for
opensc and
712 lines for openct) so I do not want to send it here
before I
commit.

I started doing the changes by hand but then used my brain
and wrote a
script. It is:
find . -name '*.[ch]' | xargs perl -pi -e 's/\t+$//; s/
+$//'

Any objection to such a bug commit? Maybe a more trustworthy
person
want to do it?

Bye

--
  Dr Ludovic Rousseau
_______________________________________________
opensc-devel mailing list
opensc-devellists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc
-devel

Hi Ludovic,

fine with me. maybe even indent the whole file to fix other
stuff as
well? I prefer the linux kernel version
"Lindent" or:
	indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs

however you can't run that on all files - some code is very
nested and
becomes unreadable with that indentation.

Also I would prefer to first release the new openct and
opensc releases
and give enough time to add fast bugfix only releases, if
some problem
is found. So maybe in two weeks is a better time to apply
those changes
than right now? (sure, it is only whitespace changes, but
while we might
need some last minute changes it is good if the diff from
one release
to the next is small and readable.)

Regards, Andreas
_______________________________________________
opensc-devel mailing list
opensc-devellists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc
-devel

Ludovic Rousseau wrote:
> Hello,
> 
> I remarked that "some" files have spaces or
tabs just before the end
> of line. You generally do not see them in your editor
but it does not
> hurt to remove them either.
> 
> This will generate a rather large patch (11424 lines
for opensc and
> 712 lines for openct) so I do not want to send it here
before I
> commit.
> 
> I started doing the changes by hand but then used my
brain and wrote a
> script. It is:
> find . -name '*.[ch]' | xargs perl -pi -e
's/\t+$//; s/ +$//'
> 
> Any objection to such a bug commit?

if it's important for you (why ?) commit it. I don't think
it's worth
the effort.

> Maybe a more trustworthy person want to do it?

I hope everyone always reviews every commit anyway 

Cheers,
Nils
_______________________________________________
opensc-devel mailing list
opensc-devellists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc
-devel