OpenSSL: openssl/ssl/ s2_clnt.c

  OpenSSL CVS Repository
  http://cvs.openssl.org/
 
____________________________________________________________
________________

  Server: cvs.openssl.org                  Name:   Ben
Laurie
  Root:   /v/openssl/cvs                   Email:  benopenssl.org
  Module: openssl                          Date:  
05-Apr-2007 18:28:48
  Branch: HEAD                             Handle:
2007040517284800

  Modified files:
    openssl/ssl             s2_clnt.c

  Log:
    Don't use a negative number as a length. Coverity ID
57.

  Summary:
    Revision    Changes     Path
    1.56        +4  -2      openssl/ssl/s2_clnt.c
 
____________________________________________________________
________________

  patch -p0 <<' .'
  Index: openssl/ssl/s2_clnt.c
 
============================================================
================
  $ cvs diff -u -r1.55 -r1.56 s2_clnt.c
  --- openssl/ssl/s2_clnt.c	28 Sep 2006 13:18:43 -0000	1.55
  +++ openssl/ssl/s2_clnt.c	5 Apr 2007 16:28:48 -0000	1.56
   -863,8 +863,10 
   		EVP_SignUpdate(&ctx,s->s2->key_material,
   			       s->s2->key_material_length);
   		EVP_SignUpdate(&ctx,cert_ch,(unsigned
int)cert_ch_len);
 
-		n=i2d_X509(s->session->sess_cert->peer_key->x
509,&p);
  -		EVP_SignUpdate(&ctx,buf,(unsigned int)n);
 
+		i=i2d_X509(s->session->sess_cert->peer_key->x
509,&p);
  +		/* Don't update the signature if it fails - FIXME:
probably should handle this better */
  +		if(i > 0)
  +			EVP_SignUpdate(&ctx,buf,(unsigned int)i);
   
   		p=buf;
   		d=p+6;
   .
____________________________________________________________
__________
OpenSSL Project                                 http://www.openssl.org
CVS Repository Commit List                    
openssl-cvsopenssl.org
Automated List Manager                          
majordomoopenssl.org