patch regarding bug #0000558

Hello Paul,  
  
I have added a little patch to this issue. This fixes the
behavior of not  
being strict in case ike or esp proposals are set.  
  
<----------------------snip---------------------> 
 
diff -Naur openswan-2.4.5rc3/lib/libopenswan/alg_info.c  
openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c  
--- openswan-2.4.5rc3/lib/libopenswan/alg_info.c        Mon
Mar 21 04:58:10  
2005  
+++ openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c  Wed
Jan 11 08:00:28  
2006  
 -568,6
+568,10   
        /* use default if nul esp string */  
        if (!*alg_str) {  
            (*alg_info_add)(alg_info, 0, 0, 0, 0, 0, 0);  
+       } else {  
+           // MH: as this is necessary to have mandatory
proposals  
+           // add the flag as soon as an explicit proposal
is set  
+           alg_info->alg_info_flags |=
ALG_INFO_F_STRICT;  
        }  
 
<----------------------snap------------------------> 
  
It keeps up the old behavior of the ! setting and also sets
the strict flag,  
as soon as the proposals are defined without the !. I hope
this helps to  
solve that problem. Atleast it works for me  .  
  
Matthias  
  
  
_______________________________________________
Dev mailing list
Devopenswan.org
http:/
/lists.openswan.org/mailman/listinfo/dev

Thanks, merged into git - #kb tree as
6cbe6ad4d809cab121d71078b082f09fa1b38e5a

On Tue, 17 Jan 2006, Matthias Haas wrote:

> Hello Paul,
>
> I have added a little patch to this issue. This fixes
the behavior of not
> being strict in case ike or esp proposals are set.
>
> <----------------------snip--------------------->
>
> diff -Naur openswan-2.4.5rc3/lib/libopenswan/alg_info.c
> openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c
> --- openswan-2.4.5rc3/lib/libopenswan/alg_info.c       
Mon Mar 21 04:58:10
> 2005
> +++ openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c 
Wed Jan 11 08:00:28
> 2006
>  -568,6 +568,10 
>        /* use default if nul esp string */
>        if (!*alg_str) {
>            (*alg_info_add)(alg_info, 0, 0, 0, 0, 0, 0);
> +       } else {
> +           // MH: as this is necessary to have
mandatory proposals
> +           // add the flag as soon as an explicit
proposal is set
> +           alg_info->alg_info_flags |=
ALG_INFO_F_STRICT;
>        }
>
>
<----------------------snap------------------------>
>
> It keeps up the old behavior of the ! setting and also
sets the strict flag,
> as soon as the proposals are defined without the !. I
hope this helps to
> solve that problem. Atleast it works for me  .
>
> Matthias
>
_______________________________________________
Dev mailing list
Devopenswan.org
http:/
/lists.openswan.org/mailman/listinfo/dev

Is there a public git access? 
 
Matthias 
 
On Wed, 18 Jan 2006 13:36:07 +0100 (CET), Ken Bantoft wrote 
> Thanks, merged into git - #kb tree as 
6cbe6ad4d809cab121d71078b082f09fa1b38e5a 
>  
> On Tue, 17 Jan 2006, Matthias Haas wrote: 
>  
> > Hello Paul, 
> > 
> > I have added a little patch to this issue. This
fixes the behavior of not 
> > being strict in case ike or esp proposals are set.

> > 
> >
<----------------------snip---------------------> 
> > 
> > diff -Naur
openswan-2.4.5rc3/lib/libopenswan/alg_info.c 
> > openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c

> > --- openswan-2.4.5rc3/lib/libopenswan/alg_info.c  
     Mon Mar 21 
04:58:10 
> > 2005 
> > +++
openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c  Wed Jan
11 
08:00:28 
> > 2006 
> >  -568,6 +568,10  
> >        /* use default if nul esp string */ 
> >        if (!*alg_str) { 
> >            (*alg_info_add)(alg_info, 0, 0, 0, 0,
0, 0); 
> > +       } else { 
> > +           // MH: as this is necessary to have
mandatory proposals 
> > +           // add the flag as soon as an explicit
proposal is set 
> > +           alg_info->alg_info_flags |=
ALG_INFO_F_STRICT; 
> >        } 
> > 
> >
<----------------------snap------------------------> 
> > 
> > It keeps up the old behavior of the ! setting and
also sets the strict 
flag, 
> > as soon as the proposals are defined without the
!. I hope this helps to 
> > solve that problem. Atleast it works for me  . 
> > 
> > Matthias 
> > 
 
 
 
_______________________________________________
Dev mailing list
Devopenswan.org
http:/
/lists.openswan.org/mailman/listinfo/dev

Yup,  we push stuff to #public after testing.  I might
publish my #kb tree 
there shortly, just need to work it into my workflow.

cg-clone http://git.openswan.org/public/scm/openswan.git#public

That will get you #public, which is basically 2.5.0 at this
point


On Wed, 18 Jan 2006, Matthias Haas wrote:

> Is there a public git access?
>
> Matthias
>
> On Wed, 18 Jan 2006 13:36:07 +0100 (CET), Ken Bantoft
wrote
>> Thanks, merged into git - #kb tree as
> 6cbe6ad4d809cab121d71078b082f09fa1b38e5a
_______________________________________________
Dev mailing list
Devopenswan.org
http:/
/lists.openswan.org/mailman/listinfo/dev

On Tue, 17 Jan 2006, Matthias Haas wrote:

> I have added a little patch to this issue. This fixes
the behavior of not
> being strict in case ike or esp proposals are set.

Thanks Matthias. The fix has also been added to the 2.4.x
tree, and will be
in openswan-2.4.5 shortly.

Paul

> <----------------------snip--------------------->
>
> diff -Naur openswan-2.4.5rc3/lib/libopenswan/alg_info.c
> openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c
> --- openswan-2.4.5rc3/lib/libopenswan/alg_info.c       
Mon Mar 21 04:58:10
> 2005
> +++ openswan-2.4.5rc3-devel/lib/libopenswan/alg_info.c 
Wed Jan 11 08:00:28
> 2006
>  -568,6 +568,10 
>         /* use default if nul esp string */
>         if (!*alg_str) {
>             (*alg_info_add)(alg_info, 0, 0, 0, 0, 0,
0);
> +       } else {
> +           // MH: as this is necessary to have
mandatory proposals
> +           // add the flag as soon as an explicit
proposal is set
> +           alg_info->alg_info_flags |=
ALG_INFO_F_STRICT;
>         }
>
>
<----------------------snap------------------------>
>
> It keeps up the old behavior of the ! setting and also
sets the strict flag,
> as soon as the proposals are defined without the !. I
hope this helps to
> solve that problem. Atleast it works for me  .
>
> Matthias
_______________________________________________
Dev mailing list
Devopenswan.org
http:/
/lists.openswan.org/mailman/listinfo/dev