Orca Traceback when setting up CVS head]

I see Will has submitted a bug (388039) and provided a
slightly 
different patch.
I'll leave it to him to check this in.

-------- Original Message --------
Subject: 	Re: Orca Traceback when setting up CVS head
Date: 	Wed, 20 Dec 2006 13:06:11 -0800
From: 	Rich Burridge <rich.burridgesun.com>
To: 	Nolan Darilek <nolanthewordnerd.info>
CC: 	orca-listgnome.org
References: 	<DF51B814-6130-47C5-A289-BD928D43534Fthewordnerd.info>



Hi Nolan,

> Hello. Getting the following when running 'orca -t'
with the latest  
> CVS head. Wondering if anyone else is seeing this, or
if something on  
> my end is out of sync?:
>
> ...
> Enable Braille Monitor?  Enter y or n: n
>
> Traceback (most recent call last):
>    File
"/usr/local/stow/orca/lib/python2.4/site-packages/orca/

> orca.py", line 963, in _showPreferencesConsole
>      module.showPreferencesUI()
>    File
"/usr/local/stow/orca/lib/python2.4/site-packages/orca/

> orca_console_prefs.py", line 361, in
showPreferencesUI
>      logoutNeeded =
orca_prefs.writePreferences(prefsDict)
> TypeError: writePreferences() takes exactly 2 arguments
(1 given)
>
> Cannot start Orca because it cannot connect
> to the Desktop.  Please make sure the DISPLAY
> environment variable has been set.
>   

This looks like a recent regression with the inclusion of
the key bindings
code. Here's an (untested) patch that hopefully should fix
it:

Index: orca_console_prefs.py
============================================================
=======
RCS file: /cvs/gnome/orca/src/orca/orca_console_prefs.py,v
retrieving revision 1.14
diff -u -r1.14 orca_console_prefs.py
--- orca_console_prefs.py       17 Nov 2006 20:33:57 -0000  
   1.14
+++ orca_console_prefs.py       20 Dec 2006 21:05:19 -0000
 -358,7
+358,7 
    state = answer[0:1] == 'Y' or answer[0:1] == 'y'
    prefsDict["enableBrailleMonitor"] = state

-    logoutNeeded = orca_prefs.writePreferences(prefsDict)
+    logoutNeeded = orca_prefs.writePreferences(prefsDict,
None)
    if logoutNeeded:
        sayAndPrint(_("Accessibility support for GNOME
has just been 
enabled. "),
                    logoutNeeded,
Index: orca_prefs.py
============================================================
=======
RCS file: /cvs/gnome/orca/src/orca/orca_prefs.py,v
retrieving revision 1.17
diff -u -r1.17 orca_prefs.py
--- orca_prefs.py       13 Dec 2006 01:21:31 -0000      1.17
+++ orca_prefs.py       20 Dec 2006 21:05:20 -0000
 -437,7
+437,8 
                value = prefsDict[key]
            prefs.writelines("orca.settings.%s =
%sn" % (key, value))

-    _writeKeyBindingsMap(prefs, treeModel)
+    if treeModel:
+       _writeKeyBindingsMap(prefs, treeModel)

    _writePreferencesPostamble(prefs)
    prefs.close()



_______________________________________________
Orca-list mailing list
Orca-listgnome.org
http
://mail.gnome.org/mailman/listinfo/orca-list