List Info

Thread: resolving class variables




resolving class variables
user name
2007-03-06 15:39:51

I have a question regarding a commented line in CodeDataResolver:

//  String fileName = classDatas[i].isUserCode() ? classDatas[i].getUserData().getFileName() : "";
result = ModelSupport.merge(result, toArray( projectModel.getClassVariablesData(fileData.getName(), className, elementName)));

I think, now it looks for class variables only in current file, and not in file where specific class where declared...
Please tell me, that I'm wrong

Thanks!

BTW, there is a problem in FilterableCompositePhpModel (filter is null):

java.lang.NullPointerException
        at org.eclipse.php.internal.core.phpModel.parser.FilterableCompositePhpModel.getFilteredClasses (FilterableCompositePhpModel.java:98)
        at org.eclipse.php.internal.core.util.CodeDataResolver.getMatchingClasses(CodeDataResolver.java:259)
  ;      at org.eclipse.php.internal.core.util.CodeDataResolver.resolve (CodeDataResolver.java:197)
        at org.eclipse.php.internal.core.util.CodeDataResolver.resolve(CodeDataResolver.java:77)
    ;    at org.eclipse.php.internal.ui.editor.hover.PHPSourceTextHover.getHoverInfo(PHPSourceTextHover.java :97)
   ;     at org.eclipse.php.internal.ui.editor.hover.BestMatchHover.getHoverInfo(BestMatchHover.java:99)
 ;       at org.eclipse.php.internal.ui.editor.hover.PHPTextHoverProxy.getHoverInfo(PHPTextHoverProxy.java:63)

--
Michael
Re: resolving class variables
country flaguser name
Israel
2007-03-07 02:43:44
Michael,

It seems you're wrong - there were another problems there
. In
general we should provide always the CURRENT file name when
resolving elements. And the model attemts to correctly
determine the elements according to the data (with or
without model filter).

Thanks for pointing the issue(s).

On Tue, 6 Mar 2007 23:39:51 +0200 "Michael
Spector" <spektomgmail.com> wrote:

MS> I have a question regarding a commented line in
CodeDataResolver:
MS> 
MS> //  String fileName = classDatas[i].isUserCode() ?
MS> classDatas[i].getUserData().getFileName() :
"";
MS> result = ModelSupport.merge(result, toArray(
MS>
projectModel.getClassVariablesData(fileData.getName(),
className,
MS> elementName)));
MS> 
MS> I think, now it looks for class variables only in
current file, and not in
MS> file where specific class where declared...
MS> Please tell me, that I'm wrong 
MS> 
MS> Thanks!
MS> 
MS> BTW, there is a problem in
FilterableCompositePhpModel (filter is null):
MS> 
MS> java.lang.NullPointerException
MS>         at
MS>
org.eclipse.php.internal.core.phpModel.parser.FilterableComp
ositePhpModel.getFilteredClasses
MS> (FilterableCompositePhpModel.java:98)
MS>         at
MS>
org.eclipse.php.internal.core.util.CodeDataResolver.getMatch
ingClasses(
MS> CodeDataResolver.java:259)
MS>         at
org.eclipse.php.internal.core.util.CodeDataResolver.resolve(

MS> CodeDataResolver.java:197)
MS>         at
org.eclipse.php.internal.core.util.CodeDataResolver.resolve(

MS> CodeDataResolver.java:77)
MS>         at
MS>
org.eclipse.php.internal.ui.editor.hover.PHPSourceTextHover.
getHoverInfo(
MS> PHPSourceTextHover.java:97)
MS>         at
MS>
org.eclipse.php.internal.ui.editor.hover.BestMatchHover.getH
overInfo(
MS> BestMatchHover.java:99)
MS>         at
MS>
org.eclipse.php.internal.ui.editor.hover.PHPTextHoverProxy.g
etHoverInfo(
MS> PHPTextHoverProxy.java:63)
MS> 
MS> -- 
MS> Michael

Seva Lapsha
[slapshadev.eclipse.org]
Zend Eclipse Developer

_______________________________________________
pdt-dev mailing list
pdt-deveclipse.org
http
s://dev.eclipse.org/mailman/listinfo/pdt-dev

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )