Re: 'Fix' Text::Balance version number

Jerry D. Hedden wrote:
> The problem with this is that after building and
installing 
> 5.8.x30165, and then running 'r' from the CPAN prompt,
you
> get:
> 
> Package namespace         installed    latest  in CPAN
file
> ...
> Text::Balanced                    2  2.000000 
> DCONWAY/Text-Balanced-v2.0.0.tar.gz
> ...
> 
> This is no good.  It show there that an update is
needed
> when there shouldn't be.  My patch (which quotes the
> 2.000000) fixes this so that the above does not show
up.

John Peacock wrote:
> I get that part, but I'm wondering why it isn't *CPAN*
> that needs fixing, since those two $VERSION's are
> equivalent.

I'll submit a bug report against CPAN.

> It can also be argued that perlmaint *does* need
updating,
> since it doesn't have the XS version installed, but
that's
> a different horse...

Okay.  So there's no disagreement that my patch should be
applied to maint, correct?


 
____________________________________________________________
________________________
Need a quick answer? Get one in minutes from people who
know.
Ask your question on www.Answers.yahoo.com

>>>>> On Thu, 8 Feb 2007 09:54:49 -0800
(PST), "Jerry D. Hedden" <jdheddenyahoo.com> said:

  > Jerry D. Hedden wrote:
 >> The problem with this is that after building and
installing 
 >> 5.8.x30165, and then running 'r' from the CPAN
prompt, you
 >> get:
 >> 
 >> Package namespace         installed    latest  in
CPAN file
 >> ...
 >> Text::Balanced                    2  2.000000 
 >> DCONWAY/Text-Balanced-v2.0.0.tar.gz
 >> ...
 >> 
 >> This is no good.  It show there that an update is
needed
 >> when there shouldn't be.  My patch (which quotes
the
 >> 2.000000) fixes this so that the above does not
show up.

  > John Peacock wrote:
 >> I get that part, but I'm wondering why it isn't
*CPAN*
 >> that needs fixing, since those two $VERSION's are
 >> equivalent.

  > I'll submit a bug report against CPAN.

I looked into the Text-Balanced-2 package on CPAN and
compared it with
maintperl30176:

% md5sum lib/Text/Balanced.pm
/home/src/perl/repoperls/perl-m-5.8.030176/lib/Text/Balanced.pm

b174404a8b7391f7643e2d04673c7def  lib/Text/Balanced.pm
8abb7ef7e80687bfbe37215ea23ad975 
/home/src/perl/repoperls/perl-m-5.8.030176/lib/Text/Balanced.pm


So they are not the same.

 >> It can also be argued that perlmaint *does* need
updating,
 >> since it doesn't have the XS version installed,
but that's
 >> a different horse...

  > Okay.  So there's no disagreement that my patch
should be
  > applied to maint, correct?

No, it is wrong. You should never change a module without
changing its
version. Your patch says:

-$VERSION = 2.000000;
+$VERSION = '2.000000';

But seriously, it should be

-$VERSION = 2.000000;
+$VERSION = '2.000001';

or whatever. Let it reflect that it is a *different*
version.

I do agree that the old rule to quote version strings should
be kept
up, at least for a while until version.pm has become as
widespread as
it deserves.

-- 
andreas

On Thu, Feb 08, 2007 at 09:38:15PM +0100, Andreas J. Koenig
wrote:
> >>>>> On Thu, 8 Feb 2007 09:54:49 -0800
(PST), "Jerry D. Hedden" <jdheddenyahoo.com> said:

> I looked into the Text-Balanced-2 package on CPAN and
compared it with
> maintperl30176:
> 
> % md5sum lib/Text/Balanced.pm
/home/src/perl/repoperls/perl-m-5.8.030176/lib/Text/Balanced.pm

> b174404a8b7391f7643e2d04673c7def  lib/Text/Balanced.pm
> 8abb7ef7e80687bfbe37215ea23ad975 
/home/src/perl/repoperls/perl-m-5.8.030176/lib/Text/Balanced.pm
> 
> 
> So they are not the same.

This is true

> No, it is wrong. You should never change a module
without changing its
> version. Your patch says:
> 
> -$VERSION = 2.000000;
> +$VERSION = '2.000000';
> 
> But seriously, it should be
> 
> -$VERSION = 2.000000;
> +$VERSION = '2.000001';
> 
> or whatever. Let it reflect that it is a *different*
version.

It is functionally identical but a different
implementation.
I don't want it to be visible as an "upgrade"

> I do agree that the old rule to quote version strings
should be kept
> up, at least for a while until version.pm has become as
widespread as
> it deserves.

I am loathe to pull in an entirely new dependency into
maint, for 1 line of
one module, especially as that line isn't actually an
executed line.

In particular, pulling it in at this time effectively
fossilises the API
*and* the implementation, when it seems that neither are
quite stable.
(The whole thing about action at a distance with
UNIVERSAL::VERSION)

I don't have a good answer. One option is to revert to 1.97,
which IIRC is
the last version that didn't use a version object.

Nicholas Clark

Andreas J. Koenig wrote:
> You should never change a module without changing its
version.

Nicholas Clark wrote:
> I don't have a good answer. One option is to revert to
> 1.97, which IIRC is the last version that didn't use a
> version object.

I think that the comment you added to the file is
sufficient
to document why it was changed.  In keeping with how
changes
are made to blead, maybe the following would be okay:

$VERSION = '2.000000_01';
$VERSION = eval $VERSION;