Steve Hay wrote:
> Yitzchak Scott-Thoennes wrote:
>> On Mon, Feb 26, 2007 at 01:28:51PM +0000, Steve Hay
wrote:
>>> Thanks, applied as #30409.
>>
>> Um, given Craig's comment in
>>
http://nntp.perl.org/group/perl.perl5.porters/121449, I
think I'd
>> rather this were reverted.
>>
>> Since TEST and harness automatically handle
skipping known but not
>> built extensions' tests,
$Config-checking code shouldn't
>> clutter up the tests.
>
> I haven't investigated this at all yet, but I recall no
so long ago
> Nicholas going through lots of test files and having
tests skipped if
> modules weren't built.
>
> A quick look in Changes reveals quite a few such
changes, e.g.:
>
> Skip Devel::PPPort tests if Devel::PPPort was not
built:
> http://public.activestate.com/cgi-bin/perlbrowse/p/22953
>
> Skip re tests if re was not built:
> http://public.activestate.com/cgi-bin/perlbrowse/p/22952
>
> Skip B tests if B was not built:
> http://public.activestate.com/cgi-bin/perlbrowse/p/22951
>
> and others...
>
> I'm sure all those changes weren't unnecessary, but
I've forgotten what
> the motivation for them was. Whatever it was might
also apply to
> Win32CORE and Win32API.
FWIW, Nicholas added the automatic skipping to TEST and
harness in
http://public.activestate.com/cgi-bin/perlbrowse/p/23448
so the behavior wasn't there at the time of the earlier
patches
you mention.
Nicholas? Was that intended to be in addition to or instead
of
per-test skipping?
|