Re: cond_wait hang ups under MSWin32

Jerry D. Hedden wrote:
> Yves wrote:
>> That you see errors on the command line invalidates
my original
>> argument, so I agree, it should be TODO always.
> 
> So we have a consensus.  The attached patch makes the
test TODO under 
> MSWin32.

Is the patch correct? I'm a bit rusty on the mechanics of
TODO tests at 
the moment, but just running stress.t with your patch in
place I get 
output like the following. The failing case just says
"FAILED tests 
24-50" and makes no mention that this was expected, and
the successful 
case just says "All tests successful" and doesn't
mention that this is 
unexpected.

C:p5pbleadperlt>..perl harness -v
..extthreadssharedtstress.t
../ext/threads/shared/t/stress....1..50
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9
ok 10
ok 11
ok 12
ok 13
ok 14
ok 15
ok 16
ok 17
ok 18
ok 19
ok 20
ok 21
ok 22
ok 23
not ok 24
# Failed test at line 99
#   Reason: # TODO timed out - cond_broadcast not received
not ok 25
# Failed test at line 99
#   Reason: # TODO timed out
not ok 26
# Failed test at line 99
#   Reason: # TODO timed out
not ok 27
# Failed test at line 99
#   Reason: # TODO timed out
not ok 28
# Failed test at line 99
#   Reason: # TODO timed out
not ok 29
# Failed test at line 99
#   Reason: # TODO timed out
not ok 30
# Failed test at line 99
#   Reason: # TODO timed out
not ok 31
# Failed test at line 99
#   Reason: # TODO timed out
not ok 32
# Failed test at line 99
#   Reason: # TODO timed out
not ok 33
# Failed test at line 99
#   Reason: # TODO timed out
not ok 34
# Failed test at line 99
#   Reason: # TODO timed out
not ok 35
# Failed test at line 99
#   Reason: # TODO timed out
not ok 36
# Failed test at line 99
#   Reason: # TODO timed out
not ok 37
# Failed test at line 99
#   Reason: # TODO timed out
not ok 38
# Failed test at line 99
#   Reason: # TODO timed out
not ok 39
# Failed test at line 99
#   Reason: # TODO timed out
not ok 40
# Failed test at line 99
#   Reason: # TODO timed out
not ok 41
# Failed test at line 99
#   Reason: # TODO timed out
not ok 42
# Failed test at line 99
#   Reason: # TODO timed out
not ok 43
# Failed test at line 99
#   Reason: # TODO timed out
not ok 44
# Failed test at line 99
#   Reason: # TODO timed out
not ok 45
# Failed test at line 99
#   Reason: # TODO timed out
not ok 46
# Failed test at line 99
#   Reason: # TODO timed out
not ok 47
# Failed test at line 99
#   Reason: # TODO timed out
not ok 48
# Failed test at line 99
#   Reason: # TODO timed out
not ok 49
# Failed test at line 99
#   Reason: # TODO timed out
not ok 50
# Failed test at line 99
#   Reason: # TODO timed out
FAILED tests 24-50
         Failed 27/50 tests, 46.00% okay
Failed Test                      Stat Wstat Total Fail  List
of Failed
------------------------------------------------------------
-------------------
../ext/threads/shared/t/stress.t               50   27 
24-50
Failed 1/1 test scripts. 27/50 subtests failed.
Files=1, Tests=50, 35 wallclock secs ( 0.00 cusr +  0.00
csys =  0.00 CPU)
Failed 1/1 test programs. 27/50 subtests failed.

C:p5pbleadperlt>..perl harness -v
..extthreadssharedtstress.t
../ext/threads/shared/t/stress....1..50
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9
ok 10
ok 11
ok 12
ok 13
ok 14
ok 15
ok 16
ok 17
ok 18
ok 19
ok 20
ok 21
ok 22
ok 23
ok 24
ok 25
ok 26
ok 27
ok 28
ok 29
ok 30
ok 31
ok 32
ok 33
ok 34
ok 35
ok 36
ok 37
ok 38
ok 39
ok 40
ok 41
ok 42
ok 43
ok 44
ok 45
ok 46
ok 47
ok 48
ok 49
ok 50
ok     5734 ms
All tests successful.
Files=1, Tests=50,  6 wallclock secs ( 0.00 cusr +  0.00
csys =  0.00 CPU)

-- 

On 18/04/07, Steve Hay <steve.hayuk.radan.com> wrote:
> not ok 24
> # Failed test at line 99
> #   Reason: # TODO timed out - cond_broadcast not
received

"# TODO" should appear on the same line than
"not ok".

> Is the patch correct?

Ugh.  My fault.  I forgot that the test suite uses its own
'ok'
functions.  I modified accordingly (and actually tested it
. 
New
patch attached.  Please try this one.  Thanks.