Re: 2.22 released!

On 29/05/07, Dan Kogai <dankogaidan.co.jp> wrote:
> http://www.dan.co.jp/~dankogai/cpan/Encode-2.22.tar.gz

> and CPAN near you.

Dan, there might be a memory leak introduced by your patch,
which I
plugged likewise:

Change 31307 by rgsstcosmo on 2007/05/29 15:48:27

	Plug a memory leak in Encode

Affected files ...

... //depot/perl/ext/Encode/Encode.xs#129 edit

Differences ...

==== //depot/perl/ext/Encode/Encode.xs#129 (text) ====

 -87,6
+87,7 
     LEAVE;
     retval = newSVpv("",0);
     sv_catsv(retval, temp);
+    SvREFCNT_dec(temp);
     return retval;
 }

rgs

On May 30, 2007, at 00:58 , Rafael Garcia-Suarez wrote:
> Dan, there might be a memory leak introduced by your
patch, which I
> plugged likewise:
>
> Change 31307 by rgsstcosmo on 2007/05/29
15:48:27
>
> 	Plug a memory leak in Encode
>
> Affected files ...
>
> ... //depot/perl/ext/Encode/Encode.xs#129 edit
>
> Differences ...


Ouch.  Thanks.  Memory leak is good, I mean bad, enough to
VERSION+ 
+.  Did you check my Makefile.PL patch?  I'll release the
version as  
soon as the Makefile.PL issue is confirmed.

Dan the Maintainer Thereof

>
> ==== //depot/perl/ext/Encode/Encode.xs#129 (text) ====
>
>  -87,6 +87,7 
>     LEAVE;
>     retval = newSVpv("",0);
>     sv_catsv(retval, temp);
> +    SvREFCNT_dec(temp);
>     return retval;
> }
>