Compress-Zlib 1.42 tests fail on both blead and maint

I know Compress-ZLib 1.42 is out-of-date, but at least on
maint it should continue to build and test as before.

I get the following failure with both blead and maint, with
and without using threads, both 32 and 64-bit (only tested
on
Linux so far).  The test failures don't happen with 5.8.8.

Andreas, could you do a BBC check against
Compress-Zlib-1.42?

Cheers,
-Jan


~/Compress-Zlib-1.42> make test
PERL_DL_NONLAZY=1 /home/jand/blead/bin/perl
"-MExtUtils::Command::MM" "-e"
"test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01version.....ok
t/02zlib........FAILED tests 35-37, 43-45, 51-53, 60, 62,
64
        Failed 12/239 tests, 94.98% okay
t/03examples....FAILED test 6
        Failed 1/16 tests, 93.75% okay
t/04encoding....ok
t/05gzsetp......ok
t/06gzdopen.....ok
Failed Test    Stat Wstat Total Fail  List of Failed
------------------------------------------------------------
-------------------
t/02zlib.t                  239   12  35-37 43-45 51-53 60
62 64
t/03examples.t               16    1  6
Failed 2/6 test scripts. 13/305 subtests failed.
Files=6, Tests=305,  2 wallclock secs ( 0.55 cusr +  0.09
csys =  0.64 CPU)
Failed 2/6 test programs. 13/305 subtests failed.

From: Jan Dubois [mailto:jandactivestate.com]
 
> I know Compress-ZLib 1.42 is out-of-date, but at least
on
> maint it should continue to build and test as before.
> 
> I get the following failure with both blead and maint,
with
> and without using threads, both 32 and 64-bit (only
tested on
> Linux so far).  The test failures don't happen with
5.8.8.
> 
> Andreas, could you do a BBC check against
Compress-Zlib-1.42?
> 
> Cheers,
> -Jan
> 
> 
> ~/Compress-Zlib-1.42> make test
> PERL_DL_NONLAZY=1 /home/jand/blead/bin/perl
"-MExtUtils::Command::MM" "-e"
> "test_harness(0, 'blib/lib', 'blib/arch')"
t/*.t
> t/01version.....ok
> t/02zlib........FAILED tests 35-37, 43-45, 51-53, 60,
62, 64
>         Failed 12/239 tests, 94.98% okay
> t/03examples....FAILED test 6
>         Failed 1/16 tests, 93.75% okay
> t/04encoding....ok
> t/05gzsetp......ok
> t/06gzdopen.....ok

The failures are all related to gzreadline (which lives in
Zlib.xs)

Paul

On Wed, 30 May 2007, Paul Marquess wrote:
> From: Jan Dubois [mailto:jandactivestate.com]
> 
> > I know Compress-ZLib 1.42 is out-of-date, but at
least on
> > maint it should continue to build and test as
before.
> >
> > I get the following failure with both blead and
maint, with
> > and without using threads, both 32 and 64-bit
(only tested on
> > Linux so far).  The test failures don't happen
with 5.8.8.
> >
> > Andreas, could you do a BBC check against
Compress-Zlib-1.42?
> >
> > Cheers,
> > -Jan
> >
> >
> > ~/Compress-Zlib-1.42> make test
> > PERL_DL_NONLAZY=1 /home/jand/blead/bin/perl
"-MExtUtils::Command::MM" "-e"
> > "test_harness(0, 'blib/lib',
'blib/arch')" t/*.t
> > t/01version.....ok
> > t/02zlib........FAILED tests 35-37, 43-45, 51-53,
60, 62, 64
> >         Failed 12/239 tests, 94.98% okay
> > t/03examples....FAILED test 6
> >         Failed 1/16 tests, 93.75% okay
> > t/04encoding....ok
> > t/05gzsetp......ok
> > t/06gzdopen.....ok
> 
> The failures are all related to gzreadline (which lives
in Zlib.xs)

It is all due to change 26510:

  http://public.activestate.com/cgi-bin/perlbrowse/p/26510


Looks like this was already discussed 3 months ago:

  http://www.nntp.perl.org/group/perl.perl
5.porters/2007/02/msg121477.html

Still makes me feel uneasy to have this change in MAINT.

Cheers,
-Jan

On Wed, May 30, 2007 at 05:58:21PM -0700, Jan Dubois wrote:

> It is all due to change 26510:
> 
>   http://public.activestate.com/cgi-bin/perlbrowse/p/26510

> 
> Looks like this was already discussed 3 months ago:
> 
>   http://www.nntp.perl.org/group/perl.perl
5.porters/2007/02/msg121477.html
> 
> Still makes me feel uneasy to have this change in
MAINT.

It is a bug fix in core. It is subtly buggy code that is now
failing.
But you'd feel more comfortable leaving the bug in place?

Nicholas Clark

From: Nicholas Clark [mailto:nickflirble.org] On Behalf Of
Nicholas Clark
 
> On Wed, May 30, 2007 at 05:58:21PM -0700, Jan Dubois
wrote:
> 
> > It is all due to change 26510:
> >
> >   http://public.activestate.com/cgi-bin/perlbrowse/p/26510

> >
> > Looks like this was already discussed 3 months
ago:
> >
> >
> http://www.nntp.perl.org/group/perl.perl
5.porters/2007/02/msg121477.html
> >
> > Still makes me feel uneasy to have this change in
MAINT.
> 
> It is a bug fix in core. It is subtly buggy code that
is now failing.
> But you'd feel more comfortable leaving the bug in
place?

Ah, right, I remember this one now.

I'm very reluctant to post a fix to CPAN for Compress::Zlib
1.42, given that
it has been superseded by version C::Z version 2. 

Does the fix break any of the CPAN-only modules?

Paul