... one day ...
-------- Original-Nachricht --------
Betreff: Re: [patch] First batch of whitespace patches
(second set)
Datum: Fri, 24 Aug 2007 21:29:38 +0200
Von: Max Maischein <corion corion.net>
An: Abhijit Menon-Sen <amstoroid.org>
Referenzen: <46C9E26B.3040203corion.net>
<20070821084415.GB19656toroid.org>
Hello Abhijit Menon-Sen!
> Could you regenerate your patches so that I can apply
with "patch -p1"
> or similar, please? Right now, the "---"
lines have just the relative
> path, while the "+++" lines have
"../fresh perl/perl-5.9.5/$path" and
> patch can't cope with that.
Did that. Also, the patches are against blead now.
First, these two need to be applied:
>> 1) perl-5.9.5-whitespace-Makefile.SH.diff
>> 2) perl-5.9.5-whitespace-ExtUtils.diff
>
> At what point does the build fail without this patch?
The session looks as follows (abbreviated):
prompt> ./Configure -Dusedevel -des && make
`sh cflags "optimize='-O2'" pp_sort.o`
pp_sort.c
CCCMD = cc -DPERL_CORE -c
-DPERL_PATCHNUM=31750
-fno-strict-aliasing -pipe -I/usr/local/include
-D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -std=c89 -O2 -Wall -ansi -W
-Wextra
-Wdeclaration-after-statement -Wendif-labels -Wc++-compat
`sh cflags "optimize='-O2'" opmini.o`
-DPERL_EXTERNAL_GLOB opmini.c
CCCMD = cc -DPERL_CORE -c
-DPERL_PATCHNUM=31750
-fno-strict-aliasing -pipe -I/usr/local/include
-D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -std=c89 -O2 -Wall -ansi -W
-Wextra
-Wdeclaration-after-statement -Wendif-labels -Wc++-compat
cc -L/usr/local/lib -o miniperl
`echo gv.o toke.o perly.o op.o pad.o
regcomp.o dump.o
util.o mg.o reentr.o mro.o hv.o av.o perl.o run.o pp_hot.o
sv.o pp.o
scope.o pp_ctl.o pp_sys.o doop.o doio.o regexec.o utf8.o
taint.o deb.o
universal.o xsutils.o globals.o perlio.o perlapi.o numeric.o
mathoms.o
locale.o pp_pack.o pp_sort.o | sed 's/ op.o / /'`
miniperlmain.o opmini.o -lnsl -ldl -lm -lcrypt
-lutil -lc
./miniperl -w -Ilib -MExporter -e '<?>' || make
minitest
./miniperl -Ilib configpm
written lib/Config.pod
updated lib/Config.pm
updated lib/Config_heavy.pl
./miniperl -Ilib lib/lib_pm.PL
Extracting lib.pm (with variable substitutions)
AutoSplitting perl library
./miniperl -Ilib -e 'use AutoSplit;
autosplit_lib_modules(ARGV)'
lib/*.pm
./miniperl -Ilib -e 'use AutoSplit;
autosplit_lib_modules(ARGV)'
lib/*/*.pm
make lib/re.pm
make[1]: Entering directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5'
cp ext/re/re.pm lib/re.pm
make[1]: Leaving directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5'
./miniperl minimod.pl > lib/ExtUtils/Miniperl.pm
cd lib/unicore && ../../miniperl -I../../lib
mktables -w
touch uni.data
`sh cflags "optimize='-O2'" perlmain.o`
perlmain.c
CCCMD = cc -DPERL_CORE -c
-DPERL_PATCHNUM=31750
-fno-strict-aliasing -pipe -I/usr/local/include
-D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -std=c89 -O2 -Wall -ansi -W
-Wextra
-Wdeclaration-after-statement -Wendif-labels -Wc++-compat
Making DynaLoader (static)
Processing hints file hints/linux.pl
Writing Makefile for DynaLoader
make[1]: Entering directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5/ext/DynaLoader'
/bin/sh: /mount/hdb1/home/corion/tmp/synced: Datei oder
Verzeichnis
nicht gefunden
make[1]: *** [../../lib/.exists] Fehler 127
make[1]: Leaving directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5/ext/DynaLoader'
make config failed, continuing anyway...
make[1]: Entering directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5/ext/DynaLoader'
/bin/sh: /mount/hdb1/home/corion/tmp/synced: Datei oder
Verzeichnis
nicht gefunden
make[1]: *** [../../lib/.exists] Fehler 127
make[1]: Leaving directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5/ext/DynaLoader'
make: *** [DynaLoader.o] Fehler 2
prompt>patch -p 2 <
../../perl-5.9.5-whitespace-Makefile.SH.diff
patching file Makefile.SH
prompt>patch -p 2 <
../../perl-5.9.5-whitespace-ExtUtils-MM.diff
patching file lib/ExtUtils/MM_Unix.pm
prompt>rm Makefile
prompt>rm ext/DynaLoader/Makefile
prompt>make # now succeeds
...
make[1]: Leaving directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5/ext/IO_Compress_Zlib'
Everything is up to date. Type 'make test' to run
test suite.
prompt>make test
...
make[2]: Entering directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5'
cd t && ./perl TEST </dev/tty
t/base/cond.................................................
..ok
t/base/if...................................................
..ok
t/base/lex..................................................
..ok
t/base/num..................................................
..ok
t/base/pat..................................................
..ok
t/base/rs...................................................
..ok
t/base/term.................................................
..sh:
/mount/hdb1/home/corion/tmp/synced: Datei oder Verzeichnis
nicht gefunden
FAILED at test 2
Failed a basic test (base/term.t) -- cannot continue.
make[2]: *** [_test_tty] Fehler 29
make[2]: Leaving directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5'
make[1]: *** [_test] Fehler 2
make[1]: Leaving directory
`/mount/hdb1/home/corion/tmp/synced
blead/perl-5.9.5'
make: *** [test] Fehler 2
prompt> patch -p 2 <
../../perl-5.9.5-whitespace-base.diff
prompt> make test
...
Failed 63 tests out of 1370, 95.40% okay.
>> 3) perl-5.9.5-whitespace-base.diff
>> 4) perl-5.9.5-whitespace-test.pl.diff
>
> Looks OK.
>> --- lib/ExtUtils/t/oneliner.t 2007-07-07
15:40:24.000000000 +0200
> I think you're missing some "" inside that
qq?
Whoops - indeed. The patches for the EU:MM tests are now
attached as a
separate file.
> (Thanks for splitting up the patches for review and
providing such a
> useful summary, BTW. It's much appreciated.)
You're welcome - I hope by making many small patches (and
grouping them
together in logical units) I make it easier to apply parts
even if not
everything from a patchset gets applied.
The next patches will then fix the/some test failures. It's
mostly the
test suite that needs patching. I suspect a bug or two in
Module::Build
and Archive::Extract, but I haven't dug into these
failures.
-max
|
