List Info

Thread: Fix t/op/magic.t failures under Cygwin




Fix t/op/magic.t failures under Cygwin
user name
2007-09-06 12:37:34
The attached patch fixes the following t/op/magic.t failures
that
occur under Cygwin on Windows:

../t/op/magic....1..58
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9
ok 10
ok 11
ok 12
ok 13
ok 14
ok 15
ok 16
ok 17
ok 18
ok 19
ok 20
ok 21
ok 22
ok 23
ok 24
ok 25
not ok 26
# Failed test at line 258
#  :$^X is /c/perl_tmp/31805/perl-current/perl, $0 is
/cygdrive/c/perl_tmp/31805/perl-current/show-shebang
:!=:$^X is /cygdrive/c/perl_tmp/31805/perl-current/perl, $0
is
/cygdrive/c/perl_tmp/31805/perl-current/show-shebang
:
not ok 27
# Failed test at line 263
#  :$^X is /c/perl_tmp/31805/perl-current/perl, $0 is
/cygdrive/c/perl_tmp/31805/perl-current/show-shebang
:!=:$^X is /cygdrive/c/perl_tmp/31805/perl-current/perl, $0
is
/cygdrive/c/perl_tmp/31805/perl-current/show-shebang
: after `/cygdrive/c/perl_tmp/31805/perl-current/perl
/cygdrive/c/perl_tmp/31805/perl-current/show-shebang`
ok 28
ok 29
ok 30
ok 31
ok 32
ok 33
ok 34
ok 35 # skipped: $0 check only on Linux and FreeBSD
ok 36 # skipped: $0 check only on Linux and FreeBSD
ok 37
ok 38 # skipped: no caseless %ENV support
ok 39 # skipped: no caseless %ENV support
ok 40 # skipped: no caseless %ENV support
ok 41 # skipped: no caseless %ENV support
ok 42
ok 43
ok 44
ok 45
ok 46
ok 47
ok 48
ok 49
ok 50
ok 51
ok 52
ok 53
ok 54
ok 55
ok 56
ok 57
ok 58
FAILED tests 26-27
        Failed 2/58 tests, 96.55% okay
Failed Test     Stat Wstat Total Fail  List of Failed
------------------------------------------------------------
-------------------
../t/op/magic.t               58    2  26-27
Failed 1/1 test scripts. 2/58 subtests failed.
Files=1, Tests=58,  4 wallclock secs ( 0.59 cusr +  0.29
csys =  0.88 CPU)
Failed 1/1 test programs. 2/58 subtests failed.

  
Re: Fix t/op/magic.t failures under Cygwin
user name
2007-09-07 03:39:19
On 06/09/2007, Jerry D. Hedden <jdheddencpan.org> wrote:
> The attached patch fixes the following t/op/magic.t
failures that
> occur under Cygwin on Windows:

Thanks, applied as #31809, but amended so that
Cygwin::win_to_posix_path() is called only on Cygwin.

Re: Fix t/op/magic.t failures under Cygwin
user name
2007-09-09 08:50:49
Rafael Garcia-Suarez schrieb:
> On 06/09/2007, Jerry D. Hedden <jdheddencpan.org> wrote:
>> The attached patch fixes the following t/op/magic.t
failures that
>> occur under Cygwin on Windows:
> 
> Thanks, applied as #31809, but amended so that
> Cygwin::win_to_posix_path() is called only on Cygwin.

+$^X =
Cygwin::win_to_posix_path(Cygwin::posix_to_win_path($^X,
1));
+$0 =
Cygwin::win_to_posix_path(Cygwin::posix_to_win_path($0,
1));

I believe this is the correct way to unify different $^X
paths.
I don't think that CORE should be fixed, it is only an
artefact
of your weird mount settings.

Taint failures because of different calls of the same binary
on 
different locations (symlinks, hardlinks, mounts) have to be
fixed in 
the app (here the test) not in CORE by unification (by means
of realpath 
or this cygwin roundtrip which unifies different mounts
also) of $^X.

-- 
Reini Urban
http://phpwiki.org/  http://murbreak.at/
http://helsinki.at/  http://spacemovie.mur.at/

Re: Fix t/op/magic.t failures under Cygwin
user name
2007-09-10 08:42:22
Jerry D. Hedden patched:
> +$^X =
Cygwin::win_to_posix_path(Cygwin::posix_to_win_path($^X,
1));
> +$0 =
Cygwin::win_to_posix_path(Cygwin::posix_to_win_path($0,
1));

Reini Urban wrote:
> I believe this is the correct way to unify different
$^X paths.
> I don't think that CORE should be fixed, it is only an
artefact
> of your weird mount settings.
>
> Taint failures because of different calls of the same
binary on
> different locations (symlinks, hardlinks, mounts) have
to be fixed in
> the app (here the test) not in CORE by unification (by
means of realpath
> or this cygwin roundtrip which unifies different mounts
also) of $^X.

I gather you're referring to my report of fork+taint
failures:

http://www.nntp.perl.org/group/perl.perl
5.porters/2007/09/msg128379.html

Can you submit patches to correct these?  Or could you
provide me with an idea of how to correct them, and I'll
try
to come up with the patches.

[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )