List Info

Thread: Optimized magic_setisa has bug




Optimized magic_setisa has bug
user name
2007-09-06 13:40:39
On Aug 13 2007, Rick Delaney wrote:
> I feel like we don't have to worry about saving the
mro_isa_changed_in()
> until the end (of pp_aassign) just because of possible
exceptions.  It is
> no worse than the case for tied arrays (or other magic)
that may throw
> exceptions in the middle of an assignment.  If it's not
a big deal then
> we can easily add the optimization back in by just
putting the mg_set
> back inside the (outer) loop.

Like the attached patch.

-- 
Rick Delaney
rickbort.ca

  
Re: Optimized magic_setisa has bug
user name
2007-09-10 04:43:37
On 06/09/2007, Rick Delaney <rickbort.ca> wrote:
> On Aug 13 2007, Rick Delaney wrote:
> > I feel like we don't have to worry about saving
the mro_isa_changed_in()
> > until the end (of pp_aassign) just because of
possible exceptions.  It is
> > no worse than the case for tied arrays (or other
magic) that may throw
> > exceptions in the middle of an assignment.  If
it's not a big deal then
> > we can easily add the optimization back in by just
putting the mg_set
> > back inside the (outer) loop.
>
> Like the attached patch.

Thanks, applied as #31838.

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )