Re: Smoke 31875 FAIL(m) MSWin32 Win2003 SP2 (x86/1 cpu)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Abe Timmerman wrote:
> Automated smoke report for 5.10.0 patch 31875
> jimmy: x86 Family 15 Model 1 Stepping 2, GenuineIntel
(x86/1 cpu)
>     on        MSWin32 - Win2003 SP2
>     using     ? unknown cc version 
>     smoketime 1 minute 31 seconds (average 22.750
seconds)
> 
> Summary: FAIL(m)
> 
> O = OK  F = Failure(s), extended report at the bottom
> X = Failure(s) under TEST but not under harness
> ? = still running or test results not (yet) available
> Build failures during:       - = unknown or N/A
> c = Configure, m = make, M = make (after miniperl), t =
make test-prep
> 
>    31875     Configuration (common) -DCCHOME=C:MinGW
-DCCTYPE=GCC -Dgcc_v3_2
> -----------
---------------------------------------------------------
> m m         -Duselargefiles
> m m         -Duseithreads -Duselargefiles
> | +--------- -DDEBUGGING
> +----------- no debugging

- From the smokelog:

C:/MinGW/bin/../libexec/gcc/mingw32/3.4.2/collect2.exe
-Bdynamic -o
..generate_uudmap.exe /mingw/lib/crt2.o
C:/MinGW/bin/../lib/gcc/mingw32/3.4.2/crtbegin.o
-Lc:perllibCORE
- -LC:MinGWlib -LC:/MinGW/bin/../lib/gcc/mingw32/3.4.2
- -LC:/MinGW/bin/../lib/gcc -L/mingw/lib/gcc/mingw32/3.4.2
-
-LC:/MinGW/bin/../lib/gcc/mingw32/3.4.2/../../../../mingw32/
lib
- -L/mingw/lib/gcc/mingw32/3.4.2/../../../../mingw32/lib
-L/mingw/lib
- -LC:/MinGW/bin/../lib/gcc/mingw32/3.4.2/../../..
- -L/mingw/lib/gcc/mingw32/3.4.2/../../..
C:DOCUME~1abeltjeLOCALS~1Temp1mk3 -lstdc++
- -lmingw32 -lgcc -lmoldname -lmingwex -lmsvcrt -luser32
-lkernel32 -ladvapi32
- -lshell32 -lmingw32 -lgcc -lmoldname -lmingwex -lmsvcrt
C:/MinGW/bin/../lib/gcc/mingw32/3.4.2/crtend.o
In file included from ..globals.c:30:
../perl.h:4428: error: syntax error before ';' token
dmake:  Error code 129, while making 'miniglobals.o'
Unable to make perl in this configuration


Abe
- --
 _  | SIMM crosstalk. (#99)
( ) |
 X  |
/  |
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFG7Sye0u0nt7xxiCIRAnYGAJ9Wa0HFDd9ljFYXhEkIoEi6hjf8mACf
WjIT
9AXjcPvlzKYmDNB1cNTe55c=
=Jq8U
-----END PGP SIGNATURE-----

On Sun, Sep 16, 2007 at 03:16:14PM +0200, Abe Timmerman
wrote:

> - From the smokelog:
> 
> C:/MinGW/bin/../libexec/gcc/mingw32/3.4.2/collect2.exe
-Bdynamic -o
> ..generate_uudmap.exe /mingw/lib/crt2.o
> C:/MinGW/bin/../lib/gcc/mingw32/3.4.2/crtbegin.o
-Lc:perllibCORE
> - -LC:MinGWlib
-LC:/MinGW/bin/../lib/gcc/mingw32/3.4.2
> - -LC:/MinGW/bin/../lib/gcc
-L/mingw/lib/gcc/mingw32/3.4.2
> -
-LC:/MinGW/bin/../lib/gcc/mingw32/3.4.2/../../../../mingw32/
lib
> -
-L/mingw/lib/gcc/mingw32/3.4.2/../../../../mingw32/lib
-L/mingw/lib
> - -LC:/MinGW/bin/../lib/gcc/mingw32/3.4.2/../../..
> - -L/mingw/lib/gcc/mingw32/3.4.2/../../..
> C:DOCUME~1abeltjeLOCALS~1Temp1mk3 -lstdc++
> - -lmingw32 -lgcc -lmoldname -lmingwex -lmsvcrt
-luser32 -lkernel32 -ladvapi32
> - -lshell32 -lmingw32 -lgcc -lmoldname -lmingwex
-lmsvcrt
> C:/MinGW/bin/../lib/gcc/mingw32/3.4.2/crtend.o
> In file included from ..globals.c:30:
> ../perl.h:4428: error: syntax error before ';' token
> dmake:  Error code 129, while making 'miniglobals.o'
> Unable to make perl in this configuration

Did the appended change fix it?

Nicholas Clark

Change 31876 by nicholasnicholas-saigo on
2007/09/16 23:28:30

	Change 31873 was not robust against the possibility that
the
	configuration has no #defined options. So add a
"" that will make the
	initialiser for PL_bincompat_options syntactically correct
in this
	case.

Affected files ...

... //depot/perl/perl.h#791 edit

Differences ...

==== //depot/perl/perl.h#791 (text) ====

 -4425,7
+4425,7 
 #  ifdef USE_SOCKS
 			     " USE_SOCKS"
 #  endif
-  ;
+  "";
 #else
 EXTCONST char PL_bincompat_options[];
 #endif