On Thu, 20 Sep 2007, Steve Hay wrote:
> Jan Dubois wrote:
> > It looks like we cannot determine the workgroup
name if the
> > "Workstation" service isn't running. I
therefore removed the
> > Win32: omainNam
e() test from t/Names.t (patch below is against by
> > local depot for the CPAN version, but should
otherwise be identical
> > to the bleadperl one).
>
> Couldn't we call Win32:omainNam
e() and then check the value of $^E
> afterwards? If it is 2138 (The Workstation service has
not been
> started) then skip the tests, otherwise test the
returned $domain?
At least in my tests it looks like $^E doesn't get set to
any error
condition, but I can of course add an explicit call to
SetLastError()
in the XS code.
I'll do that and update the test once more.
I also just noticed that Win32::GetOSName() in list context
can return
an empty string as the second return value if you are
running on a system
without any service packs (e.g. Vista right now).
I'll fix that, add the #define changes from you and Dmitry
and make another
CPAN release of Win32 so that 5.10 _should_ contain the
regular CPAN version
upon release.
Cheers,
-Jan
|