while looking at Mr. Clark's recent touches to hv.*


1 - a bit more explanation in struct hek comments.

might save someone else some poking around S_save_hek_flags
..

     Newx(k, HEK_BASESIZE + len + 2, char);
     hek = (HEK*)k;


2 - replace obfuscated macro param-names with names of
function params

IMHO such obfuscation is unfriendly to someone looking under
the hood.
Perhaps the point is 'these macros are uninteresting', but
thats a
conclusion the reader could reach on his own.

On 9/21/07, Jim Cromie <jim.cromiegmail.com> wrote:
>
> while looking at Mr. Clark's recent touches to hv.*
>
>
> 1 - a bit more explanation in struct hek comments.
>
> might save someone else some poking around
S_save_hek_flags ..
>
>      Newx(k, HEK_BASESIZE + len + 2, char);
>      hek = (HEK*)k;
>
>
> 2 - replace obfuscated macro param-names with names of
function params
>
> IMHO such obfuscation is unfriendly to someone looking
under the hood.
> Perhaps the point is 'these macros are uninteresting',
but thats a
> conclusion the reader could reach on his own.

> -#define hv_store_flags(urkk, zamm, clunk, thwape,
sploosh, eee_yow)    

is just classic tho.

yves

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

On Fri, Sep 21, 2007 at 11:46:07AM -0600, Jim Cromie wrote:
> 
> while looking at Mr. Clark's recent touches to hv.*

Who he? 

[Context - I avoid using a title at all because the
qualification that gives
me a title other than Mr is not relevant to what I do these
days. I wouldn't
want anyone to mistakenly think I was actually supposed to
be any good at it]

> 2 - replace obfuscated macro param-names with names of
function params
> 
> IMHO such obfuscation is unfriendly to someone looking
under the hood.
> Perhaps the point is 'these macros are uninteresting',
but thats a
> conclusion the reader could reach on his own.

I got into a policy of using non-obvious names inside macros
tripped up by
bugs introduced by using the same name in the macro as in
the code outside.
I suspect that this was for the specific case of the various
GCC-only
alternative macro definitions that use the GCC embedded
block syntax to
declare temporary variables. I guess I got into a habit.

[And I've certainly been using more "interesting"
names in regression tests.
It actually helps there, as you're not tempted to re-use
variables in later
tests, which can cause subtle bugs]

Nicholas Clark

On Fri, 28 Sep 2007, Nicholas Clark wrote:

> [Context - I avoid using a title at all because the
qualification that gives
> me a title other than Mr is not relevant to what I do
these days. I wouldn't
> want anyone to mistakenly think I was actually supposed
to be any good at it]

Well, I happen to think that qualification is not totally
irrelevant 
either, but then I'm rather biased that way .

-- 
    Andy Dougherty		dougheralafayette.edu