Re: Smoke 31938 FAIL(F) netbsd 3.1 (i386/1 cpu)

On Sun, 23 Sep 2007 01:11:50 +0200, Abe Timmerman
<abeztreet.demon.nl> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Abe Timmerman wrote:
> > Abe Timmerman wrote:
> > [snip]
> > 
> > That doesn't look good :(
> > 
> > 	$ LC_ALL=en_US.UTF-8 ./perl -e '1'
> > 	perl: warning: Setting locale failed.
> > 	perl: warning: Please check that your locale
settings:
> > 	        LC_ALL = "en_US.UTF-8",
> > 	        LANG = (unset)
> > 	    are supported and installed on your system.
> > 	perl: warning: Falling back to the standard
locale ("C").
> > 
> > I reconfigured with:
> > 	-A append:ccflags='-DNO_LOCALE_COLLATE
-DNO_LOCALE_NUMERIC'
> > 
> > now:
> > 
> > 	$ LC_ALL=en_US.UTF-8 PERLUNICODE=""
./perl harness
> > 
> > Yields the much better:
> > 
> > Failed Test     Stat Wstat Total Fail  List of
Failed
> >
------------------------------------------------------------
-------------------
> > ../lib/locale.t              117   10  2-9 15 54
> > uni/overload.t     8  2048   208    8  34 38 40 44
46 50 52 56
> > 71 tests and 889 subtests skipped.
> > Failed 2/1461 test scripts. 18/184551 subtests
failed.
> > Files=1461, Tests=184551, 1803 wallclock secs
(684.07 cusr + 129.90 csys =
> > 813.97 CPU)
> > Failed 2/1461 test programs. 18/184551 subtests
failed.
> > 
> > 
> > Looking at lib/locale.t, it looks like tainting is
not turned on for the
> > LC_CTYPE goup of functions.
> > 
> > Looking at t/uni/overload.t, it looks like netbsd
also has a broken
> > 'en_GB.ISO8859-1', I can send a patch to add
netbsd to the list.
> > 
> > 
> > Now is it useful to try and make the locale work
on NetBSD, without LC_COLLATE
> > and LC_NUMERIC?
> > 
> > If so, is there a way to add those NO_LOCALE_xxx
macro's only for the
> > compilation of locale.c (by default on NetBSD)?
> 
> The attached patch:
> 
> 	* adds $locale_cflags and $sv_cflags to
hints/netbsd.sh with
> - -DNO_LOCALE_COLLATE and -DNO_LOCALE_NUMERIC
> 
> 	* adds netbsd to the list of osses that have a broken
'en_GB.ISO8859-1'

Thanks, applied with one extra line of comment as change
#31942

-- 
H.Merijn Brand         Amsterdam Perl Mongers (http://amsterdam.pm.org/
)
using & porting perl 5.6.2, 5.8.x, 5.9.x   on HP-UX
10.20, 11.00, 11.11,
& 11.23, SuSE 10.0 & 10.2, AIX 4.3 & 5.2, and
Cygwin. http://qa.perl.org
http://mirrors.de
velooper.com/hpux/            http://www.test-smoke.org
                        http
://www.goldmark.org/jeff/stupid-disclaimers/

On Sun, 23 Sep 2007 09:01:40 +0000, "H.Merijn
Brand" <h.m.brandxs4all.nl>
wrote:

> On Sun, 23 Sep 2007 01:11:50 +0200, Abe Timmerman
<abeztreet.demon.nl> wrote:
> > > Looking at lib/locale.t, it looks like
tainting is not turned on for the
> > > LC_CTYPE goup of functions.
> > > 
> > > Looking at t/uni/overload.t, it looks like
netbsd also has a broken
> > > 'en_GB.ISO8859-1', I can send a patch to add
netbsd to the list.
> > > 
> > > 
> > > Now is it useful to try and make the locale
work on NetBSD, without LC_COLLATE
> > > and LC_NUMERIC?
> > > 
> > > If so, is there a way to add those
NO_LOCALE_xxx macro's only for the
> > > compilation of locale.c (by default on
NetBSD)?
> > 
> > The attached patch:
> > 
> > 	* adds $locale_cflags and $sv_cflags to
hints/netbsd.sh with
> > - -DNO_LOCALE_COLLATE and -DNO_LOCALE_NUMERIC
> > 
> > 	* adds netbsd to the list of osses that have a
broken 'en_GB.ISO8859-1'
> 
> Thanks, applied with one extra line of comment as
change #31942

So, should it be reverted?

-- 
H.Merijn Brand         Amsterdam Perl Mongers (http://amsterdam.pm.org/
)
using & porting perl 5.6.2, 5.8.x, 5.9.x   on HP-UX
10.20, 11.00, 11.11,
& 11.23, SuSE 10.0 & 10.2, AIX 4.3 & 5.2, and
Cygwin. http://qa.perl.org
http://mirrors.de
velooper.com/hpux/            http://www.test-smoke.org
                        http
://www.goldmark.org/jeff/stupid-disclaimers/