List Info

Thread: xsubpp omits newline after length(foo) declarations




xsubpp omits newline after length(foo) declarations
user name
2007-10-14 19:41:56
# New Ticket Created by  Peter J. Holzer 
# Please include the string:  [perl #46431]
# in the subject line of all future correspondence about
this issue. 
# <URL: h
ttp://rt.perl.org/rt3/Ticket/Display.html?id=46431 >



This is a bug report for perl from hjphjp.at,
generated with the help of perlbug 1.35 running under perl
v5.8.8.


------------------------------------------------------------
-----
[Please enter your report here]

Consider the following XS code:

    void
    judy1_thaw(unsigned long set, char *str, unsigned long
length(str))
	CODE:
	    Pvoid_t s1 = (Pvoid_t)set;

This gets translated into into:

    XS(XS_Bit__Vector__Judy_judy1_thaw); /* prototype to
pass -Wmissing-prototypes */   
    XS(XS_Bit__Vector__Judy_judy1_thaw)
    {
	dXSARGS;
	if (items != 2)
	    Perl_croak(aTHX_ "Usage:
Bit::Vector::Judy::judy1_thaw(set, str)");
	PERL_UNUSED_VAR(cv); /* -W */
	{
	    STRLEN  STRLEN_length_of_str;
	    unsigned long   XSauto_length_of_str;
	    unsigned long   set = (unsigned long)SvUV(ST(0));
	    char *  str = (char *)SvPV(ST(1),
STRLEN_length_of_str);

	    XSauto_length_of_str = STRLEN_length_of_str;#line 361
"Judy.xs"
	    Pvoid_t s1 = (Pvoid_t)set;

The preprocessor directive '#line 361 "Judy.xs"'
gets tacked at the end
of the previous line, which gcc doesn't like:

    Judy.c: In function
‘XS_Bit__Vector__Judy_judy1_thaw’:
    Judy.c:599: error: stray ‘#’ in program

Adding a newline fixes the problem:

--- lib/ExtUtils/xsubpp.orig	2005-04-21 18:03:46.000000000
+0200
+++ lib/ExtUtils/xsubpp	2007-10-14 21:45:36.000000000 +0200
 -430,7
+430,7 
 	  print "tSTRLENtSTRLEN_length_of_$2;n";
 	  $lengthof{$2} = $name;
 	  # $islengthof{$name} = $1;
-	  $deferred .= "ntXSauto_length_of_$2 =
STRLEN_length_of_$2;";
+	  $deferred .= "ntXSauto_length_of_$2 =
STRLEN_length_of_$2;n";
 	}
 
 	# check for optional initialisation code


[Please do not change anything below this line]
------------------------------------------------------------
-----
---
Flags:
    category=utilities
    severity=medium
---
Site configuration information for perl v5.8.8:

Configured by Debian Project at Wed Dec  6 23:17:41 UTC
2006.

Summary of my perl5 (revision 5 version 8 subversion 8)
configuration:
  Platform:
    osname=linux, osvers=2.6.18.3,
archname=i486-linux-gnu-thread-multi
    uname='linux saens 2.6.18.3 #1 smp sat nov 25 13:39:52
est 2006 i686 gnulinux '
    config_args='-Dusethreads -Duselargefiles
-Dccflags=-DDEBIAN -Dcccdlflags=-fPIC
-Darchname=i486-linux-gnu -Dprefix=/usr
-Dprivlib=/usr/share/perl/5.8 -Darchlib=/usr/lib/perl/5.8
-Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5
-Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local
-Dsitelib=/usr/local/share/perl/5.8.8
-Dsitearch=/usr/local/lib/perl/5.8.8
-Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3
-Dsiteman1dir=/usr/local/man/man1
-Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1
-Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs
-Ud_csh -Uusesfio -Uusenm -Duseshrplib
-Dlibperl=libperl.so.5.8.8 -Dd_dosuid -des'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=define use5005threads=undef
useithreads=define usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define
usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE
-DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe
-I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS
-DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include'
    ccversion='', gccversion='4.1.2 20061115 (prerelease)
(Debian 4.1.1-20)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8,
byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define,
longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8,
Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc
-lcrypt
    perllibs=-ldl -lm -lpthread -lc -lcrypt
    libc=/lib/libc-2.3.6.so, so=so, useshrplib=true,
libperl=libperl.so.5.8.8
    gnulibc_version='2.3.6'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef,
ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared
-L/usr/local/lib'

Locally applied patches:
    

---
INC
for perl v5.8.8:
    /etc/perl
    /usr/local/lib/perl/5.8.8
    /usr/local/share/perl/5.8.8
    /usr/lib/perl5
    /usr/share/perl5
    /usr/lib/perl/5.8
    /usr/share/perl/5.8
    /usr/local/lib/site_perl
    .

---
Environment for perl v5.8.8:
    HOME=/home/hjp
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LC_COLLATE=POSIX
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
   
PATH=/home/hjp/bin/hosts:/home/hjp/bin:/usr/local/sbin:/usr/
local/bin:/usr/sbin:/sbin:/bin:/usr/bin:/usr/bin/X11:/usr/ga
mes
    PERL_BADLANG (unset)
    SHELL=/bin/zsh


Re: xsubpp omits newline after length(foo) declarations
user name
2007-10-18 04:33:08
All the code previously in xsubpp has been moved in
ExtUtils::ParseXS,
and several bugs have been fixed.
Could you report this bug against this module's CPAN RT
queue?

http://rt.cpan.org/Public/Dist/Display.html?Nam
e=ExtUtils-ParseXS

On 15/10/2007, via RT Peter J. Holzer
<perlbug-followupperl.org> wrote:
> Consider the following XS code:
>
>     void
>     judy1_thaw(unsigned long set, char *str, unsigned
long length(str))
>         CODE:
>             Pvoid_t s1 = (Pvoid_t)set;
>
> This gets translated into into:
>
>     XS(XS_Bit__Vector__Judy_judy1_thaw); /* prototype
to pass -Wmissing-prototypes */
>     XS(XS_Bit__Vector__Judy_judy1_thaw)
>     {
>         dXSARGS;
>         if (items != 2)
>             Perl_croak(aTHX_ "Usage:
Bit::Vector::Judy::judy1_thaw(set, str)");
>         PERL_UNUSED_VAR(cv); /* -W */
>         {
>             STRLEN  STRLEN_length_of_str;
>             unsigned long   XSauto_length_of_str;
>             unsigned long   set = (unsigned
long)SvUV(ST(0));
>             char *  str = (char *)SvPV(ST(1),
STRLEN_length_of_str);
>
>             XSauto_length_of_str =
STRLEN_length_of_str;#line 361 "Judy.xs"
>             Pvoid_t s1 = (Pvoid_t)set;
>
> The preprocessor directive '#line 361
"Judy.xs"' gets tacked at the end
> of the previous line, which gcc doesn't like:
>
>     Judy.c: In function
'XS_Bit__Vector__Judy_judy1_thaw':
>     Judy.c:599: error: stray '#' in program
>
> Adding a newline fixes the problem:
>
> --- lib/ExtUtils/xsubpp.orig    2005-04-21
18:03:46.000000000 +0200
> +++ lib/ExtUtils/xsubpp 2007-10-14 21:45:36.000000000
+0200
>  -430,7 +430,7 
>           print
"tSTRLENtSTRLEN_length_of_$2;n";
>           $lengthof{$2} = $name;
>           # $islengthof{$name} = $1;
> -         $deferred .= "ntXSauto_length_of_$2 =
STRLEN_length_of_$2;";
> +         $deferred .= "ntXSauto_length_of_$2 =
STRLEN_length_of_$2;n";
>         }
>
>         # check for optional initialisation code

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )