Re: Update File::Fetch to 0.13_02

On Nov 4, 2007 10:54 AM, Jos I. Boumans <josdwim.org> wrote:
> Greetings,
>
> attached is the patch to update File::Fetch to 0.13_02.
This release has
> improved handling of file:// urls, and is first half of
the fix to
> address
> the CPANPLUS failures on Win32. The other part is a
patch to CPANPLUS
> which
> I will send seperately, but ***depends on this
patch***.
>
> If all smokes show us the green light, this version
will be promoted to
> 0.14 and therefor stable.
>
> As per usual, all tests succesfull on my development
box against a
> recent
> bleadperl. Here's the full changelog for completeness
sake:

Attached is a patch to add some documentation, fix some
behavior, and
changes to the tests to not test unix style paths on non
unix OS'es
and vice versa. File:\ urls are inherently OS specific
after all.

This means that

      file:///disk$user/my/notes/note12345.txt

refers to:

  DISK$USER:[MY.NOTES]NOTE123456.TXT

if localhost is VMS and to

  /disk$user/my/notes/note12345.txt

on linux. It also means that

  file///d|/foo/bar.txt

means

  d:foobar.txt

on if localhost is win32, but it means

  /d|/foo/bar/.txt

on unix.

Yes this allows illegal file names to be constructed, and
makes
file:// urls context dependent, thats an inherent problem in
their
specification (or lack thereof).

I actually think it should be an error to supply a file:////
url to a
non-windows box, but thats arguable. I doubt that it should
be treated
(silently) as an empty volume specification on VMS, however
this is
currently what would happen.

Cheers,
yves


-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

On Nov 4, 2007 9:53 PM, demerphq <demerphqgmail.com> wrote:
> On Nov 4, 2007 10:54 AM, Jos I. Boumans <josdwim.org> wrote:
> > Greetings,
> >
> > attached is the patch to update File::Fetch to
0.13_02. This release has
> > improved handling of file:// urls, and is first
half of the fix to
> > address
> > the CPANPLUS failures on Win32. The other part is
a patch to CPANPLUS
> > which
> > I will send seperately, but ***depends on this
patch***.
> >
> > If all smokes show us the green light, this
version will be promoted to
> > 0.14 and therefor stable.
> >
> > As per usual, all tests succesfull on my
development box against a
> > recent
> > bleadperl. Here's the full changelog for
completeness sake:
>
> Attached is a patch to add some documentation, fix some
behavior, and
> changes to the tests to not test unix style paths on
non unix OS'es
> and vice versa. File:\ urls are inherently OS specific
after all.
>
> This means that
>
>       file:///disk$user/my/notes/note12345.txt
>
> refers to:
>
>   DISK$USER:[MY.NOTES]NOTE123456.TXT
>
> if localhost is VMS and to
>
>   /disk$user/my/notes/note12345.txt
>
> on linux. It also means that
>
>   file///d|/foo/bar.txt
>
> means
>
>   d:foobar.txt
>
> on if localhost is win32, but it means
>
>   /d|/foo/bar/.txt
>
> on unix.
>
> Yes this allows illegal file names to be constructed,
and makes
> file:// urls context dependent, thats an inherent
problem in their
> specification (or lack thereof).
>
> I actually think it should be an error to supply a
file://// url to a
> non-windows box, but thats arguable. I doubt that it
should be treated
> (silently) as an empty volume specification on VMS,
however this is
> currently what would happen.

whoops, patch attached this time.

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"