Re: (perl-current of 5.9.5) patch for ext/Sys/Syslog/Makefile.PL for EBCDIC platform

Sébastien Aperghis-Tramoni <maddinguefree.fr> wrote 2007-11-04 03:50:46:

> Chun Bing Ge wrote:
> 
> > In perl-current(5.9.5) maybe there is not a test
case to test 
> > "_PATH_LOG". [...]
> >
> > If the ext/Sys/Syslog/Makefile.Pl has these codes
like:
> >   if (-S "/dev/log" && -w
"/dev/log") {
> >
> > I got these return when I run the test case above
on z/OS:
> > unix passed to setlogsock, but path not available
at sys.t line 6
> > .
> >
> > If changed those code in Makefile.PL to:
> >   if ((-S "/dev/log" || -c
"/dev/log") && -w "/dev/log") {
> > I got:
> > no connection to syslog available
> >         - /dev/log is not a socket at sys.t line
8
> > .
> >
> > Recently, I am very busy. I have no time to
investigate the 2nd error.
> > If you know the reason, please let me know. Thanks
a lot.
> 
> That's why I was asking. I'm unsurprised by this error,
because the 
> test in Makefile.PL is repeated in Syslog.pm. I've just
modified it 
> in my dev branch and I'm preparing a patch for blead.
>    » http://svnweb.mongueurs.net/Sys-Syslog/revision/?rev=152

> 
> If this version works for you and doesn't create any
black smoke, 
> I'll bump the version and release it on the CPAN.
> 
Yes, you are right! It's perfect! Thanks for your help!



--- /home/spring/Syslog.pm      2007-11-05
09:06:28.000000000 +0800
+++ lib/Sys/Syslog.pm   2007-11-05 09:07:36.000000000 +0800
 -548,7
+548,7 
        return 0;
     }

-    if (! -S $syslog_path) {
+    if (not (-S $syslog_path or -c _)) {
         push $errs, "$syslog_path is not a
socket";
        return 0;
     }




Ge, Chun Bing
空山新雨后，天气晚来秋