Net/Ping/t/510_ping_udp.t fails on Windows Vista

As far as I can tell this is not an admin privileges problem
but due
to the fact that the builtin firewall blocks the traffic by
default.
Disabling the firewall lets the test pass.  I haven't tried
creating
a rule to let the traffic pass through.

Anyways, should we skip this test on Vista, or just let it
fail?

Cheers,
-Jan

PS: All other tests passed with a default build of
bleadperl32225 on Vista 32-bit:

Failed Test                      Stat Wstat Total Fail  List
of Failed
------------------------------------------------------------
-------------------
../lib/Net/Ping/t/510_ping_udp.t                2    1  2
 (1 subtest UNEXPECTEDLY SUCCEEDED), 55 tests and 1082
subtests skipped.
Failed 1/1467 test scripts. 1/186137 subtests failed.
Files=1467, Tests=186137, 1292 wallclock secs ( 0.00 cusr + 
0.00 csys =  0.00 CPU)
Failed 1/1467 test programs. 1/186137 subtests failed.

On Mon, Nov 05, 2007 at 11:40:03AM -0800, Jan Dubois wrote:
> As far as I can tell this is not an admin privileges
problem but due
> to the fact that the builtin firewall blocks the
traffic by default.
> Disabling the firewall lets the test pass.  I haven't
tried creating
> a rule to let the traffic pass through.
> 
> Anyways, should we skip this test on Vista, or just let
it fail?

Assuming that Vista isn't going to change, it would seem
better to skip it.

Nicholas Clark

Because Net::Ping is a dual-lifed module the tests need to
work with
old versions of Perl and Win32.  I would recommend something
like this:

sub IsWindowsVista {
    return unless $^O eq 'MSWin32' or $^O eq
"cygwin";
    return unless eval { require Win32 };
    return unless defined &Win32::GetOSName;
    return Win32::GetOSName() eq "WinVista";
}

Cheers,
-Jan


> -----Original Message-----
> From: Steve Peters [mailto:steve.petersgmail.com]
> Sent: November 5, 2007 12:49 PM
> To: Jan Dubois
> Cc: Perl 5 Porters (E-Mail)
> Subject: Re: Net/Ping/t/510_ping_udp.t fails on Windows
Vista
> 
> I'd be happy to add it.  I also have a couple of other
fixes to add to
> Net-Ping as well.  Just one question, though, what
should I be
> checking for to see if a test is running on Vista?
> 
> Thanks,
> 
> Steve Peters
> stevefisharerojo.org
> 
> On 11/5/07, Jan Dubois <jandactivestate.com> wrote:
> > As far as I can tell this is not an admin
privileges problem but due
> > to the fact that the builtin firewall blocks the
traffic by default.
> > Disabling the firewall lets the test pass.  I
haven't tried creating
> > a rule to let the traffic pass through.
> >
> > Anyways, should we skip this test on Vista, or
just let it fail?
> >
> > Cheers,
> > -Jan
> >
> > PS: All other tests passed with a default build of
bleadperl32225 on Vista 32-bit:
> >
> > Failed Test                      Stat Wstat Total
Fail  List of Failed
> >
------------------------------------------------------------
-------------------
> > ../lib/Net/Ping/t/510_ping_udp.t                2 
  1  2
> >  (1 subtest UNEXPECTEDLY SUCCEEDED), 55 tests and
1082 subtests skipped.
> > Failed 1/1467 test scripts. 1/186137 subtests
failed.
> > Files=1467, Tests=186137, 1292 wallclock secs (
0.00 cusr +  0.00 csys =  0.00 CPU)
> > Failed 1/1467 test programs. 1/186137 subtests
failed.
> >
> >

I'd be happy to add it.  I also have a couple of other fixes
to add to
Net-Ping as well.  Just one question, though, what should I
be
checking for to see if a test is running on Vista?

Thanks,

Steve Peters
stevefisharerojo.org

On 11/5/07, Jan Dubois <jandactivestate.com> wrote:
> As far as I can tell this is not an admin privileges
problem but due
> to the fact that the builtin firewall blocks the
traffic by default.
> Disabling the firewall lets the test pass.  I haven't
tried creating
> a rule to let the traffic pass through.
>
> Anyways, should we skip this test on Vista, or just let
it fail?
>
> Cheers,
> -Jan
>
> PS: All other tests passed with a default build of
bleadperl32225 on Vista 32-bit:
>
> Failed Test                      Stat Wstat Total Fail 
List of Failed
>
------------------------------------------------------------
-------------------
> ../lib/Net/Ping/t/510_ping_udp.t                2    1 
2
>  (1 subtest UNEXPECTEDLY SUCCEEDED), 55 tests and 1082
subtests skipped.
> Failed 1/1467 test scripts. 1/186137 subtests failed.
> Files=1467, Tests=186137, 1292 wallclock secs ( 0.00
cusr +  0.00 csys =  0.00 CPU)
> Failed 1/1467 test programs. 1/186137 subtests failed.
>
>