Re: 5.10.0 test hangs on non internet access

On 07/11/2007, Jos I. Boumans <josdwim.org> wrote:
> And below is the patch. It's already applied to C:::Build'
s svn tree

Thanks, applied.

lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build............
..[ERROR]
Fetching of
'ftp://ftp.cpan.org/pub/CPAN/authors/01mailrc.txt.gz'
failed: Command failed: 

and then it hangs... Is that desirable? I can grant access
to a proxy so
I can get on with testing, but I'd suggest to make this test
SKIPpable.

Cheers,
-- 
Merijn Broeren | We take risks, we know we take them.
Therefore, when things
               | come out against us, we have no cause for
complaint.
               | - Scott, last journal entry, march 1912

Hi Merijn,

On 06 Nov 2007, at 12:39, Merijn Broeren wrote:

>
lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build............
..[ERROR]
> Fetching of
'ftp://ftp.cpan.org/pub/CPAN/authors/01mailrc.txt.gz'
> failed: Command failed:
>
> and then it hangs... Is that desirable? I can grant
access to a  
> proxy so
> I can get on with testing, but I'd suggest to make this
test  
> SKIPpable.

This has been reported during the week as well and this is a
test  
glitch;

A newer version of CPANPLUS has exposed this glitch in the 

C:::Build
test
suite, and it's already patched in C:::Build'
s svn.

A patch to core is forthcoming.

Thanks for keeping us on our toes ;)

--

   Jos Boumans

   How do I prove I'm not crazy to people who are?

On 06 Nov 2007, at 16:50, Jos I. Boumans wrote:

> A newer version of CPANPLUS has exposed this glitch in
the  
> C:::Build
test
> suite, and it's already patched in C:::Build'
s svn.
>
> A patch to core is forthcoming.

And below is the patch. It's already applied to C:::Build'
s svn tree

$ svk describe r4582
------------------------------------------------------------
----------
r4582:  kane | 2007-11-06 13:03:18 +0100

* with cpanplus 0.83_08, dslip information is being
retrieved from any
   module defined in the package. Missing dslip info
therefor uses the
   module tree, which we are trying to avoid in the test
suite.
   So, we define the dslip info explicitly and no module
trees are being
   used.
------------------------------------------------------------
----------
===
local/CPANPLUS-Dist-Build/trunk/t/02_CPANPLUS-Dist-Build.t
============================================================
======
---
local/CPANPLUS-Dist-Build/trunk/t/02_CPANPLUS-Dist-Build.t  

(revision 4581)
+++
local/CPANPLUS-Dist-Build/trunk/t/02_CPANPLUS-Dist-Build.t  

(revision 4582)
 -39,11
+39,15 


  ### create a fake object, so we don't use the actual
module tree
+### make sure to add dslip data, so CPANPLUS doesn't try to
find
+### it in another module in the package, for which it needs
the
+### module tree
  my $Mod = CPANPLUS::Module::Fake->new(
                  module  => 'Foo::Bar',
                  path    => 'src',
                  author  =>
CPANPLUS::Module::Author::Fake->new,
                  package => 'Foo-Bar-0.01.tar.gz',
+                dslip   => 'RdpO?',
              );

  $Conf->set_conf( base       => 'dummy-cpanplus' );

--

   Jos Boumans

   How do I prove I'm not crazy to people who are?