Smoke 32230 FAIL(M) MSWin32 WinXP/.Net SP2 (x86/2 cpu)

Automated smoke report for 5.10.0 patch 32230
maldoror.bath.planit.group: Intel(R) Core(TM)2 CPU 6700 
2.66GHz(~2660 MHz) (x86/2 cpu)
    on        MSWin32 - WinXP/.Net SP2
    using     cl version 12.00.8804
    smoketime 4 hours 18 minutes (average 12 minutes 55
seconds)

Summary: FAIL(M)

O = OK  F = Failure(s), extended report at the bottom
X = Failure(s) under TEST but not under harness
? = still running or test results not (yet) available
Build failures during:       - = unknown or N/A
c = Configure, m = make, M = make (after miniperl), t = make
test-prep

   32230     Configuration (common)
-DINST_TOP=$(INST_DRV)Smokedoesntexist
-----------
---------------------------------------------------------
O O         
O O         -Dusemymalloc
O O         -Duselargefiles
O O         -Duselargefiles -Dusemymalloc
O O         -Duseithreads -Uuseimpsys
O O         -Duseithreads -Uuseimpsys -Dusemymalloc
O O         -Duseithreads -Uuseimpsys -Duselargefiles
O O         -Duseithreads -Uuseimpsys -Duselargefiles
-Dusemymalloc
O M         -Duseithreads
O M         -Duseithreads -Duselargefiles
| +--------- -DDEBUGGING
+----------- no debugging

Locally applied patches:
    DEVEL
    SMOKE32230

Compiler messages(MSWin32):
..perlio.c(2434) : error C2065: 'my_perl' : undeclared
identifier
..perlio.c(2434) : error C2223: left of '->ILIO' must
point to struct/union

-- 
Report by Test::Smoke v1.20.07 build 1123 running on perl
5.9.5
(Reporter v0.029 / Smoker v0.036)

Steve Hay wrote:
> Automated smoke report for 5.10.0 patch 32230
> 
> Summary: FAIL(M)
> 
> O M         -Duseithreads
> O M         -Duseithreads -Duselargefiles
>> +--------- -DDEBUGGING
> +----------- no debugging
> 
> Compiler messages(MSWin32):
> ..perlio.c(2434) : error C2065: 'my_perl' : undeclared
identifier
> ..perlio.c(2434) : error C2223: left of '->ILIO'
must point to
> struct/union 

Now that my smokes are actually working again (thanks to
Nicholas), I
see that change #32215 has broken threaded debug builds on
Win32.
PerlLIO_write() becomes (*(my_perl->ILIO)->pWrite)(),
but
PerlIO_teardown() doesn't have a pTHX any more.

On Wed, Nov 07, 2007 at 09:21:30AM -0000, Steve Hay wrote:
> Steve Hay wrote:
> > Automated smoke report for 5.10.0 patch 32230
> > 
> > Summary: FAIL(M)
> > 
> > O M         -Duseithreads
> > O M         -Duseithreads -Duselargefiles
> >> +--------- -DDEBUGGING
> > +----------- no debugging
> > 
> > Compiler messages(MSWin32):
> > ..perlio.c(2434) : error C2065: 'my_perl' :
undeclared identifier
> > ..perlio.c(2434) : error C2223: left of
'->ILIO' must point to
> > struct/union 
> 
> Now that my smokes are actually working again (thanks
to Nicholas), I
> see that change #32215 has broken threaded debug builds
on Win32.
> PerlLIO_write() becomes
(*(my_perl->ILIO)->pWrite)(), but
> PerlIO_teardown() doesn't have a pTHX any more.

I've applied the following as a temp workaround until
someone comes up
with a portable way of writing debugging output that doesn't
require an
interpreter.

-- 
The Enterprise is involved in a bizarre time-warp experience
which is in
some way unconnected with the Late 20th Century.
    -- Things That Never Happen in "Star Trek"
#14

Change 32235 by davemdavem-pigeon on 2007/11/07 12:12:29

	Disable debugging output in PerlIO_teardown;
	it still relies on an interpreter being present.

Affected files ...

... //depot/perl/perlio.c#375 edit

Differences ...

==== //depot/perl/perlio.c#375 (text) ====

 -2416,6
+2416,12 
 void PerlIO_teardown() /* Call only from PERL_SYS_TERM().
*/
 {
     dVAR;
+#if 0
+/* XXX we can't rely on an interpreter being present at
this late stage,
+   XXX so we can't use a function like PerlLIO_write that
relies on one
+   being present (at least in win32) :-(.
+   Disable for now.
+*/
 #ifdef DEBUGGING
     {
 	/* By now all filehandles should have been closed, so any
 -2436,6
+2442,7 
 	}
     }
 #endif
+#endif
     /* Not bothering with PL_perlio_mutex since by now
      * all the interpreters are gone. */
     if (PL_perlio_fd_refcnt_size /* Assuming initial size
of zero. */