Re: Upgrading EIDER to latest Tusany code

On 12 Jul, 12:31, Caroline Maynard <c...php.net> wrote:

> Umm, that may work in the contect of bug10049, because
the value of the
> "customer" property is null ... but in
general it's going to leak like
> mad, because FREE_ZVAL just frees the container, not
the contents.
> You're right that this is where the problem lies though
- because I'm
> expecting that the refcount will be 1 at this point,
and it's actually
> 0, so the contents are not getting cleared. Thanks.

What's a little leaking between friends . Sorry,
I wasn't even
thinking about that.
I do have a question about the change though. Is there any
possibility
that EG(uninitialized_zval_ptr) would ever be returned for
either
value, as its probably not a good idea to be playing around
with that.
Conceptual I wouldn't think so if you are comparing 2 SDO
objects, but
I'm not fluents in its internal workings to know for sure.

Rob


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the
Google Groups "phpsoa" group.
To post to this group, send email to phpsoagooglegroups.com
To unsubscribe from this group, send email to
phpsoa-unsubscribegooglegroups.com
For more options, visit this group at http://
groups.google.co.uk/group/phpsoa?hl=en
-~----------~----~----~----~------~----~------~--~---

Rob wrote:

> I do have a question about the change though. Is there
any possibility
> that EG(uninitialized_zval_ptr) would ever be returned
for either
> value, as its probably not a good idea to be playing
around with that.
> Conceptual I wouldn't think so if you are comparing 2
SDO objects, but
> I'm not fluents in its internal workings to know for
sure.

I know how you feel - it's like building on a deck of cards
- but I'm 
not worried in this case, not because I'm certain that that
value will 
never be returned, but because I believe the internals will
do the right 
thing if it does happen. It will eventually get down to
this:

static inline void safe_free_zval_ptr_rel(zval *p
ZEND_FILE_LINE_DC 
ZEND_FILE_LINE_ORIG_DC)
{
         TSRMLS_FETCH();

         if (p!=EG(uninitialized_zval_ptr)) {
                 FREE_ZVAL_REL(p);
         }
}



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the
Google Groups "phpsoa" group.
To post to this group, send email to phpsoagooglegroups.com
To unsubscribe from this group, send email to
phpsoa-unsubscribegooglegroups.com
For more options, visit this group at http://
groups.google.co.uk/group/phpsoa?hl=en
-~----------~----~----~----~------~----~------~--~---