David Coallier (http://pear.php.net/u
ser/davidc) has commented on the proposal for Web
Services::Services_UPS.
Comment:
Well, I have to say that this can be very very usefull for
MANY people. So
let's start:
File: UPS.php
- I would set an XpciVersion as a declared variable or
$this->xpiversion
= '1.0001' (But this is just personal preference)
- As of the constructor, I would inverse it and go like:
[code=php]
// {{{ PHP5 Constructor
/**
* PHP5 Constructor
*
*  access private
*/
function __construct()
{
}
// }}}
// {{{ php4 constructor
/**
* PHP4 Constructor
*
* access private
*/
function ups()
{
$this->__construct();
}
[/code]
Else than this, I love the code, that's well coded,
comments are nice and
structured. I will defenatly use this package if it comes
out.
as of Justin's comment, that would be a good thing to look
with the other
coders who discussed about this, and if you can put a link
to this
discussion on those comments.
--D
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=187
--
Sent by PEPr, the automatic proposal system at http://pear.php.net
--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
|