Proposal for Database::DB_Table_Database

David Morse (http://pear.php.net/us
er/morse) proposes Database:B_Table_
Database.

You can find more detailed information here:
 http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

David Morse (http://pear.php.net/us
er/morse) has edited the proposal for Database:B_Table_
Database.

Change comment:

Changed directory structure and file names to the PEAR
convention,
e.g., DB/Table/Database.php. Added check for multiple
references
from one table to a single referenced table.

There are not yet any comments on the proposal. 

Please review the proposal:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

David Morse (http://pear.php.net/us
er/morse) has edited the proposal for Database:B_Table_
Database.

Change comment:

Changed directory structure and file names to the PEAR
convention,
e.g., DB/Table/Database.php. Added check for multiple
references
from one table to a single referenced table.

There are not yet any comments on the proposal. 

Please review the proposal:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

David Morse (http://pear.php.net/us
er/morse) has edited the proposal for Database:B_Table_
Database.

Change comment:

added package.xml and PEAR tarball, other minor changes

Please review the proposal:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Justin Patrin (http://pear.php
.net/user/justinpatrin) has commented on the proposal
for Database:B_Table_
Database.

Comment:

Why have "({$db->phptype})"? Just do
$db->phptype.

DB_Table is a PHP4 package. DB_Table_Database has PHP5
syntax in it but
uses PEAR_Error. I suggest removing all of the PHP5 syntax
(public/protected) to keep compatibility with PHP4 as
DB_Table is PHP4
only.

I see various comments that say that an error should be
thrown. You should
probably take care of this.

array_key_exists can be much slower than isset. If you don't
need to check
for NULL values in your arrays then isset is a better
choice.

Looks pretty good otherwise. 

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

David Morse (http://pear.php.net/us
er/morse) has commented on the proposal for
Database:B_Table_
Database.

Comment:

Justin - Thanks for the comments. I'm accepting them all.
Regarding PHP 4
compatability, it appears that the only signficant problem
is that this
will break the current implementation of the fromXML method,
which uses
simpleXML. I'll have to think about whether to just accept
the loss of the
ability to  reconstruct an object from XML for PHP 4 users,
or (perhaps
later) re-implement this with a PHP 4 parser package. The
planned PHP 5
MDB2_Table_Database class can again use simpleXML.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Hi,

I am not sure you should bother too much with php4.

Arnaud.

David Morse wrote:
> David Morse (http://pear.php.net/us
er/morse) has commented on the proposal for
Database:B_Table_
Database.
> 
> Comment:
> 
> Justin - Thanks for the comments. I'm accepting them
all. Regarding PHP 4
> compatability, it appears that the only signficant
problem is that this
> will break the current implementation of the fromXML
method, which uses
> simpleXML. I'll have to think about whether to just
accept the loss of the
> ability to  reconstruct an object from XML for PHP 4
users, or (perhaps
> later) re-implement this with a PHP 4 parser package.
The planned PHP 5
> MDB2_Table_Database class can again use simpleXML.
> 
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=456
> 

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Torsten Roehr (http://pear.php.net/u
ser/troehr) has commented on the proposal for
Database:B_Table_
Database.

Comment:

I just looked at the introductory tutorial. Is it possible
to create joins
on multiple/composite columns?

Also it looks a lot like what DB_DataObject is already
providing. Can you
maybe point out the differences between the two packages?
Thanks.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

David Morse (http://pear.php.net/us
er/morse) has commented on the proposal for
Database:B_Table_
Database.

Comment:

It is possible to join on multiple-column keys. This is true
in a
trivial sense because the select* methods allow one to enter
any 
string for the WHERE clause.  More signficantly, the
autoJoin method can
automatically generate appropriate join conditions for
multi-column
foreign key references.

I'd prefer not to attempt an explanation of the differences
between
DB_Table_Databse and DB_DataObject. Many of these arise from
differences
in the design and goals of DB_Table and DB_DataObject, which
have been
discused previously. Given that both of these classes exist
in PEAR and
have attracted users, perhaps it is sufficient to say that
DB_Table_Database adds to DB_Table various features that
require
information about the database schema and foreign key
references, some of
which have already been added to DB_DataObject. 

I do think, however, that the approach to automating
generation of join
conditions taken in the autoJoin method of DB_Table_Database
is easier to
use for multi-table joins and more powerful than that taken
in
DB_DataObject. Anyone sufficiently interested might want to
consider the 5
table join auto-generated in the tutorial for
DB_Table_Database, which
required the user to specify only the names of columns from
3 of the five
tables, and consider how that would be implemented using
DB_DataObject.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Torsten Roehr (http://pear.php.net/u
ser/troehr) has commented on the proposal for
Database:B_Table_
Database.

Comment:

David, thanks for your extensive answer. Is it possible to
create joins
with the left/right/inner/outer syntax using the ON clause
instead of
setting the joins via the where clause?

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=456

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php