I suppose this should have gone to the list also.
---------- Forwarded message ----------
From: Helgi Žormar <helgith gmail.com>
Date: Jan 16, 2007 12:25 PM
Subject: Re: new ISBN class draft
To: Tom Klingenberg <tklingenberglastflood.net>
Cc: Piotr Klaban <maklerman.torun.pl>
Hello,
unfourtunantly I don't have time at the moment to look at
this since
I'm in the middle of moving and really don't have any
internet beside
in my lunch break.
But here's my thought, this should be it's own package and
Validate_ISPN should only be about validating ISBN (well it
does more
validation but still) so I'm against moving some conversion
functions
and such into the package and thus going against what the
class really
is about.
Philippe raises a valid point and I'm somewhat for that idea
but since
Validate_ISPN is more than just ISBN then you probably
should have the
validation in your package but if you like I suppose you can
do a v2
of validate_ispn but I won't have time to help you with
that.
I'm not sure if Philippe knows this but well ... you can't
do any more
thorough validation of ISBN numbers, it's just one way or no
way ;)
Regards
Helgi
On 1/15/07, Tom Klingenberg <tklingenberglastflood.net> wrote:
> Hello Validate_ISPN maintainers,
>
> I just wanted to let you know that I'm planning to
propose an ISBN PHP
> class. It is available as Draft right now:
>
> http://pear.php.net/pepr/pepr-proposal-show.php?id=469
>
> You can read the documentation here:
> http://isbn
.lastflood.com/ric_README.html
>
> I am looking forward where to place the class into the
PEAR category tree.
> Some pplz suggested to get in contact with
Validate_ISPN mainterns (you)
> and to ask what you think of it. Then there was a
suggestion to have it as
> Strucure_ISBN and being reused by Validate_ISPN - this
would implement a
> PHP5+ version to handle my ISBN class.
>
> So what do you think? Any Feedback would be great,
because this is my
> first input to PEAR, so I'm new where to put it and how
to get in contact
> with the other developers.
>
> Best regards,
> Tom
>
> References (both should be in pear-dev mailinglist):
> by Lukas Feiler <lukasempoweredmail.com>:
> <quote>
> - IMHO most of the functionality provided by your
package could go into
> Validate_ISPN
> </quote>
>
> by Philippe Jausions <Philippe.Jausions11abacus.com>:
> <quote>
> [...] Very good indeed. What might be done is to have
the Structure_ISBN
> or Numeric_ISBN package for the conversion &
version identification, and
> reuse that package in Validate_ISPN to do more thorough
validation.
> Although it would probably be Validate2_ISPN instead
due to PHP 4 vs. 5...
> </quote>
>
--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
|