Maintainer, check your code

I make again an call to test my check code tool based on
zend Analyzer

2 things to do
- validate your pear code to grown pear quality
- give me a feed back on my tool : mooshphp.net

How to use it ?

Go to
http://130.104.58.207/~moosh/checkcode/?list=/cvs.
php.net/pear

On left you view cvs directory of pear.
Choose your package.

On right, "files". Click on php files to have a
report.

file are cvs updated on each request, so you can view your
correction in
live.

Thank you very moosh

-- 
Moosh -- claroline.net -- php.net
=====   Php  &  Pear  &  MySQL  =====
http://moosh.et.son
.brol.be/blog/ (fr)

02-2007 FOSDEM 07 http://www.fosdem.org/
(en)

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

On 24/02/07, Christophe Gesché <mooshphp.net> wrote:
> I make again an call to test my check code tool based
on zend Analyzer
>
> 2 things to do
> - validate your pear code to grown pear quality
> - give me a feed back on my tool : mooshphp.net
>
> How to use it ?
>
> Go to
> http://130.104.58.207/~moosh/checkcode/?list=/cvs.
php.net/pear
>
> On left you view cvs directory of pear.
> Choose your package.
>
> On right, "files". Click on php files to have
a report.
>
> file are cvs updated on each request, so you can view
your correction in
> live.
>
> Thank you very moosh
>
> --
> Moosh -- claroline.net -- php.net
> =====   Php  &  Pear  &  MySQL  =====
> http://moosh.et.son
.brol.be/blog/ (fr)
>
> 02-2007 FOSDEM 07 http://www.fosdem.org/
(en)
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub
.php

Very cool. The warnings seem reasonable enough. It seems to
have
become confused by
http://130.104.58.
207/~moosh/checkcode/?script=/cvs.php.net/pear/File_MARC/MAR
C/Data_Field.php
however; does it not like "array $subfields =
null" as a parameter in
a function signature?

Dan

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Am Samstag, den 24.02.2007, 20:12 +0100 schrieb Christophe
Gesché:

Hi Christophe,

> I make again an call to test my check code tool based
on zend Analyzer
> 
> 2 things to do
> - validate your pear code to grown pear quality
> - give me a feed back on my tool : mooshphp.net
> 
> How to use it ?
> 
> Go to
> http://130.104.58.207/~moosh/checkcode/?list=/cvs.
php.net/pear
> 
> On left you view cvs directory of pear.
> Choose your package.

is this tool for php5 only?

If I check my Net_IMAP, there are a lot of errors.

Some are very clear and the tool is right. I have a lot of
variables
that are used before they are assigned. Is this a problem
regarding
coding rules of pear?

There are also errors, with arguments passed by reference
that are used
inside this method to pass to another method by reference. I
see no real
error here. As example you can have a look at
IMAPProtocol.php (goto
line 2022).

I'm a little bit confused.

regards

-- 
Sebastian Ebling <s.eblingumwelt-campus.de>

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Sebastian Ebling wrote:
> Am Samstag, den 24.02.2007, 20:12 +0100 schrieb
Christophe Gesché:
> 
> Hi Christophe,
> 
>> I make again an call to test my check code tool
based on zend Analyzer
>>
>> 2 things to do
>> - validate your pear code to grown pear quality
>> - give me a feed back on my tool : mooshphp.net
>>
>> How to use it ?
>>
>> Go to
>> http://130.104.58.207/~moosh/checkcode/?list=/cvs.
php.net/pear
>>
>> On left you view cvs directory of pear.
>> Choose your package.
> 
> is this tool for php5 only?
> 
> If I check my Net_IMAP, there are a lot of errors.
> 
> Some are very clear and the tool is right. I have a lot
of variables
> that are used before they are assigned. Is this a
problem regarding
> coding rules of pear?
> 
> There are also errors, with arguments passed by
reference that are used
> inside this method to pass to another method by
reference. I see no real
> error here. As example you can have a look at
IMAPProtocol.php (goto
> line 2022).
> 
> I'm a little bit confused.

Zend Analyzer is a machine.  Use your judgement.  It is not
smart
enough, for instance, to recognize that preg_match() can
take an
uninitialized variable and create it, or that in many cases
one uses
foreach() just for the keys.

However, it helps to call unused variables
"$unused" or something like
that, and the analyzer does catch a lot of true problems. 
Just fix what
is possible to fix and makes sense to fix.

Greg

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Zitat von Gregory Beaver <gregchiaraquartet.net>:

> Sebastian Ebling wrote:
>> Am Samstag, den 24.02.2007, 20:12 +0100 schrieb
Christophe Gesché:
>>
>> Hi Christophe,
>>
>>> I make again an call to test my check code tool
based on zend Analyzer
>>>
>>> 2 things to do
>>> - validate your pear code to grown pear
quality
>>> - give me a feed back on my tool : mooshphp.net
>>>
>>> How to use it ?
>>>
>>> Go to
>>> http://130.104.58.207/~moosh/checkcode/?list=/cvs.
php.net/pear
>>>
>>> On left you view cvs directory of pear.
>>> Choose your package.

Could we add links to that from the maintainer's package
homepage? And  
maybe to these docs coverage and package.xml lists too?
Obviously only  
for packages that are on cvs.php.net, unless these tools are
converted  
to use package releases instead of cvs checkouts.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consult
ing/

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php