Proposal for Gtk2 Components::Gtk2_QuickForm

Scott Mattocks (http://pear.ph
p.net/user/scottmattocks) proposes Gtk2
Components::Gtk2_QuickForm.

You can find more detailed information here:
 http://pear.php.net/pepr/pepr-proposal-show.php?id=371

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Christian Weiske (http://pear.php.net/
user/cweiske) has commented on the proposal for Gtk2
Components::Gtk2_QuickForm.

Comment:

Looks good. The only thing I don't understand is why you
use a global
variable for the error messages and not class constants.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=371

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Thanks for the comment.

Christian Weiske wrote:
> 
> Looks good. The only thing I don't understand is why
you use a global
> variable for the error messages and not class
constants.

Class constants can't be arrays. It could probably be a
static class 
variable but the global error array keeps in line with the
"PEAR way".

> 
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=371
> 

-- 
Scott Mattocks
http://www.crisscott.com

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Justin Patrin (http://pear.php
.net/user/justinpatrin) has commented on the proposal
for Gtk2 Components::Gtk2_QuickForm.

Comment:

This could be useful for FormBuilder. 

Use PEAR_Exception.

User is_callable instead of is_null to check callbacks.

If you feel you need isIncludable (this is debatable as when
an include
doesn't happen the developer should see it and deal with it
anyway) then
use file_exists before is_readable and don't silence the
call. (Note that
this can fail with safe_mode, if you care. See LiveUser or
MDB2's bugs for
more.)

I don't really have the time to look at any more tonight
(there's lots of
code here). It does look like you've started a generic form
package,
though. I would suggest that you make this a QuickForm base
package and a
GTK2 renderer package. This was we can have different
frontends. 

You may also want to cooperate with the HTML_QuickForm
people or at least
check out some of the discussions that have happend about
the next version
of it so that you can implement some of the ideas that were
brought up.
There is also a wiki with some thoughts about the next
version of
QuickForm somewhere.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=371

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Justin Patrin wrote:

>
>Justin Patrin (http://pear.php
.net/user/justinpatrin) has commented on the 
>proposal for Gtk2 Components::Gtk2_QuickForm.
>
>Comment:
>
>This could be useful for FormBuilder. 
>
>Use PEAR_Exception.
>
>User is_callable instead of is_null to check callbacks.
>
>If you feel you need isIncludable (this is debatable as
when an include
>doesn't happen the developer should see it and deal
with it anyway) then
>use file_exists before is_readable and don't silence
the call. (Note that
>this can fail with safe_mode, if you care. See LiveUser
or MDB2's bugs for
>more.)
>
>I don't really have the time to look at any more
tonight (there's lots of
>code here). It does look like you've started a generic
form package,
>though. I would suggest that you make this a QuickForm
base package and a
>GTK2 renderer package. This was we can have different
frontends. 
>
>You may also want to cooperate with the HTML_QuickForm
people or at least
>check out some of the discussions that have happend
about the next version
>of it so that you can implement some of the ideas that
were brought up.
>There is also a wiki with some thoughts about the next
version of
>QuickForm somewhere.

Gtk2_QuickForm could certainly have a life on its own. I'd
rather name it simply
Gtk2_Form to avoid the confusion since it's not tied to
HTML_QuickForm.

As Justin suggested for your ErrorStack troubles, I'd also
suggest that you
simply use PHP5 Exceptions, it's much simpler (BTW, I found
references to
Exeception in your code, instead of Exception, please fix
it).

About the next version of QuickForm, I have some good ideas
and I think it could
be ready this year. But I can't promise it's going to do
more than (X)HTML.

Scott, as you know QuickForm and wrote Gtk2_QuickForm, what
do you think is
missing or bad in QuickForm and could be improved in the
next version (besides
autoload() ;) ) ?

-- 
Bertrand Mansion
http://www.mamasam.com 
    - creative internet solutions
http://golgote.freeflux.n
et - blog

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Note: I haven't uploaded any changes yet because I have
some questions 
still.

Justin Patrin wrote:
> 
> Use PEAR_Exception.

Done.

> 
> User is_callable instead of is_null to check callbacks.

Done.

> 
> If you feel you need isIncludable (this is debatable as
when an include
> doesn't happen the developer should see it and deal
with it anyway) then
> use file_exists before is_readable and don't silence
the call. (Note that
> this can fail with safe_mode, if you care. See LiveUser
or MDB2's bugs for
> more.)

isIncludable is needed to catch errors before they become a
problem. If 
the file can't be included I don't want developers to be
able to add an 
element of that type. The fact that the file isn't there
isn't such a 
big deal. I just want to prevent bad things from happening
later. I 
updated the method to use file_exists first.

> 
> I don't really have the time to look at any more
tonight (there's lots of
> code here). It does look like you've started a generic
form package,
> though. I would suggest that you make this a QuickForm
base package and a
> GTK2 renderer package. This was we can have different
frontends. 

What category would you suggest the form package be under?
The closest 
fit I can see is Structures but I am not sure if that really
works. If 
that is the best fit, I will delete the current proposal and
create two 
new ones: Structures_Form and Structures_Form_Gtk2. The Gtk2
package 
will contain the Gtk2 elements and renderer. The rest (the
base class, 
interfaces and rules) will be left in the Structures_Form
package.

> 
> You may also want to cooperate with the HTML_QuickForm
people or at least
> check out some of the discussions that have happend
about the next version
> of it so that you can implement some of the ideas that
were brought up.
> There is also a wiki with some thoughts about the next
version of
> QuickForm somewhere.

Can someone please tell me how to join in on this discussion
or at least 
what mailing list to lurk in?

> 
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=371
> 

Thanks,
-- 
Scott Mattocks
http://www.crisscott.com

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

On 3/17/06, Scott Mattocks <scottcrisscott.com> wrote:
> Note: I haven't uploaded any changes yet because I
have some questions
> still.
>
> Justin Patrin wrote:
> >
> > Use PEAR_Exception.
>
> Done.
>
> >
> > User is_callable instead of is_null to check
callbacks.
>
> Done.
>
> >
> > If you feel you need isIncludable (this is
debatable as when an include
> > doesn't happen the developer should see it and
deal with it anyway) then
> > use file_exists before is_readable and don't
silence the call. (Note that
> > this can fail with safe_mode, if you care. See
LiveUser or MDB2's bugs for
> > more.)
>
> isIncludable is needed to catch errors before they
become a problem. If
> the file can't be included I don't want developers to
be able to add an
> element of that type. The fact that the file isn't
there isn't such a
> big deal. I just want to prevent bad things from
happening later. I
> updated the method to use file_exists first.
>
> >
> > I don't really have the time to look at any more
tonight (there's lots of
> > code here). It does look like you've started a
generic form package,
> > though. I would suggest that you make this a
QuickForm base package and a
> > GTK2 renderer package. This was we can have
different frontends. 
>
> What category would you suggest the form package be
under? The closest
> fit I can see is Structures but I am not sure if that
really works. If
> that is the best fit, I will delete the current
proposal and create two
> new ones: Structures_Form and Structures_Form_Gtk2. The
Gtk2 package
> will contain the Gtk2 elements and renderer. The rest
(the base class,
> interfaces and rules) will be left in the
Structures_Form package.
>

Structures would make sense to me seeing as that's where a
similar
package is now (Structures_DataGrid).

> >
> > You may also want to cooperate with the
HTML_QuickForm people or at least
> > check out some of the discussions that have
happend about the next version
> > of it so that you can implement some of the ideas
that were brought up.
> > There is also a wiki with some thoughts about the
next version of
> > QuickForm somewhere.
>
> Can someone please tell me how to join in on this
discussion or at least
> what mailing list to lurk in?
>

I suggest checking the pear-dev and pear-general mailing
list
archives. Unfortunately I'm not sure of the specific
threads and such
this all may have been under. There were a few wiki pages
up, but they
seem to have been taken down for some reason. You can still
see them
in the Google Cache.
http://www.google.com/search?hl=e
n&lr=&q=QuickForm4Wiki&btnG=Search

--
Justin Patrin

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Scott Mattocks (http://pear.ph
p.net/user/scottmattocks) has deleted the proposal for
Gtk2 Components::Gtk2_QuickForm.

The reason for that is:

Replaced by Structures_Form

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php