List Info

Thread: Re: Regarding HTTP_Request bug #10790




Re: Regarding HTTP_Request bug #10790
user name
2007-05-02 15:24:31
Hi,

Bill Moran wrote:
>> Have you tested the fix in question? I don't have a
64-bit box around, so will 
>> have to rely on someone else testing it.
> 
> funny you should mention that, because it' _doesn't_
work.
> 
> After some banging around, I have a fix that _does_
work:
> 
> 1390c1390
> <         } elseif ($dataCrc != crc32($unpacked)) {
> ---
>>         } elseif ((0xffffffff & $dataCrc) !=
(0xffffffff & crc32($unpacked))) {
> 
> We've been banging on this on one of our 64-bit FreeBSD
systems, and it's
> working flawlessly.  Oddly, it doesn't seem as if any
change is needed to
> the header check portion.

Thanks a lot for testing and for a working solution!

As for the header, only 16 bits of crc32() value are used
for header check, so 
there can be no similar problems.

>> And yes, I'm going to do a bugfix release sometime
soon, but will need to fix 
>> #10605 also and revisit the gzip vs. mb_*() changes
done sometime ago.
> 
> Good to know.  Let me know if I can be any more help on
this one.

Thanks, I think I'll be able to handle this myself, enabling
mbstring extension 
for testing is easier than finding a 64-bit box. 

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php


[1]

about | contact  Other archives ( Real Estate discussion Medical topics )