List Info

Thread: PHP_CodeSniffer as part of the pepr proposal process
PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-06 03:12:10 
I just spied this in another thread, and thought, "of
course", how obvious.

> Waiting to comment until the voting phase isn't how the
system is
> > supposed to work.
>
> I think there is a big gap between how the system is
supposed to work and
> how it
> works:
> 1) People put packages up for public criticism then act
all offended when
> they
> receive said criticism.
> 2) Lots of developers only complain about docblocks /
licenses / CS. A bot
> can
> be written that will do exactly the same! People are
either unwilling to
> look
> into the actual workings of the package or unwilling to
"offend" their
> fellow
> developers.
>
> Thus me keeping my comments for "easily
offended" developers until the
> voting
> phase won't make this gap *much* wider, I suppose...



How difficult would it be to provide:

   1. really clear directions on installing and running
PHP_CodeSniffer
   over your proprosal
   2. (and most desirable) the ability for a proposal (phps;
or archive)
   to be evaluated automatically with PHP_CodeSniffer
against PEAR standards
   before allowing a package to go from proposed to call for
votes (or whatever
   stage you want to put it at)?




-- 
By a factor of three, what you do is not nearly as important
as how it makes
people feel; so why do you spend almost all your time on the
wrong thing?
Re: PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-06 05:01:44 
Daniel O'Connor wrote:
> How difficult would it be to provide:
>
>   1. really clear directions on installing and running
PHP_CodeSniffer
>   over your proprosal
>   2. (and most desirable) the ability for a proposal
(phps; or archive)
>   to be evaluated automatically with PHP_CodeSniffer
against PEAR 
> standards
>   before allowing a package to go from proposed to call
for votes (or 
> whatever
>   stage you want to put it at)?
I'll let someone who knows PEPr comment on how easy this
would be, but I 
thought I'd show the output of PHP_CodeSniffer on
PHP_Callback so people 
can see some sample output. All the errors relate to
commenting in this 
case and so are fairly picky.

Greg

------------------------------------------------------------
-------------------- 

FOUND 29 ERROR(S) AND 1 WARNING(S) AFFECTING 21 LINE(S)
------------------------------------------------------------
-------------------- 

 20 | ERROR   | There must be exactly one blank line before
the tags in 
file
    |         | comment
 22 | ERROR   | category tag comment indented incorrectly.
Expected 2 
spaces
    |         | but found 1.
 23 | ERROR   | package tag comment indented incorrectly.
Expected 3 
spaces
    |         | but found 1.
 24 | ERROR   | Content of the author tag must be in the
form "Display 
Name
    |         | <usernameexample.com>"
 24 | ERROR   | author tag comment indented incorrectly.
Expected 4 
spaces but
    |         | found 1.
 26 | ERROR   | license tag comment indented incorrectly.
Expected 3 
spaces
    |         | but found 1.
 27 | WARNING | Invalid version "VERSION" in
file comment; Consider 
"CVS:
    |         | <cvs_id>" instead.
 27 | ERROR   | version tag comment indented incorrectly.
Expected 3 
spaces
    |         | but found 1.
 29 | ERROR   | Missing link tag in file comment
 76 | ERROR   | There must be exactly one blank line before
the tags in 
file
    |         | comment
 78 | ERROR   | category tag comment indented incorrectly.
Expected 2 
spaces
    |         | but found 1.
 79 | ERROR   | package tag comment indented incorrectly.
Expected 3 
spaces
    |         | but found 1.
 80 | ERROR   | Content of the author tag must be in the
form "Display 
Name
    |         | <usernameexample.com>"
 80 | ERROR   | author tag comment indented incorrectly.
Expected 4 
spaces but
    |         | found 1.
 81 | ERROR   | The order of version tag is wrong in
class comment
 81 | ERROR   | version tag comment indented incorrectly.
Expected 3 
spaces
    |         | but found 1.
 83 | ERROR   | license tag comment indented incorrectly.
Expected 3 
spaces
    |         | but found 1.
 84 | ERROR   | since tag comment indented incorrectly.
Expected 5 
spaces but
    |         | found 1.
 86 | ERROR   | Missing link tag in class comment
 92 | ERROR   | Doc comment for "$callback"
missing
 92 | ERROR   | Doc comment for "$p2" missing
134 | ERROR   | Doc comment var "[ UNKNOWN ]" does
not match actual 
variable
    |         | name "$parameter" at position 1
134 | ERROR   | Missing parameter name at position 1
134 | ERROR   | Missing comment for param "[ UNKNOWN
]" at position 1
137 | ERROR   | Missing return tag in function
comment
146 | ERROR   | Doc comment var "[ UNKNOWN ]" does
not match actual 
variable
    |         | name "&$parameter" at position
1
146 | ERROR   | Missing parameter name at position 1
146 | ERROR   | Missing comment for param "[ UNKNOWN
]" at position 1
149 | ERROR   | Missing return tag in function
comment
159 | ERROR   | Missing return tag in function
comment
------------------------------------------------------------
-------------------- 

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
Re: PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-06 12:09:30 
Greg Sherwood wrote:
> Daniel O'Connor wrote:
>> How difficult would it be to provide:
>>
>>   1. really clear directions on installing and
running PHP_CodeSniffer
>>   over your proprosal
>>   2. (and most desirable) the ability for a
proposal (phps; or archive)
>>   to be evaluated automatically with
PHP_CodeSniffer against PEAR
>> standards
>>   before allowing a package to go from proposed to
call for votes (or
>> whatever
>>   stage you want to put it at)?
> I'll let someone who knows PEPr comment on how easy
this would be, but I
> thought I'd show the output of PHP_CodeSniffer on
PHP_Callback so people
> can see some sample output. All the errors relate to
commenting in this
> case and so are fairly picky.
> 
> Greg

Hi Greg,

I would be interested in investigating setting up
codesniffer as a cron
job for checking PEPr proposals.  I'm assuming it would time
out if used
to check a large proposal.  Have you tried it on something
vast like
phpDocumentor?

Thanks,
Greg

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
Re: PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-06 17:21:11 
Gregory Beaver wrote:
> I would be interested in investigating setting up
codesniffer as a cron
> job for checking PEPr proposals.  I'm assuming it would
time out if used
> to check a large proposal.  Have you tried it on
something vast like
> phpDocumentor?
>   
I just got a new version of phpDocumentor from PEAR, but all
the 
newlines are /r/n, which causes a significant amount of
errors, That 
might be an issue in itself for PEAR.

I'll get rid of those errors and give it a run when I get
time. First 
impressions are that PHP_CodeSniffer doesn't like some of
the code, so 
I'll look into why and fix any errors I find.
PHP_CodeSniffer has been 
tested on PHP5 code much more than PHP4, so it's possible
that it's 
looking for a keyword somewhere that doesn't exist.

If anyone has the time to run PHP_CodeSniffer on your own
package, 
please let me know any issues you find. Thanks to all the
PEAR devs who 
have already submitted reports.

Greg

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
Re: PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-07 02:43:32 
Hi,

Greg Sherwood wrote:
> Gregory Beaver wrote:
>> I would be interested in investigating setting up
codesniffer as a cron
>> job for checking PEPr proposals.  I'm assuming it
would time out if used
>> to check a large proposal.  Have you tried it on
something vast like
>> phpDocumentor?
>>   
> I just got a new version of phpDocumentor from PEAR,
but all the 
> newlines are /r/n, which causes a significant amount of
errors, That 
> might be an issue in itself for PEAR.
> 
> I'll get rid of those errors and give it a run when I
get time. First 
> impressions are that PHP_CodeSniffer doesn't like some
of the code, so 
> I'll look into why and fix any errors I find.

Running PHP_CodeSniffer on phpDocumentor might not be a good
idea, as
there are many CS violations like wrong placed or missing
curly braces,
never-ending lines (*g*), wrong file extensions etc.
(No offense against the phpDocumentor people, this might be
an historial
issue because the package wasn't born in PEAR.)

Testing it on another big package like MDB2 might be more
reasonable
because it should output better results, and because even
package with
sizes like on MDB2 are very rarely proposed (IIRC never
yet).

Regards,
Mark

-- 
http://www.markwiesemann.
eu

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
Re: PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-07 18:16:44 
Mark Wiesemann wrote:
> Running PHP_CodeSniffer on phpDocumentor might not be a
good idea, as
> there are many CS violations like wrong placed or
missing curly braces,
> never-ending lines (*g*), wrong file extensions etc
I think you're right there, but I did it anyway. I ran it on
most of the 
files and did change their end of line char from rn to n
to stop 
several hundred errors, but I have not verified that these
errors are 
all correct for obvious reasons.

The error summary report is below. If you are interested in
how big the 
files were, that report follows the summary report. The
processing times 
are slow as this is running on my PowerBook G4.

Greg

PHP CODE SNIFFER REPORT SUMMARY
------------------------------------------------------------
--------------------
FILE                                                        
   ERRORS  
WARNINGS
------------------------------------------------------------
--------------------
/sw/lib/php/PhpDocumentor/phpDocumentor/Classes.inc         
   275     78
/sw/lib/php/PhpDocumentor/phpDocumentor/clone.inc.php       
   11      3
/sw/lib/php/PhpDocumentor/phpDocumentor/clone5.inc.php      
   11      3
/sw/lib/php/PhpDocumentor/phpDocumentor/common.inc.php      
   106     9
/sw/lib/php/PhpDocumentor/phpDocumentor/Converter.inc       
   1746    599
...hpDocumentor/Converters/CHM/default/CHMdefaultConverter.i
nc  788     216
...hpDocumentor/Converters/HTML/frames/HTMLframesConverter.i
nc  737     217
...hpDocumentor/Converters/HTML/Smarty/HTMLSmartyConverter.i
nc  755     211
...mentor/phpDocumentor/Converters/PDF/default/class.ezpdf.p
hp  1627    152
...cumentor/phpDocumentor/Converters/PDF/default/class.pdf.p
hp  3749    211
...or/phpDocumentor/Converters/PDF/default/class.phpdocpdf.p
hp  163     35
...cumentor/phpDocumentor/Converters/PDF/default/ParserPDF.i
nc  153     53
...hpDocumentor/Converters/PDF/default/PDFdefaultConverter.i
nc  472     96
...hpDocumentor/Converters/XML/DocBook/peardoc2/Beautifier.p
hp  40      6
...tor/phpDocumentor/Converters/XML/DocBook/peardoc2/Plain.p
hp  67      23
...phpDocumentor/Converters/XML/DocBook/peardoc2/Tokenizer.p
hp  207     25
...erters/XML/DocBook/peardoc2/XMLDocBookpeardoc2Converter.i
nc  631     201
...hpDocumentor/Converters/XML/DocBook/XMLDocBookConverter.i
nc  707     323
/sw/lib/php/PhpDocumentor/phpDocumentor/DescHTML.inc        
   129     3
/sw/lib/php/PhpDocumentor/phpDocumentor/DocBlock/Lexer.inc  
   239     106
/sw/lib/php/PhpDocumentor/phpDocumentor/DocBlockTags.inc    
   374     39
/sw/lib/php/PhpDocumentor/phpDocumentor/Errors.inc          
   212     107
/sw/lib/php/PhpDocumentor/phpDocumentor/EventStack.inc      
   24      1
/sw/lib/php/PhpDocumentor/phpDocumentor/find_phpdoc.php     
   12      0
/sw/lib/php/PhpDocumentor/phpDocumentor/HighlightParser.inc 
   569     198
/sw/lib/php/PhpDocumentor/phpDocumentor/InlineTags.inc      
   287     47
/sw/lib/php/PhpDocumentor/phpDocumentor/IntermediateParser.i
nc  488     125
/sw/lib/php/PhpDocumentor/phpDocumentor/Io.inc              
   303     119
/sw/lib/php/PhpDocumentor/phpDocumentor/LinkClasses.inc     
   123     10
...lib/php/PhpDocumentor/phpDocumentor/PackagePageElements.i
nc  151     9
/sw/lib/php/PhpDocumentor/phpDocumentor/Parser.inc          
   996     381
/sw/lib/php/PhpDocumentor/phpDocumentor/ParserData.inc      
   206     33
/sw/lib/php/PhpDocumentor/phpDocumentor/ParserDescCleanup.in
c   331     102
/sw/lib/php/PhpDocumentor/phpDocumentor/ParserDocBlock.inc  
   370     58
/sw/lib/php/PhpDocumentor/phpDocumentor/ParserElements.inc  
   797     159
/sw/lib/php/PhpDocumentor/phpDocumentor/phpdoc.inc          
   19      2
...ib/php/PhpDocumentor/phpDocumentor/phpDocumentorTParser.i
nc  749     204
...hp/PhpDocumentor/phpDocumentor/phpDocumentorTWordParser.i
nc  78      21
/sw/lib/php/PhpDocumentor/phpDocumentor/ProceduralPages.inc 
   208     70
/sw/lib/php/PhpDocumentor/phpDocumentor/Publisher.inc       
   49      3
/sw/lib/php/PhpDocumentor/phpDocumentor/Setup.inc.php       
   314     73
...entor/phpDocumentor/Smarty-2.6.0/libs/Config_File.class.p
hp  89      21
...or/Smarty-2.6.0/libs/core/core.assemble_plugin_filepath.p
hp  21      4
...tor/Smarty-2.6.0/libs/core/core.assign_smarty_interface.p
hp  20      5
...mentor/Smarty-2.6.0/libs/core/core.create_dir_structure.p
hp  21      7
...entor/Smarty-2.6.0/libs/core/core.display_debug_console.p
hp  18      4
...Documentor/Smarty-2.6.0/libs/core/core.get_include_path.p
hp  15      3
...phpDocumentor/Smarty-2.6.0/libs/core/core.get_microtime.p
hp  9       1
...Documentor/Smarty-2.6.0/libs/core/core.get_php_resource.p
hp  36      11
...tor/phpDocumentor/Smarty-2.6.0/libs/core/core.is_secure.p
hp  17      1
...or/phpDocumentor/Smarty-2.6.0/libs/core/core.is_trusted.p
hp  14      3
.../phpDocumentor/Smarty-2.6.0/libs/core/core.load_plugins.p
hp  30      10
...mentor/Smarty-2.6.0/libs/core/core.load_resource_plugin.p
hp  19      6
...ntor/Smarty-2.6.0/libs/core/core.process_cached_inserts.p
hp  25      9
...or/Smarty-2.6.0/libs/core/core.process_compiled_include.p
hp  13      4
...pDocumentor/Smarty-2.6.0/libs/core/core.read_cache_file.p
hp  25      14
...entor/phpDocumentor/Smarty-2.6.0/libs/core/core.rm_auto.p
hp  21      6
...umentor/phpDocumentor/Smarty-2.6.0/libs/core/core.rmdir.p
hp  25      4
...cumentor/Smarty-2.6.0/libs/core/core.run_insert_handler.p
hp  27      15
...cumentor/Smarty-2.6.0/libs/core/core.smarty_include_php.p
hp  15      5
...Documentor/Smarty-2.6.0/libs/core/core.write_cache_file.p
hp  19      11
...ntor/Smarty-2.6.0/libs/core/core.write_compiled_include.p
hp  18      4
...tor/Smarty-2.6.0/libs/core/core.write_compiled_resource.p
hp  19      4
...or/phpDocumentor/Smarty-2.6.0/libs/core/core.write_file.p
hp  19      2
...tor/phpDocumentor/Smarty-2.6.0/libs/plugins/block.strip.p
hp  22      2
...hpDocumentor/Smarty-2.6.0/libs/plugins/block.textformat.p
hp  63      11
...phpDocumentor/Smarty-2.6.0/libs/plugins/function.assign.p
hp  17      2
...or/Smarty-2.6.0/libs/plugins/function.assign_debug_info.p
hp  15      1
...cumentor/Smarty-2.6.0/libs/plugins/function.config_load.p
hp  83      22
...hpDocumentor/Smarty-2.6.0/libs/plugins/function.counter.p
hp  37      1
.../phpDocumentor/Smarty-2.6.0/libs/plugins/function.cycle.p
hp  36      7
.../phpDocumentor/Smarty-2.6.0/libs/plugins/function.debug.p
hp  20      4
...r/phpDocumentor/Smarty-2.6.0/libs/plugins/function.eval.p
hp  20      1
.../phpDocumentor/Smarty-2.6.0/libs/plugins/function.fetch.p
hp  233     17
...ntor/Smarty-2.6.0/libs/plugins/function.html_checkboxes.p
hp  86      17
...ocumentor/Smarty-2.6.0/libs/plugins/function.html_image.p
hp  56      26
...umentor/Smarty-2.6.0/libs/plugins/function.html_options.p
hp  83      17
...cumentor/Smarty-2.6.0/libs/plugins/function.html_radios.p
hp  84      19
...tor/Smarty-2.6.0/libs/plugins/function.html_select_date.p
hp  80      36
...tor/Smarty-2.6.0/libs/plugins/function.html_select_time.p
hp  40      37
...ocumentor/Smarty-2.6.0/libs/plugins/function.html_table.p
hp  30      16
...phpDocumentor/Smarty-2.6.0/libs/plugins/function.mailto.p
hp  88      8
...r/phpDocumentor/Smarty-2.6.0/libs/plugins/function.math.p
hp  39      5
.../phpDocumentor/Smarty-2.6.0/libs/plugins/function.popup.p
hp  122     6
...ocumentor/Smarty-2.6.0/libs/plugins/function.popup_init.p
hp  23      4
...pDocumentor/Smarty-2.6.0/libs/plugins/function.var_dump.p
hp  11      1
...ocumentor/Smarty-2.6.0/libs/plugins/modifier.capitalize.p
hp  13      2
...or/phpDocumentor/Smarty-2.6.0/libs/plugins/modifier.cat.p
hp  16      3
...tor/Smarty-2.6.0/libs/plugins/modifier.count_characters.p
hp  16      1
...tor/Smarty-2.6.0/libs/plugins/modifier.count_paragraphs.p
hp  12      1
...ntor/Smarty-2.6.0/libs/plugins/modifier.count_sentences.p
hp  12      1
...cumentor/Smarty-2.6.0/libs/plugins/modifier.count_words.p
hp  13      1
...cumentor/Smarty-2.6.0/libs/plugins/modifier.date_format.p
hp  28      2
...ntor/Smarty-2.6.0/libs/plugins/modifier.debug_print_var.p
hp  29      7
...hpDocumentor/Smarty-2.6.0/libs/plugins/modifier.default.p
hp  15      1
...phpDocumentor/Smarty-2.6.0/libs/plugins/modifier.escape.p
hp  43      2
...umentor/Smarty-2.6.0/libs/plugins/modifier.htmlentities.p
hp  9       1
...phpDocumentor/Smarty-2.6.0/libs/plugins/modifier.indent.p
hp  24      1
.../phpDocumentor/Smarty-2.6.0/libs/plugins/modifier.lower.p
hp  13      1
.../phpDocumentor/Smarty-2.6.0/libs/plugins/modifier.nl2br.p
hp  12      3
...umentor/Smarty-2.6.0/libs/plugins/modifier.rawurlencode.p
hp  9       1
...mentor/Smarty-2.6.0/libs/plugins/modifier.regex_replace.p
hp  19      1
...hpDocumentor/Smarty-2.6.0/libs/plugins/modifier.replace.p
hp  18      1
...hpDocumentor/Smarty-2.6.0/libs/plugins/modifier.spacify.p
hp  15      1
...mentor/Smarty-2.6.0/libs/plugins/modifier.string_format.p
hp  15      1
.../phpDocumentor/Smarty-2.6.0/libs/plugins/modifier.strip.p
hp  16      3
...ocumentor/Smarty-2.6.0/libs/plugins/modifier.strip_tags.p
hp  16      1
...pDocumentor/Smarty-2.6.0/libs/plugins/modifier.truncate.p
hp  25      1
.../phpDocumentor/Smarty-2.6.0/libs/plugins/modifier.upper.p
hp  13      1
...pDocumentor/Smarty-2.6.0/libs/plugins/modifier.wordwrap.p
hp  28      1
...r/Smarty-2.6.0/libs/plugins/outputfilter.trimwhitespace.p
hp  31      11
...r/Smarty-2.6.0/libs/plugins/shared.escape_special_chars.p
hp  17      3
...umentor/Smarty-2.6.0/libs/plugins/shared.make_timestamp.p
hp  29      2
...Documentor/phpDocumentor/Smarty-2.6.0/libs/Smarty.class.p
hp  526     123
...r/phpDocumentor/Smarty-2.6.0/libs/Smarty_Compiler.class.p
hp  570     305
...php/PhpDocumentor/phpDocumentor/TutorialHighlightParser.i
nc  137     26
/sw/lib/php/PhpDocumentor/phpDocumentor/WordParser.inc      
   76      14
...ib/php/PhpDocumentor/phpDocumentor/XMLpackagePageParser.i
nc  149     41
------------------------------------------------------------
--------------------
A TOTAL OF 23060 ERROR(S) AND 5309 WARNING(S) WERE FOUND IN
118 FILE(S)
------------------------------------------------------------
--------------------


Processing Classes.inc [7092 tokens in 1136 lines]... DONE
in 4 seconds 
(275 errors, 78 warnings)
Processing clone.inc.php [27 tokens in 13 lines]... DONE in
< 1 second 
(11 errors, 3 warnings)
Processing clone5.inc.php [30 tokens in 14 lines]... DONE in
< 1 second 
(11 errors, 3 warnings)
Processing common.inc.php [1552 tokens in 259 lines]... DONE
in < 1 
second (106 errors, 9 warnings)
Processing Converter.inc [40524 tokens in 5421 lines]...
DONE in 39 
seconds (1746 errors, 599 warnings)
Processing CHMdefaultConverter.inc [14830 tokens in 1899
lines]... DONE 
in 10 seconds (788 errors, 216 warnings)
Processing HTMLframesConverter.inc [14842 tokens in 1914
lines]... DONE 
in 9 seconds (737 errors, 217 warnings)
Processing HTMLSmartyConverter.inc [15760 tokens in 1966
lines]... DONE 
in 11 seconds (755 errors, 211 warnings)
Processing class.ezpdf.php [13789 tokens in 1571 lines]...
DONE in 4 
seconds (1627 errors, 152 warnings)
Processing class.pdf.php [24183 tokens in 3075 lines]...
DONE in 21 
seconds (3749 errors, 211 warnings)
Processing class.phpdocpdf.php [2668 tokens in 353 lines]...
DONE in 3 
seconds (163 errors, 35 warnings)
Processing ParserPDF.inc [4125 tokens in 564 lines]... DONE
in 3 seconds 
(153 errors, 53 warnings)
Processing PDFdefaultConverter.inc [8401 tokens in 975
lines]... DONE in 
8 seconds (472 errors, 96 warnings)
Processing Beautifier.php [550 tokens in 135 lines]... DONE
in < 1 
second (40 errors, 6 warnings)
Processing Plain.php [1646 tokens in 250 lines]... DONE in 2
seconds (67 
errors, 23 warnings)
Processing Tokenizer.php [4473 tokens in 752 lines]... DONE
in 4 seconds 
(207 errors, 25 warnings)
Processing XMLDocBookpeardoc2Converter.inc [13016 tokens in
1702 
lines]... DONE in 13 seconds (631 errors, 201 warnings)
Processing XMLDocBookConverter.inc [16322 tokens in 1792
lines]... DONE 
in 16 seconds (707 errors, 323 warnings)
Processing DescHTML.inc [988 tokens in 256 lines]... DONE in
1 second 
(129 errors, 3 warnings)
Processing Lexer.inc [7316 tokens in 701 lines]... DONE in 5
seconds 
(239 errors, 106 warnings)
Processing DocBlockTags.inc [4758 tokens in 1002 lines]...
DONE in 3 
seconds (374 errors, 39 warnings)
Processing Errors.inc [3646 tokens in 838 lines]... DONE in
3 seconds 
(212 errors, 107 warnings)
Processing EventStack.inc [206 tokens in 89 lines]... DONE
in < 1 second 
(24 errors, 1 warnings)
Processing find_phpdoc.php [58 tokens in 45 lines]... DONE
in 1 second 
(12 errors, 0 warnings)
Processing HighlightParser.inc [17406 tokens in 2384
lines]... DONE in 
18 seconds (569 errors, 198 warnings)
Processing InlineTags.inc [4874 tokens in 869 lines]... DONE
in 3 
seconds (287 errors, 47 warnings)
Processing IntermediateParser.inc [12315 tokens in 1903
lines]... DONE 
in 12 seconds (488 errors, 125 warnings)
Processing Io.inc [6976 tokens in 920 lines]... DONE in 6
seconds (303 
errors, 119 warnings)
Processing LinkClasses.inc [732 tokens in 220 lines]... DONE
in 1 second 
(123 errors, 10 warnings)
Processing PackagePageElements.inc [1926 tokens in 405
lines]... DONE in 
1 second (151 errors, 9 warnings)
Processing Parser.inc [26476 tokens in 3209 lines]... DONE
in 22 seconds 
(996 errors, 381 warnings)
Processing ParserData.inc [3739 tokens in 781 lines]... DONE
in 2 
seconds (206 errors, 33 warnings)
Processing ParserDescCleanup.inc [11213 tokens in 1476
lines]... DONE in 
6 seconds (331 errors, 102 warnings)
Processing ParserDocBlock.inc [6445 tokens in 1176 lines]...
DONE in 6 
seconds (370 errors, 58 warnings)
Processing ParserElements.inc [14376 tokens in 2287
lines]... DONE in 8 
seconds (797 errors, 159 warnings)
Processing phpdoc.inc [193 tokens in 62 lines]... DONE in
< 1 second (19 
errors, 2 warnings)
Processing phpDocumentorTParser.inc [21003 tokens in 2709
lines]... DONE 
in 14 seconds (749 errors, 204 warnings)
Processing phpDocumentorTWordParser.inc [1633 tokens in 324
lines]... 
DONE in 2 seconds (78 errors, 21 warnings)
Processing ProceduralPages.inc [5254 tokens in 796 lines]...
DONE in 2 
seconds (208 errors, 70 warnings)
Processing Publisher.inc [279 tokens in 92 lines]... DONE in
1 second 
(49 errors, 3 warnings)
Processing Setup.inc.php [6343 tokens in 872 lines]... DONE
in 4 seconds 
(314 errors, 73 warnings)
Processing Config_File.class.php [2132 tokens in 365
lines]... DONE in 2 
seconds (89 errors, 21 warnings)
Processing core.assemble_plugin_filepath.php [346 tokens in
62 lines]... 
DONE in < 1 second (21 errors, 4 warnings)
Processing core.assign_smarty_interface.php [228 tokens in
43 lines]... 
DONE in < 1 second (20 errors, 5 warnings)
Processing core.create_dir_structure.php [557 tokens in 79
lines]... 
DONE in 1 second (21 errors, 7 warnings)
Processing core.display_debug_console.php [307 tokens in 60
lines]... 
DONE in < 1 second (18 errors, 4 warnings)
Processing core.get_include_path.php [208 tokens in 44
lines]... DONE in 
< 1 second (15 errors, 3 warnings)
Processing core.get_microtime.php [90 tokens in 23 lines]...
DONE in 1 
second (9 errors, 1 warnings)
Processing core.get_php_resource.php [564 tokens in 80
lines]... DONE in 
< 1 second (36 errors, 11 warnings)
Processing core.is_secure.php [371 tokens in 59 lines]...
DONE in 1 
second (17 errors, 1 warnings)
Processing core.is_trusted.php [273 tokens in 50 lines]...
DONE in < 1 
second (14 errors, 3 warnings)
Processing core.load_plugins.php [768 tokens in 125
lines]... DONE in < 
1 second (30 errors, 10 warnings)
Processing core.load_resource_plugin.php [441 tokens in 74
lines]... 
DONE in 1 second (19 errors, 6 warnings)
Processing core.process_cached_inserts.php [577 tokens in 71
lines]... 
DONE in < 1 second (25 errors, 9 warnings)
Processing core.process_compiled_include.php [133 tokens in
32 lines]... 
DONE in < 1 second (13 errors, 4 warnings)
Processing core.read_cache_file.php [894 tokens in 111
lines]... DONE in 
1 second (25 errors, 14 warnings)
Processing core.rm_auto.php [552 tokens in 71 lines]... DONE
in < 1 
second (21 errors, 6 warnings)
Processing core.rmdir.php [359 tokens in 55 lines]... DONE
in 1 second 
(25 errors, 4 warnings)
Processing core.run_insert_handler.php [616 tokens in 71
lines]... DONE 
in < 1 second (27 errors, 15 warnings)
Processing core.smarty_include_php.php [287 tokens in 50
lines]... DONE 
in < 1 second (15 errors, 5 warnings)
Processing core.write_cache_file.php [504 tokens in 73
lines]... DONE in 
1 second (19 errors, 11 warnings)
Processing core.write_compiled_include.php [325 tokens in 59
lines]... 
DONE in < 1 second (18 errors, 4 warnings)
Processing core.write_compiled_resource.php [222 tokens in
37 lines]... 
DONE in < 1 second (19 errors, 4 warnings)
Processing core.write_file.php [265 tokens in 48 lines]...
DONE in < 1 
second (19 errors, 2 warnings)
Processing block.strip.php [101 tokens in 35 lines]... DONE
in < 1 
second (22 errors, 2 warnings)
Processing block.textformat.php [416 tokens in 83 lines]...
DONE in < 1 
second (63 errors, 11 warnings)
Processing function.assign.php [125 tokens in 38 lines]...
DONE in < 1 
second (17 errors, 2 warnings)
Processing function.assign_debug_info.php [182 tokens in 39
lines]... 
DONE in < 1 second (15 errors, 1 warnings)
Processing function.config_load.php [1251 tokens in 130
lines]... DONE 
in 1 second (83 errors, 22 warnings)
Processing function.counter.php [478 tokens in 88 lines]...
DONE in 1 
second (37 errors, 1 warnings)
Processing function.cycle.php [650 tokens in 119 lines]...
DONE in < 1 
second (36 errors, 7 warnings)
Processing function.debug.php [104 tokens in 35 lines]...
DONE in 1 
second (20 errors, 4 warnings)
Processing function.eval.php [200 tokens in 48 lines]...
DONE in < 1 
second (20 errors, 1 warnings)
Processing function.fetch.php [1634 tokens in 217 lines]...
DONE in 1 
second (233 errors, 17 warnings)
Processing function.html_checkboxes.php [744 tokens in 135
lines]... 
DONE in 1 second (86 errors, 17 warnings)
Processing function.html_image.php [915 tokens in 143
lines]... DONE in 
< 1 second (56 errors, 26 warnings)
Processing function.html_options.php [734 tokens in 118
lines]... DONE 
in 1 second (83 errors, 17 warnings)
Processing function.html_radios.php [778 tokens in 138
lines]... DONE in 
1 second (84 errors, 19 warnings)
Processing function.html_select_date.php [1775 tokens in 243
lines]... 
DONE in 2 seconds (80 errors, 36 warnings)
Processing function.html_select_time.php [1367 tokens in 163
lines]... 
DONE in 1 second (40 errors, 37 warnings)
Processing function.html_table.php [649 tokens in 113
lines]... DONE in 
< 1 second (30 errors, 16 warnings)
Processing function.mailto.php [808 tokens in 140 lines]...
DONE in 1 
second (88 errors, 8 warnings)
Processing function.math.php [528 tokens in 82 lines]...
DONE in < 1 
second (39 errors, 5 warnings)
Processing function.popup.php [1220 tokens in 87 lines]...
DONE in 1 
second (122 errors, 6 warnings)
Processing function.popup_init.php [147 tokens in 39
lines]... DONE in < 
1 second (23 errors, 4 warnings)
Processing function.var_dump.php [45 tokens in 20 lines]...
DONE in < 1 
second (11 errors, 1 warnings)
Processing modifier.capitalize.php [43 tokens in 25
lines]... DONE in < 
1 second (13 errors, 2 warnings)
Processing modifier.cat.php [56 tokens in 33 lines]... DONE
in 1 second 
(16 errors, 3 warnings)
Processing modifier.count_characters.php [77 tokens in 31
lines]... DONE 
in < 1 second (16 errors, 1 warnings)
Processing modifier.count_paragraphs.php [55 tokens in 28
lines]... DONE 
in < 1 second (12 errors, 1 warnings)
Processing modifier.count_sentences.php [55 tokens in 28
lines]... DONE 
in < 1 second (12 errors, 1 warnings)
Processing modifier.count_words.php [80 tokens in 32
lines]... DONE in < 
1 second (13 errors, 1 warnings)
Processing modifier.date_format.php [147 tokens in 43
lines]... DONE in 
< 1 second (28 errors, 2 warnings)
Processing modifier.debug_print_var.php [418 tokens in 57
lines]... DONE 
in < 1 second (29 errors, 7 warnings)
Processing modifier.default.php [79 tokens in 31 lines]...
DONE in 1 
second (15 errors, 1 warnings)
Processing modifier.escape.php [330 tokens in 63 lines]...
DONE in < 1 
second (43 errors, 2 warnings)
Processing modifier.htmlentities.php [36 tokens in 18
lines]... DONE in 
< 1 second (9 errors, 1 warnings)
Processing modifier.indent.php [62 tokens in 27 lines]...
DONE in < 1 
second (24 errors, 1 warnings)
Processing modifier.lower.php [43 tokens in 25 lines]...
DONE in < 1 
second (13 errors, 1 warnings)
Processing modifier.nl2br.php [54 tokens in 35 lines]...
DONE in < 1 
second (12 errors, 3 warnings)
Processing modifier.rawurlencode.php [36 tokens in 18
lines]... DONE in 
< 1 second (9 errors, 1 warnings)
Processing modifier.regex_replace.php [60 tokens in 29
lines]... DONE in 
1 second (19 errors, 1 warnings)
Processing modifier.replace.php [60 tokens in 29 lines]...
DONE in < 1 
second (18 errors, 1 warnings)
Processing modifier.spacify.php [71 tokens in 29 lines]...
DONE in < 1 
second (15 errors, 1 warnings)
Processing modifier.string_format.php [53 tokens in 28
lines]... DONE in 
< 1 second (15 errors, 1 warnings)
Processing modifier.strip.php [65 tokens in 33 lines]...
DONE in < 1 
second (16 errors, 3 warnings)
Processing modifier.strip_tags.php [79 tokens in 31
lines]... DONE in < 
1 second (16 errors, 1 warnings)
Processing modifier.truncate.php [174 tokens in 43 lines]...
DONE in < 1 
second (25 errors, 1 warnings)
Processing modifier.upper.php [43 tokens in 25 lines]...
DONE in < 1 
second (13 errors, 1 warnings)
Processing modifier.wordwrap.php [64 tokens in 28 lines]...
DONE in < 1 
second (28 errors, 1 warnings)
Processing outputfilter.trimwhitespace.php [385 tokens in 75
lines]... 
DONE in 1 second (31 errors, 11 warnings)
Processing shared.escape_special_chars.php [111 tokens in 30
lines]... 
DONE in < 1 second (17 errors, 3 warnings)
Processing shared.make_timestamp.php [226 tokens in 43
lines]... DONE in 
< 1 second (29 errors, 2 warnings)
Processing Smarty.class.php [11198 tokens in 2010 lines]...
DONE in 8 
seconds (526 errors, 123 warnings)
Processing Smarty_Compiler.class.php [15903 tokens in 2123
lines]... 
DONE in 11 seconds (570 errors, 305 warnings)
Processing TutorialHighlightParser.inc [2779 tokens in 504
lines]... 
DONE in 2 seconds (137 errors, 26 warnings)
Processing WordParser.inc [1296 tokens in 337 lines]... DONE
in 1 second 
(76 errors, 14 warnings)
Processing XMLpackagePageParser.inc [4257 tokens in 580
lines]... DONE 
in 2 seconds (149 errors, 41 warnings)

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
Re: PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-07 18:20:22 
Gregory Beaver wrote:
> Hi Greg,
>
> I would be interested in investigating setting up
codesniffer as a cron
> job for checking PEPr proposals.  I'm assuming it would
time out if used
> to check a large proposal.  Have you tried it on
something vast like
> phpDocumentor

I've just sent the results of a run on phpDocumentor to
pear-dev, but it 
did take a very long time. I had to disable the time limit
on the script 
and set the memory limit very high so PHP_CodeSnffer could
store all the 
error messages during the run.

So running PHP_CodeSniffer on a big package like
phpDocumentor is 
possible, but you'll need a few resources to do it, or less
errors.

Greg

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php
Re: PHP_CodeSniffer as part of the pepr proposal process
user name
 2007-05-08 08:44:45 
On 5/7/07, Greg Sherwood <gsherwoodsquiz.net> wrote:
>
> I've just sent the results of a run on phpDocumentor to
pear-dev, but it
> did take a very long time. I had to disable the time
limit on the script
> and set the memory limit very high so PHP_CodeSnffer
could store all the
> error messages during the run.



Greg,

Any chance you could email me a tgz of all the specific
errors?  I'd like to
see what it will take to get PhpDocumentor into CS
compliance.

Thanks,
CRB
[1-8]

about | contact  Other archives ( Real Estate discussion Medical topics )