Proposal for Encryption::DES

Jim Wigginton (http://pear.php.n
et/user/terrafrost) proposes Encryption:ES.

You can find more detailed information here:
 http://pear.php.net/pepr/pepr-proposal-show.php?id=486


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

David Sanders (http://pear.php.ne
t/user/shangxiao) has commented on the proposal for
Encryption::Crypt_DES.

Comment:

All new packages should be written for only php 5 in mind ;)
 (So that
means var -> public/private, define -> const etc)

I'm not up to speed with encryption algorithms and libraries
and I'm not
sure if it would make much difference but it might be an
idea to provide
the user with the ability to choose whether to always use
the internal
implementation for consistency.

Other than that it looks pretty clean and easy to read...
I'll read
through it in more detail when I get some time ;)

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=486


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Jan Schneider (http://pear.php.net/u
ser/yunosh) has commented on the proposal for
Encryption::Crypt_DES.

Comment:

Very nice code. And I don't agree with David regarding the
mcrypt
integration, but that's nit picking anyway. Giving the user
the option to
choose the encryption engine doesn't hurt anyone.
You should add a few unit tests to the package before
calling for votes,
should be easy enough.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=486


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Christian Weiske (http://pear.php.net/
user/cweiske) has commented on the proposal for
Encryption::Crypt_DES.

Comment:

David is right with PHP5 only code for new packages.
When doing this, it'd also be good if you move the constants
into the
class. Also, the package needs unit tests.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=486


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Martin Jansen (http://pear.php.net/user/
mj) has commented on the proposal for
Encryption::Crypt_DES.

Comment:

Looks great!  Additionally to what the others said, I
suggest that you move
the TripleDES class into it's own file.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=486


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php