Re: +1 for Web Services::Services_Yadis

Thanks Adam,

I updated the package file for two small svn commits which
fix the example in the Yadis.php class header, and rectify
the API. Should be fitting the bill now ;).

Now sure how I missed Priority - there should have been a
getPriority() method since it's not reachable using the
generic getElements(). Well, there now.

Paddy
 
Pádraic Brady
http://blog.astrumfutura
.com
http://www.patternsforp
hp.com


----- Original Message ----
From: Adam Harvey <aharveyphp.net>
To: PEAR developer mailinglist <pear-devlists.php.net>
Cc: Adam Harvey <aharveyphp.net>; Pádraic Brady
<padraic.bradyyahoo.com>
Sent: Thursday, July 19, 2007 6:14:19 PM
Subject: [PEAR-DEV] [PEPr] +1 for Web
Services::Services_Yadis


Adam Harvey (http://pear.php.net/
user/aharvey) has voted +1 on the proposal for Web
Services::Services_Yadis.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=499
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php
?id=499&handle=aharvey

This vote is conditional. The condition is:

+1 assuming a couple of minor issues are fixed:

- Services_Yadis_Service::getDomObject() fails at present.
Changing $this->serviceNode to $this->_serviceNode
corrects this. I also suspect that using the approach in http://au2.php.net/manual/en/function.dom-im
port-simplexml.php#66996 for the SimpleXML to DOM
conversion will be quicker, too, given that it avoids a
reparse.

- The example refers to $service->getXmlObject();
presumably this should be getSimpleXmlObject(). Furthermore,
it attempts to load Priority as a child element, rather than
an attribute: changing the line to the following worked for
me:
echo 'Priority is ',
$service->getSimpleXmlObject()->attributes()->prior
ity, PHP_EOL;

All in all, though, it's the usual good work, Pádraic, and
I'm sure people wanting to use OpenID are encouraged by the
continuing progress to that end.

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php








       
____________________________________________________________
________________________
Get the free Yahoo! toolbar and rest assured with the added
security of spyware protection.
http://new.toolbar.yahoo.com/toolbar/features/nort
on/index.php