Re: cvs: pear /Services_W3C_HTMLValidator/docs/examples/PHPUnit URIValidationTest.php Val

Hi Brett,

This commit gave me opportunity to send to you a feedback
about 
Services_W3C_HTMLValidator.

I like the work you've done on this package, and because I
think someone 
else than me could use one of the other W3C validator
service (CSS 
validation), I've clone your package and adapted it to
prepare a 
Services_W3C_CSSValidator proposal (draft written yesterday
night).

During this preparation, I've noticed some typo error,
missing PHP5 
key-words  (such as public, protected ...) and other minor
details.
I'll send you a patch (differences between 1.0.0RC1 and my
check copy 
later).

Now my question : Is it the right location for a such test
code suite ?

Anyway, Thanks again, you make my job (new proposal) very
easy to do !

Best Regards,
Laurent

PS: I'll away (out of home today) so don't expect any reply
before 
tonight or tomorrow.

> saltybeagle		Sat Sep 29 17:02:40 2007 UTC
> 
>   Added files:                 
>    
/pear/Services_W3C_HTMLValidator/docs/examples/PHPUnit	
>                                                        
  	ValidationSuite.php 
>                                                        
  	URIValidationTest.php 
>   Log:
>   Sample PHPUnit html validation suite. Copy the two
files to your tests directory, modify the file
ValidationSuite.php to include the urls to validate, and
execute with php ValidationSuite.php or add it to your
existing test suite.
>   
> 

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Laurent,


> >    
/pear/Services_W3C_HTMLValidator/docs/examples/PHPUnit	
> >                                                   
       	ValidationSuite.php 
> >                                                   
       	URIValidationTest.php 
> Now my question : Is it the right location for a such
test code
> suite ?

I assume it shows you how to use W3C_HtmlValidator from your
own phpunit test suite.
In that case, it's the right location.


-- 
Mit freundlichen Grüßen/Regards,
Christian Weiske

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Hey Laurent,

On 9/30/07, Laurent Laville <pearlaurent-laville.org>
wrote:
> Hi Brett,
>
> This commit gave me opportunity to send to you a
feedback about
> Services_W3C_HTMLValidator.
>
> I like the work you've done on this package, and
because I think someone
> else than me could use one of the other W3C validator
service (CSS
> validation), I've clone your package and adapted it to
prepare a
> Services_W3C_CSSValidator proposal (draft written
yesterday night).

Cool.

> During this preparation, I've noticed some typo error,
missing PHP5
> key-words  (such as public, protected ...) and other
minor details.
> I'll send you a patch (differences between 1.0.0RC1 and
my check copy
> later).
>

Great!

> Now my question : Is it the right location for a such
test code suite ?
>

I think it is. The code is fairly simple, and was just
intended to
show how easy integrating HTML validation is. But if you're
alluding
to an additional assertion like assertHTMLIsValid, or
something like
that - that would be something entirely different, and as
that would
require some external libraries to phpunit I'm not sure how
that could
be integrated. A bit outside the scope of this simple
example.

> Anyway, Thanks again, you make my job (new proposal)
very easy to do !
>

Very good... I had planned on packages which would utilize
the W3C's
other validation services, but haven't had a reason to use
them in an
automated fashion yet.

> Best Regards,
> Laurent
>
> PS: I'll away (out of home today) so don't expect any
reply before
> tonight or tomorrow.
>
> > saltybeagle           Sat Sep 29 17:02:40 2007
UTC
> >
> >   Added files:
> >    
/pear/Services_W3C_HTMLValidator/docs/examples/PHPUnit
> >                                                   
           ValidationSuite.php
> >                                                   
           URIValidationTest.php
> >   Log:
> >   Sample PHPUnit html validation suite. Copy the
two files to your tests directory, modify the file
ValidationSuite.php to include the urls to validate, and
execute with php ValidationSuite.php or add it to your
existing test suite.
> >
> >
>


-- 
-Brett Bieber

http:saltybeagle.com aim:ianswerq

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php