Proposal for Web Services::Services_W3C_CSSValidator

Laurent Laville (http://pear.php.net/u
ser/farell) proposes Web
Services::Services_W3C_CSSValidator.

You can find more detailed information here:
 http://pear.php.net/pepr/pepr-proposal-show.php?id=510


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Chuck Burgess (http://pear.php.net/
user/ashnazg) has commented on the proposal for Web
Services::Services_W3C_CSSValidator.

Comment:

Impressive encapsulation, right from the start... when can I
vote :P

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=510


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Chuck Burgess a écrit :
> Chuck Burgess (http://pear.php.net/
user/ashnazg) has commented on the proposal for Web
Services::Services_W3C_CSSValidator.
> 
> Comment:
> 
> Impressive encapsulation, right from the start... when
can I vote :P
> 
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=510

> 

I will open vote for this proposal next monday (October
22nd). So If 
someone has anything to ask or tell, you've still 4 days to
do it !

Regards
Laurent

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Chuck Burgess a écrit :
> Chuck Burgess (http://pear.php.net/
user/ashnazg) has commented on the proposal for Web
Services::Services_W3C_CSSValidator.
> 
> Comment:
> 
> Impressive encapsulation, right from the start... when
can I vote :P
> 
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=510

> 

I will open vote for this proposal next monday (October
22nd). So If 
someone has anything to ask or tell, you've still 4 days to
do it !

Regards
Laurent

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Laurent Laville (http://pear.php.net/u
ser/farell) has initiated the call for votes on Web
Services::Services_W3C_CSSValidator.

Please review the proposal and give your vote here:
http://pear.php.net/pepr/pepr-proposal-show.php?id=510


-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Chuck Burgess (http://pear.php.net/
user/ashnazg) has voted +1 on the proposal for Web
Services::Services_W3C_CSSValidator.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=510

Vote information:
http://pear.php.net/pepr/pepr-vote-show.php
?id=510&handle=ashnazg

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

David Coallier (http://pear.php.net/u
ser/davidc) has voted +1 on the proposal for Web
Services::Services_W3C_CSSValidator.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=510

Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?
id=510&handle=davidc

Comment:

Sorry I was on holidays thus could not comment 

I am +1. 

I would probably make a few simple changes:

In Services_W3C_CSSValidator
-------------------

public $validator_uri a constant

Perhaps add a bit of setters and getters instead of only
using setOptions,
maybe some strict/controlled magic through __call, __set,
__get.

I would put constants (Top of class) where we can easily
change node
names: $element = $doc->getElementsByTagName('validity');
for instance
would become 
$element =
$doc->getElementsByTagName(SERVICES_W3C_CSSValidator_NODE
_VALIDITY);

I know it is the w3c and they rarely change formats or node
names
(Basically never) but what if...

same applies for 'error' and 'warning'

Overparanoid ? Maybe  

Next,

$response->error[] = new
Services_W3C_CSSValidator_Error($error);

Should become : 

$response->addError(new
Services_W3C_CSSValidator_Error($error));


This is not a standard but I think the interface is much
easier to read
afterwards if one goes over the code instead of looking at
how and where
the errors were added, etc etc.

Same goes for warning.

Again, this is personal preferences but I consider them to
be common sense
to me but you might not even consider them .

P.S. I think all variable setting and getting outside a
class should be
accessed using setters and getters. No public variable
(imho) should be set
in any ways. (Protected? Perhaps.. )

Good work nonetheless btw  You
keep my +1

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Brett Bieber (http://pear.php.
net/user/saltybeagle) has voted +1 on the proposal for
Web Services::Services_W3C_CSSValidator.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=510

Vote information:
http://pear.php.net/pepr/pepr-vote-show
.php?id=510&handle=saltybeagle

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php

Till Klampaeckel (http://pear.php.net/use
r/till) has voted +1 on the proposal for Web
Services::Services_W3C_CSSValidator.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=510

Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id
=510&handle=till

This vote is conditional. The condition is:

I second the getter/setter request. I think I commented on
it, but maybe it got lost on pear-dev. Aside from that it
looks good.

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub
.php